mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
To: Joe Perches <joe@perches.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"Allan, Bruce W" <bruce.w.allan@intel.com>,
	Anish Kumar <anish198519851985@gmail.com>,
	Andy Whitcroft <apw@canonical.com>
Subject: Re: [PATCH] checkpatch: do not test/warn of leading whitespace before signature tags
Date: Thu, 18 Aug 2011 01:43:41 -0700	[thread overview]
Message-ID: <1313657022.2128.116.camel@jtkirshe-mobl> (raw)
In-Reply-To: <1313656307.32547.73.camel@Joe-Laptop>

[-- Attachment #1: Type: text/plain, Size: 864 bytes --]

On Thu, 2011-08-18 at 01:31 -0700, Joe Perches wrote:
> On Thu, 2011-08-18 at 01:26 -0700, Jeff Kirsher wrote:
> > I understand what you saying and asking, my point here is the that the
> > "default" style should be understood by checkpatch.pl and not produce
> > false warnings.
> 
> And I still disagree.
> 
> checkpatch should consider whatever
> input it gets as if it's a patch.
> 
> So, if you really want to feed
> git log output as input to checkpatch
> you should format that output
> appropriately and the best way to do
> that is to use git log --format=etc.
> 
> Don't suggest removing useful checks.
> 

I understand what your saying, and I think that your suggestion about
possibly implementing a "--input=git" option to checkpatch.pl might be a
happy middle ground to resolve the numerous false warnings this check
produces.

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 490 bytes --]

  reply	other threads:[~2011-08-18  8:43 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-18  6:48 Jeff Kirsher
2011-08-18  7:26 ` Joe Perches
2011-08-18  7:47   ` Jeff Kirsher
2011-08-18  7:59     ` Joe Perches
2011-08-18  8:07       ` Jeff Kirsher
2011-08-18  8:16         ` Joe Perches
2011-08-18  8:26           ` Jeff Kirsher
2011-08-18  8:31             ` Joe Perches
2011-08-18  8:43               ` Jeff Kirsher [this message]
2011-08-18  8:56                 ` Joe Perches
2011-08-18  9:21                   ` Jeff Kirsher
2011-08-18  8:16       ` Jeff Kirsher
2011-08-19 14:13       ` Michal Marek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1313657022.2128.116.camel@jtkirshe-mobl \
    --to=jeffrey.t.kirsher@intel.com \
    --cc=anish198519851985@gmail.com \
    --cc=apw@canonical.com \
    --cc=bruce.w.allan@intel.com \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®