From: Joe Perches <joe@perches.com>
To: Jim Cromie <jim.cromie@gmail.com>
Cc: Jason Baron <jbaron@redhat.com>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: RFC: dynamic debug enhancements?
Date: Mon, 29 Aug 2011 11:35:26 -0700 [thread overview]
Message-ID: <1314642926.6852.26.camel@Joe-Laptop> (raw)
In-Reply-To: <CAJfuBxwFvRvy=umR-C1S8+pawQ8HtD_m-X5zAQ0cTBpCkpWcHA@mail.gmail.com>
On Mon, 2011-08-29 at 12:21 -0600, Jim Cromie wrote:
> how about just passing in condition directly ?
> #define pr_dbg_if( cond, fmt, ... ) \
> do { \
> if (cond) \
> pr_debug(fmt, ##__VA_ARGS__); \
> } while (0)
> this will serve both mask and level, and could underlie both of them,
> and its clear - no hidden checks against a variable named elsewhere.
The idea is to let dynamic debug control the
output for the various mask/level tests.
That could get out of sync with pr_debug.
It separates the pr_debug condition from the test.
prev parent reply other threads:[~2011-08-29 18:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-22 0:15 Joe Perches
2011-08-23 14:23 ` Jason Baron
2011-08-24 1:00 ` Joe Perches
2011-08-29 18:21 ` Jim Cromie
2011-08-29 18:35 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1314642926.6852.26.camel@Joe-Laptop \
--to=joe@perches.com \
--cc=jbaron@redhat.com \
--cc=jim.cromie@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®