* [PATCH 1/1] drivers/amba/bus.c: Don't perform extra matching when any one fails
@ 2011-09-01 17:55 Kautuk Consul
0 siblings, 0 replies; only message in thread
From: Kautuk Consul @ 2011-09-01 17:55 UTC (permalink / raw)
To: Russell King; +Cc: linux-kernel, Kautuk Consul
If any one operation fails, then r anyways gets set to 0, which will
cause the device to not match the find_data.
Signed-off-by: Kautuk Consul <consul.kautuk@gmail.com>
---
drivers/amba/bus.c | 10 ++++++----
1 files changed, 6 insertions(+), 4 deletions(-)
diff --git a/drivers/amba/bus.c b/drivers/amba/bus.c
index d74926e..af2e0a1 100644
--- a/drivers/amba/bus.c
+++ b/drivers/amba/bus.c
@@ -699,10 +699,12 @@ static int amba_find_match(struct device *dev, void *data)
int r;
r = (pcdev->periphid & d->mask) == d->id;
- if (d->parent)
- r &= d->parent == dev->parent;
- if (d->busid)
- r &= strcmp(dev_name(dev), d->busid) == 0;
+ if (r) {
+ if (d->parent)
+ r &= d->parent == dev->parent;
+ if (r && d->busid)
+ r &= strcmp(dev_name(dev), d->busid) == 0;
+ }
if (r) {
get_device(dev);
--
1.7.4.1
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2011-09-01 17:55 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-09-01 17:55 [PATCH 1/1] drivers/amba/bus.c: Don't perform extra matching when any one fails Kautuk Consul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®