[PATCH] parse-events: Allow expressions in __print_symbolic() fields

[PATCH] parse-events: Allow expressions in __print_symbolic() fields

[Stefan Hajnoczi]

The __print_symbolic() function takes a sequence of key-value pairs for
pretty-printing a constant.  The new kvm:kvm_exit print fmt uses the
expression:

  __print_symbolic(..., { 0x040 + 1, "DB excp" }, ...)

Currently only atoms are supported and this print fmt fails to parse.
This patch adds support for expressions instead of just atoms so that
0x040 + 1 is parsed successfully.

Signed-off-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
---
 parse-events.c |    7 +++++++
 1 files changed, 7 insertions(+), 0 deletions(-)

diff --git a/parse-events.c b/parse-events.c
index 1cdc3a9..e9b7e7d 100644
--- a/parse-events.c
+++ b/parse-events.c
@@ -2110,6 +2110,13 @@ process_fields(struct event_format *event, struct print_flag_sym **list, char **
 
 		free_token(token);
 		type = process_arg(event, arg, &token);
+
+		if (type == EVENT_OP)
+			type = process_op(event, arg, &token);
+
+		if (type == EVENT_ERROR)
+			goto out_free;
+
 		if (test_type_token(type, token, EVENT_DELIM, ","))
 			goto out_free;
 
-- 
1.7.5.4

Re: [PATCH] parse-events: Allow expressions in __print_symbolic() fields

[Steven Rostedt]

On Sun, 2011-09-04 at 11:25 +0100, Stefan Hajnoczi wrote:
> The __print_symbolic() function takes a sequence of key-value pairs for
> pretty-printing a constant.  The new kvm:kvm_exit print fmt uses the
> expression:
> 
>   __print_symbolic(..., { 0x040 + 1, "DB excp" }, ...)
> 
> Currently only atoms are supported and this print fmt fails to parse.
> This patch adds support for expressions instead of just atoms so that
> 0x040 + 1 is parsed successfully.

Egad! Doing some early spring cleaning of my Inbox I stumbled across
this patch.

I'll apply it now, thanks!

Hey, if you ever send me a patch and after a week I don't reply to it,
don't be afraid to ping me about it. I sometimes get swarms of email
that I skim over, and will sometimes miss something like this.

Thanks!

-- Steve

> 
> Signed-off-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
> ---
>  parse-events.c |    7 +++++++
>  1 files changed, 7 insertions(+), 0 deletions(-)
> 
> diff --git a/parse-events.c b/parse-events.c
> index 1cdc3a9..e9b7e7d 100644
> --- a/parse-events.c
> +++ b/parse-events.c
> @@ -2110,6 +2110,13 @@ process_fields(struct event_format *event, struct print_flag_sym **list, char **
>  
>  		free_token(token);
>  		type = process_arg(event, arg, &token);
> +
> +		if (type == EVENT_OP)
> +			type = process_op(event, arg, &token);
> +
> +		if (type == EVENT_ERROR)
> +			goto out_free;
> +
>  		if (test_type_token(type, token, EVENT_DELIM, ","))
>  			goto out_free;
>  

Re: [PATCH] parse-events: Allow expressions in __print_symbolic() fields

[Stefan Hajnoczi]

On Wed, Feb 08, 2012 at 08:36:04PM -0500, Steven Rostedt wrote:
> On Sun, 2011-09-04 at 11:25 +0100, Stefan Hajnoczi wrote:
> > The __print_symbolic() function takes a sequence of key-value pairs for
> > pretty-printing a constant.  The new kvm:kvm_exit print fmt uses the
> > expression:
> > 
> >   __print_symbolic(..., { 0x040 + 1, "DB excp" }, ...)
> > 
> > Currently only atoms are supported and this print fmt fails to parse.
> > This patch adds support for expressions instead of just atoms so that
> > 0x040 + 1 is parsed successfully.
> 
> Egad! Doing some early spring cleaning of my Inbox I stumbled across
> this patch.
> 
> I'll apply it now, thanks!
> 
> Hey, if you ever send me a patch and after a week I don't reply to it,
> don't be afraid to ping me about it. I sometimes get swarms of email
> that I skim over, and will sometimes miss something like this.

I appreciate it, thanks!  I forgot about this one myself :).

Stefan