From: Shaohua Li <shaohua.li@intel.com>
To: lkml <linux-kernel@vger.kernel.org>
Cc: Jens Axboe <jaxboe@fusionio.com>, Tejun Heo <htejun@gmail.com>,
Vivek Goyal <vgoyal@redhat.com>
Subject: [RFC]block: don't mark flush request as SOFTBARRIER
Date: Thu, 08 Sep 2011 09:29:54 +0800 [thread overview]
Message-ID: <1315445394.29510.71.camel@sli10-conroe> (raw)
I'm wondering why flush request should be marked as SOFTBARRIER. Current flush
sequence guarantees the correctness of flush even the request is reordered by
ioscheduler.
Signed-off-by: Shaohua Li <shaohua.li@intel.com>
diff --git a/block/elevator.c b/block/elevator.c
index a3b64bc..e589b76 100644
--- a/block/elevator.c
+++ b/block/elevator.c
@@ -715,7 +715,6 @@ void __elv_add_request(struct request_queue *q, struct request *rq, int where)
break;
case ELEVATOR_INSERT_FLUSH:
- rq->cmd_flags |= REQ_SOFTBARRIER;
blk_insert_flush(rq);
break;
default:
next reply other threads:[~2011-09-08 1:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-08 1:29 Shaohua Li [this message]
2011-09-11 2:51 ` Tejun Heo
2011-09-13 1:04 ` Shaohua Li
2011-09-13 7:46 ` Tejun Heo
2011-09-14 6:04 ` Shaohua Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1315445394.29510.71.camel@sli10-conroe \
--to=shaohua.li@intel.com \
--cc=htejun@gmail.com \
--cc=jaxboe@fusionio.com \
--cc=linux-kernel@vger.kernel.org \
--cc=vgoyal@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®