mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Tejun Heo <htejun@gmail.com>
To: Shaohua Li <shaohua.li@intel.com>
Cc: lkml <linux-kernel@vger.kernel.org>,
	Jens Axboe <jaxboe@fusionio.com>, Vivek Goyal <vgoyal@redhat.com>
Subject: Re: [RFC]block: don't mark flush request as SOFTBARRIER
Date: Tue, 13 Sep 2011 16:46:53 +0900	[thread overview]
Message-ID: <20110913074653.GC11397@mtj.dyndns.org> (raw)
In-Reply-To: <1315875841.29510.80.camel@sli10-conroe>

Hello, Shaohua.

On Tue, Sep 13, 2011 at 09:04:01AM +0800, Shaohua Li wrote:
> we do the flush first and then dispatch the data. The flush is
> already delayed a lot, so if latency is a problem, we already saw
> it.

I don't necessarily agree with the above.  We don't induce any extra
latency for flushes which don't overlap.

> Why not just remove SOFTBARRIER and use elv_dispatch_sort() for
> flush data so drive can better arrange requests?

Maybe, I don't know.  Elevator sorting on writes is likely to be much
less important to begin with.  Combined with the fact that sorting
flush data would require more writes to be flushed by the following
flush, I don't think it would be clear which way would be better.  If
it can be shown that sorting flush data is better, why not?

Thanks.

-- 
tejun

  reply	other threads:[~2011-09-13  7:53 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-08  1:29 Shaohua Li
2011-09-11  2:51 ` Tejun Heo
2011-09-13  1:04   ` Shaohua Li
2011-09-13  7:46     ` Tejun Heo [this message]
2011-09-14  6:04       ` Shaohua Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110913074653.GC11397@mtj.dyndns.org \
    --to=htejun@gmail.com \
    --cc=jaxboe@fusionio.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=shaohua.li@intel.com \
    --cc=vgoyal@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®