mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH 1/1] Trivial: devtmpfs.c: No need to set the task state to TASK_RUNNING
@ 2011-09-08 15:06 Kautuk Consul
  2011-09-21 15:36 ` kautuk.c @samsung.com
  0 siblings, 1 reply; 2+ messages in thread
From: Kautuk Consul @ 2011-09-08 15:06 UTC (permalink / raw)
  To: Greg Kroah-Hartman, Jiri Kosina; +Cc: linux-kernel, Kautuk Consul

I think that there should be no need to set the task state to
TASK_RUNNING as wake_up_process will do that for us.

Signed-off-by: Kautuk Consul <consul.kautuk@gmail.com>
---
 drivers/base/devtmpfs.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/drivers/base/devtmpfs.c b/drivers/base/devtmpfs.c
index a4760e0..8a3f028 100644
--- a/drivers/base/devtmpfs.c
+++ b/drivers/base/devtmpfs.c
@@ -416,7 +416,6 @@ static int devtmpfsd(void *p)
 		set_current_state(TASK_INTERRUPTIBLE);
 		spin_unlock(&req_lock);
 		schedule();
-		__set_current_state(TASK_RUNNING);
 	}
 	return 0;
 out:
-- 
1.7.4.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH 1/1] Trivial: devtmpfs.c: No need to set the task state to TASK_RUNNING
  2011-09-08 15:06 [PATCH 1/1] Trivial: devtmpfs.c: No need to set the task state to TASK_RUNNING Kautuk Consul
@ 2011-09-21 15:36 ` kautuk.c @samsung.com
  0 siblings, 0 replies; 2+ messages in thread
From: kautuk.c @samsung.com @ 2011-09-21 15:36 UTC (permalink / raw)
  To: Greg Kroah-Hartman, Jiri Kosina, jkosina; +Cc: linux-kernel, Kautuk Consul

Hi,

Please ignore this trivial patch.
I found one more trivial change which I would like to make in this
patch, so I'll resend
this one in a separate email chain.

Thanks,
Kautuk.

On Thu, Sep 8, 2011 at 8:36 PM, Kautuk Consul <consul.kautuk@gmail.com> wrote:
> I think that there should be no need to set the task state to
> TASK_RUNNING as wake_up_process will do that for us.
>
> Signed-off-by: Kautuk Consul <consul.kautuk@gmail.com>
> ---
>  drivers/base/devtmpfs.c |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/base/devtmpfs.c b/drivers/base/devtmpfs.c
> index a4760e0..8a3f028 100644
> --- a/drivers/base/devtmpfs.c
> +++ b/drivers/base/devtmpfs.c
> @@ -416,7 +416,6 @@ static int devtmpfsd(void *p)
>                set_current_state(TASK_INTERRUPTIBLE);
>                spin_unlock(&req_lock);
>                schedule();
> -               __set_current_state(TASK_RUNNING);
>        }
>        return 0;
>  out:
> --
> 1.7.4.1
>
>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2011-09-21 15:36 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-09-08 15:06 [PATCH 1/1] Trivial: devtmpfs.c: No need to set the task state to TASK_RUNNING Kautuk Consul
2011-09-21 15:36 ` kautuk.c @samsung.com

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®