From: Ian Kent <raven@themaw.net>
To: H Hartley Sweeten <hartleys@visionengravers.com>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>, autofs@linux.kernel.org
Subject: Re: [PATCH] autofs4/root.c: quiet sparse noise
Date: Sat, 10 Sep 2011 14:12:18 +0800 [thread overview]
Message-ID: <1315635138.3171.1.camel@perseus.themaw.net> (raw)
In-Reply-To: <201109091717.02975.hartleys@visionengravers.com>
On Fri, 2011-09-09 at 17:17 -0700, H Hartley Sweeten wrote:
> The function autofs4_d_manage is prototyped as a static function.
> Add static to the function to quiet the sparse noise:
>
> warning: symbol 'autofs4_d_manage' was not declared. Should it be static?
>
> Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
> Cc: Ian Kent <raven@themaw.net>
Thought I had done that in the original series ....
Acked-by: Ian Kent <raven@themaw.net>
>
> ---
>
> diff --git a/fs/autofs4/root.c b/fs/autofs4/root.c
> index f55ae23..366a9f2 100644
> --- a/fs/autofs4/root.c
> +++ b/fs/autofs4/root.c
> @@ -427,7 +427,7 @@ done:
> return NULL;
> }
>
> -int autofs4_d_manage(struct dentry *dentry, bool rcu_walk)
> +static int autofs4_d_manage(struct dentry *dentry, bool rcu_walk)
> {
> struct autofs_sb_info *sbi = autofs4_sbi(dentry->d_sb);
>
prev parent reply other threads:[~2011-09-10 6:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-10 0:17 H Hartley Sweeten
2011-09-10 6:12 ` Ian Kent [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1315635138.3171.1.camel@perseus.themaw.net \
--to=raven@themaw.net \
--cc=autofs@linux.kernel.org \
--cc=hartleys@visionengravers.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®