* [PATCH] autofs4/root.c: quiet sparse noise
@ 2011-09-10 0:17 H Hartley Sweeten
2011-09-10 6:12 ` Ian Kent
0 siblings, 1 reply; 2+ messages in thread
From: H Hartley Sweeten @ 2011-09-10 0:17 UTC (permalink / raw)
To: Linux Kernel; +Cc: autofs, raven
The function autofs4_d_manage is prototyped as a static function.
Add static to the function to quiet the sparse noise:
warning: symbol 'autofs4_d_manage' was not declared. Should it be static?
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Kent <raven@themaw.net>
---
diff --git a/fs/autofs4/root.c b/fs/autofs4/root.c
index f55ae23..366a9f2 100644
--- a/fs/autofs4/root.c
+++ b/fs/autofs4/root.c
@@ -427,7 +427,7 @@ done:
return NULL;
}
-int autofs4_d_manage(struct dentry *dentry, bool rcu_walk)
+static int autofs4_d_manage(struct dentry *dentry, bool rcu_walk)
{
struct autofs_sb_info *sbi = autofs4_sbi(dentry->d_sb);
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] autofs4/root.c: quiet sparse noise
2011-09-10 0:17 [PATCH] autofs4/root.c: quiet sparse noise H Hartley Sweeten
@ 2011-09-10 6:12 ` Ian Kent
0 siblings, 0 replies; 2+ messages in thread
From: Ian Kent @ 2011-09-10 6:12 UTC (permalink / raw)
To: H Hartley Sweeten; +Cc: Linux Kernel, autofs
On Fri, 2011-09-09 at 17:17 -0700, H Hartley Sweeten wrote:
> The function autofs4_d_manage is prototyped as a static function.
> Add static to the function to quiet the sparse noise:
>
> warning: symbol 'autofs4_d_manage' was not declared. Should it be static?
>
> Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
> Cc: Ian Kent <raven@themaw.net>
Thought I had done that in the original series ....
Acked-by: Ian Kent <raven@themaw.net>
>
> ---
>
> diff --git a/fs/autofs4/root.c b/fs/autofs4/root.c
> index f55ae23..366a9f2 100644
> --- a/fs/autofs4/root.c
> +++ b/fs/autofs4/root.c
> @@ -427,7 +427,7 @@ done:
> return NULL;
> }
>
> -int autofs4_d_manage(struct dentry *dentry, bool rcu_walk)
> +static int autofs4_d_manage(struct dentry *dentry, bool rcu_walk)
> {
> struct autofs_sb_info *sbi = autofs4_sbi(dentry->d_sb);
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-09-10 6:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-09-10 0:17 [PATCH] autofs4/root.c: quiet sparse noise H Hartley Sweeten
2011-09-10 6:12 ` Ian Kent
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®