From: Glauber Costa <glommer@parallels.com>
To: linux-kernel@vger.kernel.org
Cc: xemul@parallels.com, paul@paulmenage.org, lizf@cn.fujitsu.com,
daniel.lezcano@free.fr, mingo@elte.hu, a.p.zijlstra@chello.nl,
jbottomley@parallels.com, Glauber Costa <glommer@parallels.com>
Subject: [PATCH 9/9] Report steal time for cgroup
Date: Wed, 14 Sep 2011 17:04:55 -0300 [thread overview]
Message-ID: <1316030695-19826-10-git-send-email-glommer@parallels.com> (raw)
In-Reply-To: <1316030695-19826-1-git-send-email-glommer@parallels.com>
This patch introduces a functionality commonly found in
hypervisors: steal time.
For those not particularly familiar with it, steal time
is defined as any time in which a virtual machine (or container)
wanted to perform cpu work, but could not due to another
VM/container being scheduled in its place. Note that idle
time is never defined as steal time.
Assuming each container will live in its cgroup, we can
very easily and nicely calculate steal time as all user/system
time recorded in our sibling cgroups.
Signed-off-by: Glauber Costa <glommer@parallels.com>
---
kernel/sched.c | 30 ++++++++++++++++++++++++++++++
1 files changed, 30 insertions(+), 0 deletions(-)
diff --git a/kernel/sched.c b/kernel/sched.c
index 8f254d0..2dad1e0 100644
--- a/kernel/sched.c
+++ b/kernel/sched.c
@@ -9321,6 +9321,7 @@ static int cpuacct_proc_stat(struct cgroup *cgrp, struct cftype *cft,
struct cpuacct *ca = cgroup_ca(cgrp);
struct timespec ts;
u64 *cpustat;
+ struct cgroup *sib;
user = nice = system = idle = iowait =
irq = softirq = steal = cputime64_zero;
@@ -9343,6 +9344,20 @@ static int cpuacct_proc_stat(struct cgroup *cgrp, struct cftype *cft,
irq = cputime64_add(irq, cpustat[CPUACCT_STAT_IRQ]);
softirq = cputime64_add(softirq, cpustat[CPUACCT_STAT_SOFTIRQ]);
steal = cputime64_add(steal, kstat_cpu(i).cpustat.steal);
+ rcu_read_lock();
+ list_for_each_entry(sib, &ca->css.cgroup->sibling, sibling) {
+ u64 *cpustat_sib;
+ struct cpuacct *ca_sib = cgroup_ca(sib);
+ if (!ca_sib)
+ continue;
+
+ cpustat_sib = per_cpu_ptr(ca_sib->cpustat, i);
+ steal = cputime64_add(steal, cpustat_sib[CPUACCT_STAT_USER]);
+ steal = cputime64_add(steal, cpustat_sib[CPUACCT_STAT_SYSTEM]);
+ steal = cputime64_add(steal, cpustat_sib[CPUACCT_STAT_IRQ]);
+ steal = cputime64_add(steal, cpustat_sib[CPUACCT_STAT_SOFTIRQ]);
+ }
+ rcu_read_unlock();
guest = cputime64_add(guest, cpustat[CPUACCT_STAT_GUEST]);
guest_nice = cputime64_add(guest_nice,
cpustat[CPUACCT_STAT_GUEST_NICE]);
@@ -9384,6 +9399,21 @@ static int cpuacct_proc_stat(struct cgroup *cgrp, struct cftype *cft,
irq = cpustat[CPUACCT_STAT_IRQ];
softirq = cpustat[CPUACCT_STAT_SOFTIRQ];
steal = kstat_cpu(i).cpustat.steal;
+ rcu_read_lock();
+ list_for_each_entry(sib, &ca->css.cgroup->sibling, sibling) {
+ u64 *cpustat_sib;
+ struct cpuacct *ca_sib = cgroup_ca(sib);
+
+ if (!ca_sib)
+ continue;
+ cpustat_sib = per_cpu_ptr(ca_sib->cpustat, i);
+ steal = cputime64_add(steal, cpustat_sib[CPUACCT_STAT_USER]);
+ steal = cputime64_add(steal, cpustat_sib[CPUACCT_STAT_SYSTEM]);
+ steal = cputime64_add(steal, cpustat_sib[CPUACCT_STAT_IRQ]);
+ steal = cputime64_add(steal, cpustat_sib[CPUACCT_STAT_SOFTIRQ]);
+ }
+ rcu_read_unlock();
+
guest = cpustat[CPUACCT_STAT_GUEST];
guest_nice = cpustat[CPUACCT_STAT_GUEST_NICE];
seq_printf(p,
--
1.7.6
next prev parent reply other threads:[~2011-09-14 20:06 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-14 20:04 [PATCH 0/9] Per-cgroup /proc/stat Glauber Costa
2011-09-14 20:04 ` [PATCH 1/9] Remove parent field in cpuacct cgroup Glauber Costa
2011-09-19 16:03 ` Peter Zijlstra
2011-09-19 16:09 ` Glauber Costa
2011-09-19 16:19 ` Peter Zijlstra
2011-09-19 16:30 ` Glauber Costa
2011-09-19 16:39 ` Peter Zijlstra
2011-09-19 16:41 ` Glauber Costa
2011-09-19 18:40 ` Peter Zijlstra
2011-09-20 17:29 ` Srivatsa Vaddagiri
2011-09-22 15:11 ` Balbir Singh
2011-09-22 15:17 ` Peter Zijlstra
2011-09-23 8:09 ` Balbir Singh
2011-09-23 14:35 ` Peter Zijlstra
2011-09-23 15:45 ` Glauber Costa
2011-09-19 18:35 ` Peter Zijlstra
2011-09-19 18:38 ` Glauber Costa
2011-09-19 18:44 ` Peter Zijlstra
2011-09-19 19:14 ` Glauber Costa
2011-09-19 19:18 ` Peter Zijlstra
2011-09-19 19:19 ` Glauber Costa
2011-09-14 20:04 ` [PATCH 2/9] Make cpuacct fields per cpu variables Glauber Costa
2011-09-19 16:10 ` Peter Zijlstra
2011-09-14 20:04 ` [PATCH 3/9] Include nice values in cpuacct Glauber Costa
2011-09-19 16:19 ` Peter Zijlstra
2011-09-19 16:26 ` Glauber Costa
2011-09-19 18:36 ` Peter Zijlstra
2011-09-19 18:37 ` Glauber Costa
2011-09-14 20:04 ` [PATCH 4/9] Include irq and softirq fields " Glauber Costa
2011-09-19 18:38 ` Peter Zijlstra
2011-09-19 18:40 ` Glauber Costa
2011-09-14 20:04 ` [PATCH 5/9] Include guest " Glauber Costa
2011-09-14 20:04 ` [PATCH 6/9] Include idle and iowait " Glauber Costa
2011-09-20 9:21 ` Peter Zijlstra
2011-09-20 12:36 ` Glauber Costa
2011-09-20 12:58 ` Peter Zijlstra
2011-09-20 12:58 ` Glauber Costa
2011-09-20 13:05 ` Peter Zijlstra
2011-09-20 13:29 ` Glauber Costa
2011-09-14 20:04 ` [PATCH 7/9] Create cpuacct.proc.stat file Glauber Costa
2011-09-20 9:22 ` Peter Zijlstra
2011-09-20 12:22 ` Glauber Costa
2011-09-14 20:04 ` [PATCH 8/9] per-cgroup boot time Glauber Costa
2011-09-20 9:25 ` Peter Zijlstra
2011-09-20 12:37 ` Glauber Costa
2011-09-20 13:04 ` Peter Zijlstra
2011-09-20 13:06 ` Glauber Costa
2011-09-20 13:31 ` Peter Zijlstra
2011-09-14 20:04 ` Glauber Costa [this message]
2011-09-20 9:29 ` [PATCH 9/9] Report steal time for cgroup Peter Zijlstra
2011-09-14 20:13 ` [PATCH 0/9] Per-cgroup /proc/stat Peter Zijlstra
2011-09-14 20:20 ` Glauber Costa
2011-09-15 8:53 ` Peter Zijlstra
2011-09-14 20:23 ` Andi Kleen
2011-09-15 8:56 ` Peter Zijlstra
2011-09-19 23:07 ` Paul Turner
2011-09-20 8:33 ` Peter Zijlstra
2011-09-20 21:37 ` Glauber Costa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1316030695-19826-10-git-send-email-glommer@parallels.com \
--to=glommer@parallels.com \
--cc=a.p.zijlstra@chello.nl \
--cc=daniel.lezcano@free.fr \
--cc=jbottomley@parallels.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lizf@cn.fujitsu.com \
--cc=mingo@elte.hu \
--cc=paul@paulmenage.org \
--cc=xemul@parallels.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®