mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Yong Zhang <yong.zhang0@gmail.com>
To: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org
Cc: tglx@linutronix.de, yong.zhang0@gmail.com,
	Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
	x86@kernel.org, "Venkatesh Pallipadi (Venki)" <venki@google.com>,
	Jeremy Fitzhardinge <jeremy.fitzhardinge@citrix.com>,
	Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	Paul Gortmaker <paul.gortmaker@windriver.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Ralf Baechle <ralf@linux-mips.org>,
	xen-devel@lists.xensource.com,
	virtualization@lists.linux-foundation.org
Subject: [PATCH 21/55] x86: irq: Remove IRQF_DISABLED
Date: Thu, 22 Sep 2011 16:58:48 +0800	[thread overview]
Message-ID: <1316681962-8217-22-git-send-email-yong.zhang0@gmail.com> (raw)
In-Reply-To: <1316681962-8217-1-git-send-email-yong.zhang0@gmail.com>

Since commit [e58aa3d2: genirq: Run irq handlers with interrupts disabled],
We run all interrupt handlers with interrupts disabled
and we even check and yell when an interrupt handler
returns with interrupts enabled (see commit [b738a50a:
genirq: Warn when handler enables interrupts]).

So now this flag is a NOOP and can be removed.

Signed-off-by: Yong Zhang <yong.zhang0@gmail.com>
---
 arch/x86/include/asm/floppy.h |    4 ++--
 arch/x86/kernel/hpet.c        |    2 +-
 arch/x86/kernel/time.c        |    2 +-
 arch/x86/xen/smp.c            |    8 ++++----
 arch/x86/xen/spinlock.c       |    2 +-
 arch/x86/xen/time.c           |    5 ++---
 6 files changed, 11 insertions(+), 12 deletions(-)

diff --git a/arch/x86/include/asm/floppy.h b/arch/x86/include/asm/floppy.h
index dbe82a5..22bf4d6 100644
--- a/arch/x86/include/asm/floppy.h
+++ b/arch/x86/include/asm/floppy.h
@@ -145,10 +145,10 @@ static int fd_request_irq(void)
 {
 	if (can_use_virtual_dma)
 		return request_irq(FLOPPY_IRQ, floppy_hardint,
-				   IRQF_DISABLED, "floppy", NULL);
+				   0, "floppy", NULL);
 	else
 		return request_irq(FLOPPY_IRQ, floppy_interrupt,
-				   IRQF_DISABLED, "floppy", NULL);
+				   0, "floppy", NULL);
 }
 
 static unsigned long dma_mem_alloc(unsigned long size)
diff --git a/arch/x86/kernel/hpet.c b/arch/x86/kernel/hpet.c
index b946a9e..5c21a30 100644
--- a/arch/x86/kernel/hpet.c
+++ b/arch/x86/kernel/hpet.c
@@ -516,7 +516,7 @@ static int hpet_setup_irq(struct hpet_dev *dev)
 {
 
 	if (request_irq(dev->irq, hpet_interrupt_handler,
-			IRQF_TIMER | IRQF_DISABLED | IRQF_NOBALANCING,
+			IRQF_TIMER | IRQF_NOBALANCING,
 			dev->name, dev))
 		return -1;
 
diff --git a/arch/x86/kernel/time.c b/arch/x86/kernel/time.c
index 25046df..0c3fc9a 100644
--- a/arch/x86/kernel/time.c
+++ b/arch/x86/kernel/time.c
@@ -55,7 +55,7 @@ EXPORT_SYMBOL(profile_pc);
 static irqreturn_t timer_interrupt(int irq, void *dev_id);
 static struct irqaction irq0  = {
 	.handler = timer_interrupt,
-	.flags = IRQF_DISABLED | IRQF_NOBALANCING | IRQF_IRQPOLL | IRQF_TIMER,
+	.flags = IRQF_NOBALANCING | IRQF_IRQPOLL | IRQF_TIMER,
 	.name = "timer"
 };
 
diff --git a/arch/x86/xen/smp.c b/arch/x86/xen/smp.c
index 041d4fe..a375a75 100644
--- a/arch/x86/xen/smp.c
+++ b/arch/x86/xen/smp.c
@@ -100,7 +100,7 @@ static int xen_smp_intr_init(unsigned int cpu)
 	rc = bind_ipi_to_irqhandler(XEN_RESCHEDULE_VECTOR,
 				    cpu,
 				    xen_reschedule_interrupt,
-				    IRQF_DISABLED|IRQF_PERCPU|IRQF_NOBALANCING,
+				    IRQF_PERCPU|IRQF_NOBALANCING,
 				    resched_name,
 				    NULL);
 	if (rc < 0)
@@ -111,7 +111,7 @@ static int xen_smp_intr_init(unsigned int cpu)
 	rc = bind_ipi_to_irqhandler(XEN_CALL_FUNCTION_VECTOR,
 				    cpu,
 				    xen_call_function_interrupt,
-				    IRQF_DISABLED|IRQF_PERCPU|IRQF_NOBALANCING,
+				    IRQF_PERCPU|IRQF_NOBALANCING,
 				    callfunc_name,
 				    NULL);
 	if (rc < 0)
@@ -120,7 +120,7 @@ static int xen_smp_intr_init(unsigned int cpu)
 
 	debug_name = kasprintf(GFP_KERNEL, "debug%d", cpu);
 	rc = bind_virq_to_irqhandler(VIRQ_DEBUG, cpu, xen_debug_interrupt,
-				     IRQF_DISABLED | IRQF_PERCPU | IRQF_NOBALANCING,
+				     IRQF_PERCPU | IRQF_NOBALANCING,
 				     debug_name, NULL);
 	if (rc < 0)
 		goto fail;
@@ -130,7 +130,7 @@ static int xen_smp_intr_init(unsigned int cpu)
 	rc = bind_ipi_to_irqhandler(XEN_CALL_FUNCTION_SINGLE_VECTOR,
 				    cpu,
 				    xen_call_function_single_interrupt,
-				    IRQF_DISABLED|IRQF_PERCPU|IRQF_NOBALANCING,
+				    IRQF_PERCPU|IRQF_NOBALANCING,
 				    callfunc_name,
 				    NULL);
 	if (rc < 0)
diff --git a/arch/x86/xen/spinlock.c b/arch/x86/xen/spinlock.c
index cc9b1e1..27882f5 100644
--- a/arch/x86/xen/spinlock.c
+++ b/arch/x86/xen/spinlock.c
@@ -354,7 +354,7 @@ void __cpuinit xen_init_lock_cpu(int cpu)
 	irq = bind_ipi_to_irqhandler(XEN_SPIN_UNLOCK_VECTOR,
 				     cpu,
 				     dummy_handler,
-				     IRQF_DISABLED|IRQF_PERCPU|IRQF_NOBALANCING,
+				     IRQF_PERCPU|IRQF_NOBALANCING,
 				     name,
 				     NULL);
 
diff --git a/arch/x86/xen/time.c b/arch/x86/xen/time.c
index 0296a95..9157113 100644
--- a/arch/x86/xen/time.c
+++ b/arch/x86/xen/time.c
@@ -408,9 +408,8 @@ void xen_setup_timer(int cpu)
 		name = "<timer kasprintf failed>";
 
 	irq = bind_virq_to_irqhandler(VIRQ_TIMER, cpu, xen_timer_interrupt,
-				      IRQF_DISABLED|IRQF_PERCPU|
-				      IRQF_NOBALANCING|IRQF_TIMER|
-				      IRQF_FORCE_RESUME,
+				      IRQF_PERCPU|IRQF_NOBALANCING|
+				      IRQF_TIMER|IRQF_FORCE_RESUME,
 				      name, NULL);
 
 	evt = &per_cpu(xen_clock_events, cpu);
-- 
1.7.4.1


  parent reply	other threads:[~2011-09-22  9:02 UTC|newest]

Thread overview: 62+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-22  8:58 [PATCH V2 00/55] Tree wide: cleanup IRQF_DISABLED Yong Zhang
2011-09-22  8:58 ` [PATCH 01/55] usb/hcd: Remove tricky code dealing with IRQF_DISABLED && IRQF_SHARED Yong Zhang
2011-09-22  8:58 ` [PATCH 02/55] alpha: irq: Remove IRQF_DISABLED Yong Zhang
2011-09-22  8:58 ` [PATCH 04/55] avr32: " Yong Zhang
2011-09-22  8:58 ` [PATCH 05/55] cris: " Yong Zhang
2011-09-22  8:58 ` [PATCH 06/55] frv: " Yong Zhang
2011-09-22  8:58 ` [PATCH 07/55] h8300: " Yong Zhang
2011-09-22  8:58 ` [PATCH 08/55] ia64: " Yong Zhang
2011-09-22  8:58 ` [PATCH 09/55] m32r: " Yong Zhang
2011-09-22  8:58 ` [PATCH 10/55] m68k: " Yong Zhang
2011-09-22  8:58 ` [PATCH 11/55] microblaze: " Yong Zhang
2011-09-22  8:58 ` [PATCH 13/55] mn10300: " Yong Zhang
2011-09-22  8:58 ` [PATCH 14/55] parisc: irq: remove IRQF_DISABLED Yong Zhang
2011-09-22  8:58 ` [PATCH 15/55] powerpc: irq: Remove IRQF_DISABLED Yong Zhang
2011-09-22  8:58 ` [PATCH 16/55] score: " Yong Zhang
2011-09-22  8:58 ` [PATCH 17/55] SH: " Yong Zhang
2011-09-22  8:58 ` [PATCH 18/55] sparc: " Yong Zhang
2011-09-22  8:58 ` [PATCH 19/55] um: " Yong Zhang
2011-09-22 10:46   ` Richard Weinberger
2011-09-22  8:58 ` [PATCH 20/55] unicore32: " Yong Zhang
2011-09-22  8:58 ` Yong Zhang [this message]
2011-09-22  8:58 ` [PATCH 22/55] xtensa: irq: " Yong Zhang
2011-09-22  8:58 ` [PATCH 23/55] clocksource: " Yong Zhang
2011-09-22  8:58 ` [PATCH 24/55] SCSI: " Yong Zhang
2011-09-23  1:35   ` Jack Wang
2011-09-22  8:58 ` [PATCH 25/55] ata: " Yong Zhang
2011-09-22  8:58 ` [PATCH 26/55] block: " Yong Zhang
2011-09-22  8:58 ` [PATCH 27/55] cdrom: " Yong Zhang
2011-09-22  8:58 ` [PATCH 28/55] driver/char: " Yong Zhang
2011-09-22  8:58 ` [PATCH 29/55] crypto: " Yong Zhang
2011-09-22  8:58 ` [PATCH 30/55] dmaengine: " Yong Zhang
2011-09-22  8:58 ` [PATCH 31/55] EDAC: " Yong Zhang
2011-09-22  8:58 ` [PATCH 32/55] i2c: " Yong Zhang
2011-09-24 11:53   ` Jean Delvare
2011-10-04 20:59   ` Ben Dooks
2011-09-22  8:59 ` [PATCH 33/55] infiniband: " Yong Zhang
2011-09-22 16:56   ` Roland Dreier
2011-09-23  1:40     ` Yong Zhang
2011-09-23  1:48       ` Yong Zhang
2011-09-23 18:09         ` Roland Dreier
2011-09-22  8:59 ` [PATCH 34/55] ISDN: " Yong Zhang
2011-09-22  8:59 ` [PATCH 36/55] drivers:misc:irq: " Yong Zhang
2011-09-22  8:59 ` [PATCH 37/55] mmc: irq: " Yong Zhang
2011-09-23 18:55   ` Chris Ball
2011-09-22  8:59 ` [PATCH 38/55] mtd: " Yong Zhang
2011-09-22  8:59 ` [PATCH 40/55] dirvers/parisc: " Yong Zhang
2011-09-22  8:59 ` [PATCH 41/55] pcmcia: " Yong Zhang
2011-09-22  8:59 ` [PATCH 42/55] sony-laptop:irq: " Yong Zhang
2011-09-22  8:59 ` [PATCH 43/55] PNP: irq: " Yong Zhang
2011-09-22  8:59 ` [PATCH 44/55] power_supply:irq: " Yong Zhang
2011-11-25 20:35   ` Anton Vorontsov
2011-09-22  8:59 ` [PATCH 45/55] powerpc/ps3: irq: " Yong Zhang
2011-09-22  8:59 ` [PATCH 46/55] rtc: " Yong Zhang
2011-09-22  8:59 ` [PATCH 47/55] spi: " Yong Zhang
2011-09-22  8:59 ` [PATCH 48/55] TTY: " Yong Zhang
2011-09-22  8:59 ` [PATCH 49/55] video: " Yong Zhang
2011-10-04 20:20   ` Florian Tobias Schandinat
2011-09-22  8:59 ` [PATCH 50/55] w1: " Yong Zhang
2011-09-22  8:59 ` [PATCH 51/55] watchdog: " Yong Zhang
2011-09-22  8:59 ` [PATCH 52/55] xen: " Yong Zhang
2011-09-22  8:59 ` [PATCH 54/55] Documentation: irq: Change documents related to IRQF_DISABLED Yong Zhang
2011-09-22  8:59 ` [PATCH 55/55] genirq: Remove IRQF_DISABLED Yong Zhang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1316681962-8217-22-git-send-email-yong.zhang0@gmail.com \
    --to=yong.zhang0@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=hpa@zytor.com \
    --cc=jeremy.fitzhardinge@citrix.com \
    --cc=konrad.wilk@oracle.com \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=paul.gortmaker@windriver.com \
    --cc=ralf@linux-mips.org \
    --cc=tglx@linutronix.de \
    --cc=venki@google.com \
    --cc=virtualization@lists.linux-foundation.org \
    --cc=x86@kernel.org \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®