From: Yong Zhang <yong.zhang0@gmail.com>
To: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org
Cc: tglx@linutronix.de, yong.zhang0@gmail.com,
John Stultz <johnstul@us.ibm.com>
Subject: [PATCH 23/55] clocksource: irq: Remove IRQF_DISABLED
Date: Thu, 22 Sep 2011 16:58:50 +0800 [thread overview]
Message-ID: <1316681962-8217-24-git-send-email-yong.zhang0@gmail.com> (raw)
In-Reply-To: <1316681962-8217-1-git-send-email-yong.zhang0@gmail.com>
Since commit [e58aa3d2: genirq: Run irq handlers with interrupts disabled],
We run all interrupt handlers with interrupts disabled
and we even check and yell when an interrupt handler
returns with interrupts enabled (see commit [b738a50a:
genirq: Warn when handler enables interrupts]).
So now this flag is a NOOP and can be removed.
Signed-off-by: Yong Zhang <yong.zhang0@gmail.com>
---
drivers/clocksource/cs5535-clockevt.c | 2 +-
drivers/clocksource/dw_apb_timer.c | 3 +--
drivers/clocksource/sh_cmt.c | 2 +-
drivers/clocksource/sh_mtu2.c | 2 +-
drivers/clocksource/sh_tmu.c | 2 +-
drivers/clocksource/tcb_clksrc.c | 2 +-
6 files changed, 6 insertions(+), 7 deletions(-)
diff --git a/drivers/clocksource/cs5535-clockevt.c b/drivers/clocksource/cs5535-clockevt.c
index b7dab32..2d3715f 100644
--- a/drivers/clocksource/cs5535-clockevt.c
+++ b/drivers/clocksource/cs5535-clockevt.c
@@ -133,7 +133,7 @@ static irqreturn_t mfgpt_tick(int irq, void *dev_id)
static struct irqaction mfgptirq = {
.handler = mfgpt_tick,
- .flags = IRQF_DISABLED | IRQF_NOBALANCING | IRQF_TIMER,
+ .flags = IRQF_NOBALANCING | IRQF_TIMER,
.name = DRV_NAME,
};
diff --git a/drivers/clocksource/dw_apb_timer.c b/drivers/clocksource/dw_apb_timer.c
index 580f870..55eb8ad 100644
--- a/drivers/clocksource/dw_apb_timer.c
+++ b/drivers/clocksource/dw_apb_timer.c
@@ -243,8 +243,7 @@ dw_apb_clockevent_init(int cpu, const char *name, unsigned rating,
dw_ced->irqaction.dev_id = &dw_ced->ced;
dw_ced->irqaction.irq = irq;
dw_ced->irqaction.flags = IRQF_TIMER | IRQF_IRQPOLL |
- IRQF_NOBALANCING |
- IRQF_DISABLED;
+ IRQF_NOBALANCING;
dw_ced->eoi = apbt_eoi;
err = setup_irq(irq, &dw_ced->irqaction);
diff --git a/drivers/clocksource/sh_cmt.c b/drivers/clocksource/sh_cmt.c
index ca09bc4..3bc55c4 100644
--- a/drivers/clocksource/sh_cmt.c
+++ b/drivers/clocksource/sh_cmt.c
@@ -641,7 +641,7 @@ static int sh_cmt_setup(struct sh_cmt_priv *p, struct platform_device *pdev)
p->irqaction.name = dev_name(&p->pdev->dev);
p->irqaction.handler = sh_cmt_interrupt;
p->irqaction.dev_id = p;
- p->irqaction.flags = IRQF_DISABLED | IRQF_TIMER | \
+ p->irqaction.flags = IRQF_TIMER | \
IRQF_IRQPOLL | IRQF_NOBALANCING;
/* get hold of clock */
diff --git a/drivers/clocksource/sh_mtu2.c b/drivers/clocksource/sh_mtu2.c
index db8d595..0521f03 100644
--- a/drivers/clocksource/sh_mtu2.c
+++ b/drivers/clocksource/sh_mtu2.c
@@ -282,7 +282,7 @@ static int sh_mtu2_setup(struct sh_mtu2_priv *p, struct platform_device *pdev)
p->irqaction.handler = sh_mtu2_interrupt;
p->irqaction.dev_id = p;
p->irqaction.irq = irq;
- p->irqaction.flags = IRQF_DISABLED | IRQF_TIMER | \
+ p->irqaction.flags = IRQF_TIMER | \
IRQF_IRQPOLL | IRQF_NOBALANCING;
/* get hold of clock */
diff --git a/drivers/clocksource/sh_tmu.c b/drivers/clocksource/sh_tmu.c
index 079e96a..306d212 100644
--- a/drivers/clocksource/sh_tmu.c
+++ b/drivers/clocksource/sh_tmu.c
@@ -385,7 +385,7 @@ static int sh_tmu_setup(struct sh_tmu_priv *p, struct platform_device *pdev)
p->irqaction.handler = sh_tmu_interrupt;
p->irqaction.dev_id = p;
p->irqaction.irq = irq;
- p->irqaction.flags = IRQF_DISABLED | IRQF_TIMER | \
+ p->irqaction.flags = IRQF_TIMER | \
IRQF_IRQPOLL | IRQF_NOBALANCING;
/* get hold of clock */
diff --git a/drivers/clocksource/tcb_clksrc.c b/drivers/clocksource/tcb_clksrc.c
index 79c47e8..1963b93 100644
--- a/drivers/clocksource/tcb_clksrc.c
+++ b/drivers/clocksource/tcb_clksrc.c
@@ -175,7 +175,7 @@ static irqreturn_t ch2_irq(int irq, void *handle)
static struct irqaction tc_irqaction = {
.name = "tc_clkevt",
- .flags = IRQF_TIMER | IRQF_DISABLED,
+ .flags = IRQF_TIMER,
.handler = ch2_irq,
};
--
1.7.4.1
next prev parent reply other threads:[~2011-09-22 9:09 UTC|newest]
Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-22 8:58 [PATCH V2 00/55] Tree wide: cleanup IRQF_DISABLED Yong Zhang
2011-09-22 8:58 ` [PATCH 01/55] usb/hcd: Remove tricky code dealing with IRQF_DISABLED && IRQF_SHARED Yong Zhang
2011-09-22 8:58 ` [PATCH 02/55] alpha: irq: Remove IRQF_DISABLED Yong Zhang
2011-09-22 8:58 ` [PATCH 04/55] avr32: " Yong Zhang
2011-09-22 8:58 ` [PATCH 05/55] cris: " Yong Zhang
2011-09-22 8:58 ` [PATCH 06/55] frv: " Yong Zhang
2011-09-22 8:58 ` [PATCH 07/55] h8300: " Yong Zhang
2011-09-22 8:58 ` [PATCH 08/55] ia64: " Yong Zhang
2011-09-22 8:58 ` [PATCH 09/55] m32r: " Yong Zhang
2011-09-22 8:58 ` [PATCH 10/55] m68k: " Yong Zhang
2011-09-22 8:58 ` [PATCH 11/55] microblaze: " Yong Zhang
2011-09-22 8:58 ` [PATCH 13/55] mn10300: " Yong Zhang
2011-09-22 8:58 ` [PATCH 14/55] parisc: irq: remove IRQF_DISABLED Yong Zhang
2011-09-22 8:58 ` [PATCH 15/55] powerpc: irq: Remove IRQF_DISABLED Yong Zhang
2011-09-22 8:58 ` [PATCH 16/55] score: " Yong Zhang
2011-09-22 8:58 ` [PATCH 17/55] SH: " Yong Zhang
2011-09-22 8:58 ` [PATCH 18/55] sparc: " Yong Zhang
2011-09-22 8:58 ` [PATCH 19/55] um: " Yong Zhang
2011-09-22 10:46 ` Richard Weinberger
2011-09-22 8:58 ` [PATCH 20/55] unicore32: " Yong Zhang
2011-09-22 8:58 ` [PATCH 21/55] x86: irq: " Yong Zhang
2011-09-22 8:58 ` [PATCH 22/55] xtensa: " Yong Zhang
2011-09-22 8:58 ` Yong Zhang [this message]
2011-09-22 8:58 ` [PATCH 24/55] SCSI: " Yong Zhang
2011-09-23 1:35 ` Jack Wang
2011-09-22 8:58 ` [PATCH 25/55] ata: " Yong Zhang
2011-09-22 8:58 ` [PATCH 26/55] block: " Yong Zhang
2011-09-22 8:58 ` [PATCH 27/55] cdrom: " Yong Zhang
2011-09-22 8:58 ` [PATCH 28/55] driver/char: " Yong Zhang
2011-09-22 8:58 ` [PATCH 29/55] crypto: " Yong Zhang
2011-09-22 8:58 ` [PATCH 30/55] dmaengine: " Yong Zhang
2011-09-22 8:58 ` [PATCH 31/55] EDAC: " Yong Zhang
2011-09-22 8:58 ` [PATCH 32/55] i2c: " Yong Zhang
2011-09-24 11:53 ` Jean Delvare
2011-10-04 20:59 ` Ben Dooks
2011-09-22 8:59 ` [PATCH 33/55] infiniband: " Yong Zhang
2011-09-22 16:56 ` Roland Dreier
2011-09-23 1:40 ` Yong Zhang
2011-09-23 1:48 ` Yong Zhang
2011-09-23 18:09 ` Roland Dreier
2011-09-22 8:59 ` [PATCH 34/55] ISDN: " Yong Zhang
2011-09-22 8:59 ` [PATCH 36/55] drivers:misc:irq: " Yong Zhang
2011-09-22 8:59 ` [PATCH 37/55] mmc: irq: " Yong Zhang
2011-09-23 18:55 ` Chris Ball
2011-09-22 8:59 ` [PATCH 38/55] mtd: " Yong Zhang
2011-09-22 8:59 ` [PATCH 40/55] dirvers/parisc: " Yong Zhang
2011-09-22 8:59 ` [PATCH 41/55] pcmcia: " Yong Zhang
2011-09-22 8:59 ` [PATCH 42/55] sony-laptop:irq: " Yong Zhang
2011-09-22 8:59 ` [PATCH 43/55] PNP: irq: " Yong Zhang
2011-09-22 8:59 ` [PATCH 44/55] power_supply:irq: " Yong Zhang
2011-11-25 20:35 ` Anton Vorontsov
2011-09-22 8:59 ` [PATCH 45/55] powerpc/ps3: irq: " Yong Zhang
2011-09-22 8:59 ` [PATCH 46/55] rtc: " Yong Zhang
2011-09-22 8:59 ` [PATCH 47/55] spi: " Yong Zhang
2011-09-22 8:59 ` [PATCH 48/55] TTY: " Yong Zhang
2011-09-22 8:59 ` [PATCH 49/55] video: " Yong Zhang
2011-10-04 20:20 ` Florian Tobias Schandinat
2011-09-22 8:59 ` [PATCH 50/55] w1: " Yong Zhang
2011-09-22 8:59 ` [PATCH 51/55] watchdog: " Yong Zhang
2011-09-22 8:59 ` [PATCH 52/55] xen: " Yong Zhang
2011-09-22 8:59 ` [PATCH 54/55] Documentation: irq: Change documents related to IRQF_DISABLED Yong Zhang
2011-09-22 8:59 ` [PATCH 55/55] genirq: Remove IRQF_DISABLED Yong Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1316681962-8217-24-git-send-email-yong.zhang0@gmail.com \
--to=yong.zhang0@gmail.com \
--cc=johnstul@us.ibm.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®