* [PATCH] drm: remove unneeded redefinition of DDC_ADDR
@ 2011-09-23 17:18 Matt Turner
2011-09-23 17:18 ` [PATCH] drm/radeon: use DDC_ADDR instead of hard-coding it Matt Turner
0 siblings, 1 reply; 2+ messages in thread
From: Matt Turner @ 2011-09-23 17:18 UTC (permalink / raw)
To: Dave Airlie; +Cc: dri-devel, linux-kernel, Matt Turner
It's already defined in drm_edid.h.
Signed-off-by: Matt Turner <mattst88@gmail.com>
---
drivers/gpu/drm/drm_edid.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/gpu/drm/drm_edid.c b/drivers/gpu/drm/drm_edid.c
index 7425e5c..9fa8316 100644
--- a/drivers/gpu/drm/drm_edid.c
+++ b/drivers/gpu/drm/drm_edid.c
@@ -225,7 +225,6 @@ bool drm_edid_is_valid(struct edid *edid)
}
EXPORT_SYMBOL(drm_edid_is_valid);
-#define DDC_ADDR 0x50
#define DDC_SEGMENT_ADDR 0x30
/**
* Get EDID information via I2C.
--
1.7.3.4
^ permalink raw reply [flat|nested] 2+ messages in thread
* [PATCH] drm/radeon: use DDC_ADDR instead of hard-coding it
2011-09-23 17:18 [PATCH] drm: remove unneeded redefinition of DDC_ADDR Matt Turner
@ 2011-09-23 17:18 ` Matt Turner
0 siblings, 0 replies; 2+ messages in thread
From: Matt Turner @ 2011-09-23 17:18 UTC (permalink / raw)
To: Dave Airlie; +Cc: dri-devel, linux-kernel, Matt Turner
Signed-off-by: Matt Turner <mattst88@gmail.com>
---
drivers/gpu/drm/radeon/radeon_i2c.c | 5 +++--
1 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/radeon/radeon_i2c.c b/drivers/gpu/drm/radeon/radeon_i2c.c
index 6c111c1..37a6d38 100644
--- a/drivers/gpu/drm/radeon/radeon_i2c.c
+++ b/drivers/gpu/drm/radeon/radeon_i2c.c
@@ -24,6 +24,7 @@
* Alex Deucher
*/
#include "drmP.h"
+#include "drm_edid.h"
#include "radeon_drm.h"
#include "radeon.h"
#include "atom.h"
@@ -39,13 +40,13 @@ bool radeon_ddc_probe(struct radeon_connector *radeon_connector, bool requires_e
int ret;
struct i2c_msg msgs[] = {
{
- .addr = 0x50,
+ .addr = DDC_ADDR,
.flags = 0,
.len = 1,
.buf = &out,
},
{
- .addr = 0x50,
+ .addr = DDC_ADDR,
.flags = I2C_M_RD,
.len = 1,
.buf = buf,
--
1.7.3.4
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-09-23 17:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-09-23 17:18 [PATCH] drm: remove unneeded redefinition of DDC_ADDR Matt Turner
2011-09-23 17:18 ` [PATCH] drm/radeon: use DDC_ADDR instead of hard-coding it Matt Turner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®