From: John Stultz <john.stultz@linaro.org>
To: lkml <linux-kernel@vger.kernel.org>
Cc: John Stultz <john.stultz@linaro.org>,
"Rafael J. Wysocki" <rjw@sisk.pl>,
arve@android.com, markgross@thegnar.org,
Alan Stern <stern@rowland.harvard.edu>,
amit.kucheria@linaro.org, farrowg@sg.ibm.com,
"Dmitry Fink (Palm GBU)" <Dmitry.Fink@palm.com>,
linux-pm@lists.linux-foundation.org, khilman@ti.com,
Magnus Damm <damm@opensource.se>,
mjg@redhat.com, peterz@infradead.org
Subject: [PATCH 5/6] [RFC] alarmtimer: Add pm_stay_awake /pm_relax calls
Date: Mon, 26 Sep 2011 12:13:53 -0700 [thread overview]
Message-ID: <1317064434-1829-6-git-send-email-john.stultz@linaro.org> (raw)
In-Reply-To: <1317064434-1829-1-git-send-email-john.stultz@linaro.org>
This provides wakelock like chaining to protects the
RTC wakeup path to the hrtimer firing of the alarmtimer.
CC: Rafael J. Wysocki <rjw@sisk.pl>
CC: arve@android.com
CC: markgross@thegnar.org
CC: Alan Stern <stern@rowland.harvard.edu>
CC: amit.kucheria@linaro.org
CC: farrowg@sg.ibm.com
CC: Dmitry Fink (Palm GBU) <Dmitry.Fink@palm.com>
CC: linux-pm@lists.linux-foundation.org
CC: khilman@ti.com
CC: Magnus Damm <damm@opensource.se>
CC: mjg@redhat.com
CC: peterz@infradead.org
Signed-off-by: John Stultz <john.stultz@linaro.org>
---
kernel/time/alarmtimer.c | 44 ++++++++++++++++++++++++++++++++++++++++++--
1 files changed, 42 insertions(+), 2 deletions(-)
diff --git a/kernel/time/alarmtimer.c b/kernel/time/alarmtimer.c
index ea5e1a9..00ee80f 100644
--- a/kernel/time/alarmtimer.c
+++ b/kernel/time/alarmtimer.c
@@ -46,12 +46,17 @@ static struct alarm_base {
static ktime_t freezer_delta;
static DEFINE_SPINLOCK(freezer_delta_lock);
+
#ifdef CONFIG_RTC_CLASS
/* rtc timer and device for setting alarm wakeups at suspend */
static struct rtc_timer rtctimer;
static struct rtc_device *rtcdev;
static DEFINE_SPINLOCK(rtcdev_lock);
+static struct wakeup_source *alarmtimer_wakelock;
+static int stay_awake;
+static DEFINE_SPINLOCK(stay_awake_lock);
+
/**
* has_wakealarm - check rtc device has wakealarm ability
* @dev: current device
@@ -73,6 +78,19 @@ static int has_wakealarm(struct device *dev, void *name_ptr)
return 1;
}
+/* rtctimer function called by first rtc interrupt after suspend */
+void alarmtimer_resume_call(void* p)
+{
+ unsigned long flags;
+
+ spin_lock_irqsave(&stay_awake_lock, flags);
+ if (stay_awake == 1) {
+ stay_awake = 2;
+ __pm_stay_awake(alarmtimer_wakelock);
+ }
+ spin_unlock_irqrestore(&stay_awake_lock, flags);
+}
+
/**
* alarmtimer_get_rtcdev - Return selected rtcdevice
*
@@ -99,7 +117,7 @@ static struct rtc_device *alarmtimer_get_rtcdev(void)
* rtc_open takes its own.
*/
put_device(dev);
- rtc_timer_init(&rtctimer, NULL, NULL);
+ rtc_timer_init(&rtctimer, alarmtimer_resume_call, NULL);
}
}
ret = rtcdev;
@@ -158,6 +176,8 @@ static void alarmtimer_remove(struct alarm_base *base, struct alarm *alarm)
}
+
+
/**
* alarmtimer_fired - Handles alarm hrtimer being fired.
* @timer: pointer to hrtimer being run
@@ -175,6 +195,8 @@ static enum hrtimer_restart alarmtimer_fired(struct hrtimer *timer)
ktime_t now;
int ret = HRTIMER_NORESTART;
+
+ __pm_stay_awake(alarmtimer_wakelock);
spin_lock_irqsave(&base->lock, flags);
now = base->gettime();
while ((next = timerqueue_getnext(&base->timerqueue))) {
@@ -206,6 +228,13 @@ static enum hrtimer_restart alarmtimer_fired(struct hrtimer *timer)
}
spin_unlock_irqrestore(&base->lock, flags);
+ spin_lock_irqsave(&stay_awake_lock, flags);
+ if (stay_awake == 2)
+ __pm_relax(alarmtimer_wakelock);
+ stay_awake = 0;
+ spin_unlock_irqrestore(&stay_awake_lock, flags);
+ __pm_relax(alarmtimer_wakelock);
+
return ret;
}
@@ -225,12 +254,14 @@ static int alarmtimer_suspend(struct device *dev)
{
struct rtc_time tm;
ktime_t min, now;
+ int min_base;
unsigned long flags;
struct rtc_device *rtc;
int i;
spin_lock_irqsave(&freezer_delta_lock, flags);
min = freezer_delta;
+ min_base = 0;
freezer_delta = ktime_set(0, 0);
spin_unlock_irqrestore(&freezer_delta_lock, flags);
@@ -251,8 +282,10 @@ static int alarmtimer_suspend(struct device *dev)
if (!next)
continue;
delta = ktime_sub(next->expires, base->gettime());
- if (!min.tv64 || (delta.tv64 < min.tv64))
+ if (!min.tv64 || (delta.tv64 < min.tv64)) {
min = delta;
+ min_base = i;
+ }
}
if (min.tv64 == 0)
return 0;
@@ -266,6 +299,10 @@ static int alarmtimer_suspend(struct device *dev)
now = rtc_tm_to_ktime(tm);
now = ktime_add(now, min);
+ spin_lock_irqsave(&stay_awake_lock, flags);
+ stay_awake=1;
+ spin_unlock_irqrestore(&stay_awake_lock, flags);
+
rtc_timer_start(rtc, &rtctimer, now, ktime_set(0, 0));
return 0;
@@ -703,6 +740,9 @@ static int __init alarmtimer_init(void)
.nsleep = alarm_timer_nsleep,
};
+ alarmtimer_wakelock = wakeup_source_register("alarmtimer");
+ stay_awake=0;
+
posix_timers_register_clock(CLOCK_REALTIME_ALARM, &alarm_clock);
posix_timers_register_clock(CLOCK_BOOTTIME_ALARM, &alarm_clock);
--
1.7.3.2.146.gca209
next prev parent reply other threads:[~2011-09-26 19:17 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-26 19:13 [PATCH 0/6] [RFC] Proposal for optimistic suspend idea John Stultz
2011-09-26 19:13 ` [PATCH 1/6] [RFC] suspend: Block suspend when wakeups are in-progress John Stultz
2011-09-26 19:13 ` [PATCH 2/6] [RFC] sched: Add support for SCHED_STAYAWAKE flag John Stultz
2011-09-26 19:13 ` [PATCH 3/6] [RFC] rtc: rtc-cmos: Add pm_stay_awake/pm_relax calls around IRQ John Stultz
2011-10-01 21:31 ` NeilBrown
2011-09-26 19:13 ` [PATCH 4/6] [RFC] rtc: interface: Add pm_stay_awake/pm_relax chaining rtc workqueue processing John Stultz
2011-09-26 19:13 ` John Stultz [this message]
2011-09-26 19:13 ` [PATCH 6/6] [RFC] alarmtimer: Deboost on nanosleep John Stultz
2011-09-26 20:16 ` [PATCH 0/6] [RFC] Proposal for optimistic suspend idea Peter Zijlstra
2011-09-26 22:27 ` John Stultz
2011-09-27 10:37 ` Peter Zijlstra
2011-09-27 22:56 ` John Stultz
2011-09-28 7:51 ` Peter Zijlstra
2011-09-28 7:57 ` Richard Cochran
2011-09-28 8:02 ` Peter Zijlstra
2011-09-28 8:19 ` Peter Zijlstra
2011-09-29 3:07 ` John Stultz
2011-09-28 8:19 ` Peter Zijlstra
2011-09-29 3:27 ` John Stultz
2011-09-28 8:40 ` Peter Zijlstra
2011-09-28 8:59 ` Peter Zijlstra
2011-09-29 3:45 ` John Stultz
2011-09-28 9:16 ` Peter Zijlstra
2011-09-28 10:45 ` Borislav Petkov
2011-09-28 21:02 ` Rafael J. Wysocki
2011-09-28 0:09 ` Thomas Gleixner
2011-09-28 1:19 ` John Stultz
2011-09-28 8:18 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1317064434-1829-6-git-send-email-john.stultz@linaro.org \
--to=john.stultz@linaro.org \
--cc=Dmitry.Fink@palm.com \
--cc=amit.kucheria@linaro.org \
--cc=arve@android.com \
--cc=damm@opensource.se \
--cc=farrowg@sg.ibm.com \
--cc=khilman@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=markgross@thegnar.org \
--cc=mjg@redhat.com \
--cc=peterz@infradead.org \
--cc=rjw@sisk.pl \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome