* [PATCH v4] mmc : general purpose partition support.
@ 2011-09-30 15:46 Namjae Jeon
2011-09-30 17:34 ` Andrei E. Warkentin
0 siblings, 1 reply; 3+ messages in thread
From: Namjae Jeon @ 2011-09-30 15:46 UTC (permalink / raw)
To: cjb, linux-mmc
Cc: linux-kernel, awarkentin, adrian.hunter, linus.walleij,
james_p_freyensee, sebras, Ulf.Hansson, stefan.xk.nilsson,
per.forlin, johan.rudholm, Namjae Jeon
It allows gerneral purpose partitions in MMC Device.
And I try to simpliy make mmc_blk_alloc_parts using mmc_part structure suggested by Andrei Warkentin.
After patching, we can see general purpose partitions like this.
> cat /proc/partitions
179 0 847872 mmcblk0
179 192 4096 mmcblk0gp3
179 160 4096 mmcblk0gp2
179 128 4096 mmcblk0gp1
179 96 1052672 mmcblk0gp0
179 64 1024 mmcblk0boot1
179 32 1024 mmcblk0boot0
Signed-off-by: Namjae Jeon <linkinjeon@gmail.com>
---
drivers/mmc/card/block.c | 31 +++++++++++++++------------
drivers/mmc/core/mmc.c | 52 ++++++++++++++++++++++++++++++++++++++++++++-
include/linux/mmc/card.h | 32 +++++++++++++++++++++++++++-
include/linux/mmc/mmc.h | 3 --
4 files changed, 98 insertions(+), 20 deletions(-)
diff --git a/drivers/mmc/card/block.c b/drivers/mmc/card/block.c
index 1ff5486..56f7185 100644
--- a/drivers/mmc/card/block.c
+++ b/drivers/mmc/card/block.c
@@ -1377,26 +1377,29 @@ static int mmc_blk_alloc_part(struct mmc_card *card,
return 0;
}
+/* MMC Physical partition consist of two boot partitons and
+ * four general purpose partitions.
+ * if the register of respective partitions is set in ext_csd,
+ * it allocate block device to be accessed.
+ */
+
static int mmc_blk_alloc_parts(struct mmc_card *card, struct mmc_blk_data *md)
{
- int ret = 0;
+ int idx, ret = 0;
if (!mmc_card_mmc(card))
return 0;
- if (card->ext_csd.boot_size) {
- ret = mmc_blk_alloc_part(card, md, EXT_CSD_PART_CONFIG_ACC_BOOT0,
- card->ext_csd.boot_size >> 9,
- true,
- "boot0");
- if (ret)
- return ret;
- ret = mmc_blk_alloc_part(card, md, EXT_CSD_PART_CONFIG_ACC_BOOT1,
- card->ext_csd.boot_size >> 9,
- true,
- "boot1");
- if (ret)
- return ret;
+ for (idx = 0; idx < card->nr_parts; idx++) {
+ if (card->part[idx].size) {
+ ret = mmc_blk_alloc_part(card, md,
+ card->part[idx].cookie,
+ card->part[idx].size >> 9,
+ card->part[idx].force_ro,
+ card->part[idx].name);
+ if (ret)
+ return ret;
+ }
}
return ret;
diff --git a/drivers/mmc/core/mmc.c b/drivers/mmc/core/mmc.c
index 5700b1c..5db4cee 100644
--- a/drivers/mmc/core/mmc.c
+++ b/drivers/mmc/core/mmc.c
@@ -41,6 +41,11 @@ static const unsigned int tacc_mant[] = {
35, 40, 45, 50, 55, 60, 70, 80,
};
+/* partition configuration array */
+static const unsigned int part_cfg[] = {
+ 0x1, 0x2, 0x4, 0x5, 0x6, 7,
+};
+
#define UNSTUFF_BITS(resp,start,size) \
({ \
const int __size = size; \
@@ -239,7 +244,8 @@ static int mmc_get_ext_csd(struct mmc_card *card, u8 **new_ext_csd)
*/
static int mmc_read_ext_csd(struct mmc_card *card, u8 *ext_csd)
{
- int err = 0;
+ int err = 0, idx, part_num;
+ unsigned int part_size, gp_size_mult;
BUG_ON(!card);
@@ -340,7 +346,16 @@ static int mmc_read_ext_csd(struct mmc_card *card, u8 *ext_csd)
* There are two boot regions of equal size, defined in
* multiples of 128K.
*/
- card->ext_csd.boot_size = ext_csd[EXT_CSD_BOOT_MULT] << 17;
+ if (ext_csd[EXT_CSD_BOOT_MULT]) {
+ card->nr_parts = MMC_NUM_BOOT_PARTITION;
+ for (idx = 0, part_num = 0;
+ idx < MMC_NUM_BOOT_PARTITION; idx++,
+ part_num++) {
+ part_size = ext_csd[EXT_CSD_BOOT_MULT] << 17;
+ mmc_part_add(card, part_size, part_cfg[idx],
+ "boot%d", idx, part_num, true);
+ }
+ }
}
card->ext_csd.raw_hc_erase_gap_size =
@@ -392,6 +407,39 @@ static int mmc_read_ext_csd(struct mmc_card *card, u8 *ext_csd)
card->ext_csd.enhanced_area_offset = -EINVAL;
card->ext_csd.enhanced_area_size = -EINVAL;
}
+
+ /*
+ * General purpose partition feature support --
+ * If ext_csd have the size of general purpose partitions,
+ * set size, part_type, partition name in mmc_part.
+ */
+
+ if (ext_csd[EXT_CSD_PARTITION_SUPPORT] & 0x1) {
+ u8 hc_erase_grp_sz =
+ ext_csd[EXT_CSD_HC_ERASE_GRP_SIZE];
+ u8 hc_wp_grp_sz =
+ ext_csd[EXT_CSD_HC_WP_GRP_SIZE];
+
+ card->ext_csd.enhanced_area_en = 1;
+
+ card->nr_parts += MMC_NUM_GP_PARTITION;
+ for (part_num = 0, gp_size_mult = 143;
+ idx < card->nr_parts;
+ idx++, part_num++, gp_size_mult += 3) {
+ if (!ext_csd[gp_size_mult] &&
+ !ext_csd[gp_size_mult + 1] &&
+ !ext_csd[gp_size_mult + 2])
+ continue;
+ part_size = (ext_csd[gp_size_mult + 2] << 16) +
+ (ext_csd[gp_size_mult + 1] << 8) +
+ ext_csd[gp_size_mult];
+ part_size *= (size_t)(hc_erase_grp_sz *
+ hc_wp_grp_sz);
+ part_size <<= 19;
+ mmc_part_add(card, part_size, part_cfg[idx],
+ "gp%d", idx, part_num, false);
+ }
+ }
card->ext_csd.sec_trim_mult =
ext_csd[EXT_CSD_SEC_TRIM_MULT];
card->ext_csd.sec_erase_mult =
diff --git a/include/linux/mmc/card.h b/include/linux/mmc/card.h
index b460fc2..941f2d0 100644
--- a/include/linux/mmc/card.h
+++ b/include/linux/mmc/card.h
@@ -12,6 +12,7 @@
#include <linux/mmc/core.h>
#include <linux/mod_devicetable.h>
+#include <linux/genhd.h>
struct mmc_cid {
unsigned int manfid;
@@ -63,7 +64,6 @@ struct mmc_ext_csd {
bool enhanced_area_en; /* enable bit */
unsigned long long enhanced_area_offset; /* Units: Byte */
unsigned int enhanced_area_size; /* Units: KB */
- unsigned int boot_size; /* in bytes */
u8 raw_partition_support; /* 160 */
u8 raw_erased_mem_count; /* 181 */
u8 raw_ext_csd_structure; /* 194 */
@@ -157,6 +157,22 @@ struct sdio_func_tuple;
#define SDIO_MAX_FUNCS 7
+/* The number of MMC physical partitions
+ * It consist of boot partitions(2), general purpose partitions(4) in MMC v4.4
+ */
+#define MMC_NUM_BOOT_PARTITION 2
+#define MMC_NUM_GP_PARTITION 4
+
+/*
+ * MMC Physical partitions
+ */
+struct mmc_part {
+ unsigned int size; /* partition size (in bytes) */
+ unsigned int cookie; /* it used to part_type */
+ char name[DISK_NAME_LEN];
+ bool force_ro; /* to make boot parts RO by default */
+};
+
/*
* MMC device
*/
@@ -216,9 +232,23 @@ struct mmc_card {
unsigned int sd_bus_speed; /* Bus Speed Mode set for the card */
struct dentry *debugfs_root;
+ struct mmc_part part[MMC_NUM_BOOT_PARTITION + MMC_NUM_GP_PARTITION]; /* mmc physical partitions */
+ unsigned int nr_parts;
};
/*
+ * This function fill contents in mmc_part.
+ */
+static inline void mmc_part_add(struct mmc_card *card, unsigned int size,
+ unsigned int part_cfg, char *name, int idx, int part_num, bool ro)
+{
+ card->part[idx].size = size;
+ card->part[idx].cookie = part_cfg;
+ sprintf(card->part[idx].name, name, part_num);
+ card->part[idx].force_ro = ro;
+}
+
+/*
* The world is not perfect and supplies us with broken mmc/sdio devices.
* For at least some of these bugs we need a work-around.
*/
diff --git a/include/linux/mmc/mmc.h b/include/linux/mmc/mmc.h
index 5a794cb..08f1746 100644
--- a/include/linux/mmc/mmc.h
+++ b/include/linux/mmc/mmc.h
@@ -299,10 +299,7 @@ struct _mmc_csd {
*/
#define EXT_CSD_WR_REL_PARAM_EN (1<<2)
-
#define EXT_CSD_PART_CONFIG_ACC_MASK (0x7)
-#define EXT_CSD_PART_CONFIG_ACC_BOOT0 (0x1)
-#define EXT_CSD_PART_CONFIG_ACC_BOOT1 (0x2)
#define EXT_CSD_CMD_SET_NORMAL (1<<0)
#define EXT_CSD_CMD_SET_SECURE (1<<1)
--
1.7.4.4
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v4] mmc : general purpose partition support.
2011-09-30 15:46 [PATCH v4] mmc : general purpose partition support Namjae Jeon
@ 2011-09-30 17:34 ` Andrei E. Warkentin
2011-09-30 23:27 ` NamJae Jeon
0 siblings, 1 reply; 3+ messages in thread
From: Andrei E. Warkentin @ 2011-09-30 17:34 UTC (permalink / raw)
To: Namjae Jeon
Cc: cjb, linux-mmc, linux-kernel, awarkentin, adrian.hunter,
linus.walleij, james_p_freyensee, sebras, Ulf.Hansson,
stefan.xk.nilsson, per.forlin, johan.rudholm
Hi Namjae,
Why don't you update card->nr_parts inside mmc_part_add? You're making
this too complicated. There
is also no need for the part_cfg array.
2011/9/30 Namjae Jeon <linkinjeon@gmail.com>:
> It allows gerneral purpose partitions in MMC Device.
> And I try to simpliy make mmc_blk_alloc_parts using mmc_part structure suggested by Andrei Warkentin.
> After patching, we can see general purpose partitions like this.
>> cat /proc/partitions
> 179 0 847872 mmcblk0
> 179 192 4096 mmcblk0gp3
> 179 160 4096 mmcblk0gp2
> 179 128 4096 mmcblk0gp1
> 179 96 1052672 mmcblk0gp0
> 179 64 1024 mmcblk0boot1
> 179 32 1024 mmcblk0boot0
>
> Signed-off-by: Namjae Jeon <linkinjeon@gmail.com>
> ---
>
> +/* partition configuration array */
> +static const unsigned int part_cfg[] = {
> + 0x1, 0x2, 0x4, 0x5, 0x6, 7,
> +};
> +
No need. Plus this is obscure.
> - card->ext_csd.boot_size = ext_csd[EXT_CSD_BOOT_MULT] << 17;
> + if (ext_csd[EXT_CSD_BOOT_MULT]) {
> + card->nr_parts = MMC_NUM_BOOT_PARTITION;
> + for (idx = 0, part_num = 0;
> + idx < MMC_NUM_BOOT_PARTITION; idx++,
> + part_num++) {
> + part_size = ext_csd[EXT_CSD_BOOT_MULT] << 17;
> + mmc_part_add(card, part_size, part_cfg[idx],
> + "boot%d", idx, part_num, true);
> + }
> + }
> }
There is no need for part_num (you have idx for that). And there is no
need for passing the actual array
index either - that's why you have mmc_part_add: it will do
card->parts[card->nr_parts++] = new_part.
if (ext_csd[EXT_CSD_BOOT_MULT]) {
for (idx = 0, part_num = 0;
idx < MMC_NUM_BOOT_PARTITION; idx++) {
part_size = ext_csd[EXT_CSD_BOOT_MULT] << 17;
mmc_part_add(card, part_size,
EXT_CSD_PART_CONFIG_ACC_BOOT0 + idx,
"boot%d", idx, true);
}
}
> + if (ext_csd[EXT_CSD_PARTITION_SUPPORT] & 0x1) {
> + u8 hc_erase_grp_sz =
> + ext_csd[EXT_CSD_HC_ERASE_GRP_SIZE];
> + u8 hc_wp_grp_sz =
> + ext_csd[EXT_CSD_HC_WP_GRP_SIZE];
> +
> + card->ext_csd.enhanced_area_en = 1;
> +
> + card->nr_parts += MMC_NUM_GP_PARTITION;
> + for (part_num = 0, gp_size_mult = 143;
> + idx < card->nr_parts;
> + idx++, part_num++, gp_size_mult += 3) {
> + if (!ext_csd[gp_size_mult] &&
> + !ext_csd[gp_size_mult + 1] &&
> + !ext_csd[gp_size_mult + 2])
> + continue;
> + part_size = (ext_csd[gp_size_mult + 2] << 16) +
> + (ext_csd[gp_size_mult + 1] << 8) +
> + ext_csd[gp_size_mult];
> + part_size *= (size_t)(hc_erase_grp_sz *
> + hc_wp_grp_sz);
> + part_size <<= 19;
> + mmc_part_add(card, part_size, part_cfg[idx],
> + "gp%d", idx, part_num, false);
> + }
> + }
Same story: get rid of part_num, don't touch card->nr_parts, and get
rid of part_cfg array access.
card->ext_csd.enhanced_area_en = 1;
for (idx = 0, gp_size_mult = 143;
idx < MMC_NUM_GP_PARTITION;
idx++, gp_size_mult += 3) {
if (!ext_csd[gp_size_mult] &&
!ext_csd[gp_size_mult + 1] &&
!ext_csd[gp_size_mult + 2])
continue;
part_size = (ext_csd[gp_size_mult + 2] << 16) +
(ext_csd[gp_size_mult + 1] << 8) +
ext_csd[gp_size_mult];
part_size *= (size_t)(hc_erase_grp_sz *
hc_wp_grp_sz);
part_size <<= 19;
mmc_part_add(card, part_size, idx +
EXT_CSD_PART_CONFIG_ACC_GP0,
"gp%d", idx, false);
}
}
> /*
> + * This function fill contents in mmc_part.
> + */
> +static inline void mmc_part_add(struct mmc_card *card, unsigned int size,
> + unsigned int part_cfg, char *name, int idx, int part_num, bool ro)
> +{
> + card->part[idx].size = size;
> + card->part[idx].cookie = part_cfg;
> + sprintf(card->part[idx].name, name, part_num);
> + card->part[idx].force_ro = ro;
> +}
static inline void mmc_part_add(struct mmc_card *card, unsigned int size,
unsigned int part_cfg, char *name, int idx, bool ro)
{
card->part[card->nr_parts].size = size;
card->part[card->nr_parts].cookie = part_cfg;
sprintf(card->part[card->nr_parts].name, name, idx);
card->part[card->nr_parts].force_ro = ro;
card->nr_parts++;
}
> #define EXT_CSD_PART_CONFIG_ACC_MASK (0x7)
> -#define EXT_CSD_PART_CONFIG_ACC_BOOT0 (0x1)
> -#define EXT_CSD_PART_CONFIG_ACC_BOOT1 (0x2)
>
I'd also keep the MMC_NUM_BOOT_PARTITION and MMC_NUM_GP_PARTITION defs
at the same location.
/* The number of MMC physical partitions
* It consist of boot partitions(2), general purpose partitions(4) in MMC v4.4
*/
#define MMC_NUM_BOOT_PARTITION 2
#define MMC_NUM_GP_PARTITION 4
#define EXT_CSD_PART_CONFIG_ACC_BOOT0 (0x1)
#define EXT_CSD_PART_CONFIG_ACC_GP0 (0x4)
A
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v4] mmc : general purpose partition support.
2011-09-30 17:34 ` Andrei E. Warkentin
@ 2011-09-30 23:27 ` NamJae Jeon
0 siblings, 0 replies; 3+ messages in thread
From: NamJae Jeon @ 2011-09-30 23:27 UTC (permalink / raw)
To: Andrei E. Warkentin
Cc: cjb, linux-mmc, linux-kernel, awarkentin, adrian.hunter,
linus.walleij, james_p_freyensee, sebras, Ulf.Hansson,
stefan.xk.nilsson, per.forlin, johan.rudholm
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=UTF-8, Size: 7665 bytes --]
2011/10/1 Andrei E. Warkentin <andrey.warkentin@gmail.com>:
> Hi Namjae,
>
> Why don't you update card->nr_parts inside mmc_part_add? You're making
> this too complicated. There
> is also no need for the part_cfg array.
>
> 2011/9/30 Namjae Jeon <linkinjeon@gmail.com>:
>> It allows gerneral purpose partitions in MMC Device.
>> And I try to simpliy make mmc_blk_alloc_parts using mmc_part structure suggested by Andrei Warkentin.
>> After patching, we can see general purpose partitions like this.
>>> cat /proc/partitions
>> Â Â Â Â Â 179 0 847872 mmcblk0
>> Â Â Â Â Â 179 192 4096 mmcblk0gp3
>> Â Â Â Â Â 179 160 4096 mmcblk0gp2
>> Â Â Â Â Â 179 128 4096 mmcblk0gp1
>> Â Â Â Â Â 179 96 Â 1052672 mmcblk0gp0
>> Â Â Â Â Â 179 64 Â 1024 mmcblk0boot1
>> Â Â Â Â Â 179 32 Â 1024 mmcblk0boot0
>>
>> Signed-off-by: Namjae Jeon <linkinjeon@gmail.com>
>> ---
>
>>
>> +/* partition configuration array */
>> +static const unsigned int part_cfg[] = {
>> + Â Â Â 0x1, Â Â 0x2, Â Â 0x4, Â Â 0x5, Â Â 0x6, Â Â 7,
>> +};
>> +
>
> No need. Plus this is obscure.
>
>> - Â Â Â Â Â Â Â card->ext_csd.boot_size = ext_csd[EXT_CSD_BOOT_MULT] << 17;
>> + Â Â Â Â Â Â Â if (ext_csd[EXT_CSD_BOOT_MULT]) {
>> + Â Â Â Â Â Â Â Â Â Â Â card->nr_parts = MMC_NUM_BOOT_PARTITION;
>> + Â Â Â Â Â Â Â Â Â Â Â for (idx = 0, part_num = 0;
>> + Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â idx < MMC_NUM_BOOT_PARTITION; idx++,
>> + Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â part_num++) {
>> + Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â part_size = ext_csd[EXT_CSD_BOOT_MULT] << 17;
>> + Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â mmc_part_add(card, part_size, part_cfg[idx],
>> + Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â "boot%d", idx, part_num, true);
>> + Â Â Â Â Â Â Â Â Â Â Â }
>> + Â Â Â Â Â Â Â }
>> Â Â Â Â }
>
> There is no need for part_num (you have idx for that). And there is no
> need for passing the actual array
> index either - that's why you have mmc_part_add: it will do
> card->parts[card->nr_parts++] = new_part.
>
> Â Â Â Â Â Â Â if (ext_csd[EXT_CSD_BOOT_MULT]) {
> Â Â Â Â Â Â Â Â Â Â Â for (idx = 0, part_num = 0;
> Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â idx < MMC_NUM_BOOT_PARTITION; idx++) {
> Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â part_size = ext_csd[EXT_CSD_BOOT_MULT] << 17;
> Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â mmc_part_add(card, part_size,
> EXT_CSD_PART_CONFIG_ACC_BOOT0 + idx,
> Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â "boot%d", idx, true);
> Â Â Â Â Â Â Â Â Â Â Â }
> Â Â Â Â Â Â Â }
>
>
>> + Â Â Â Â Â Â Â if (ext_csd[EXT_CSD_PARTITION_SUPPORT] & 0x1) {
>> + Â Â Â Â Â Â Â Â Â Â Â u8 hc_erase_grp_sz =
>> + Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â ext_csd[EXT_CSD_HC_ERASE_GRP_SIZE];
>> + Â Â Â Â Â Â Â Â Â Â Â u8 hc_wp_grp_sz =
>> + Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â ext_csd[EXT_CSD_HC_WP_GRP_SIZE];
>> +
>> + Â Â Â Â Â Â Â Â Â Â Â card->ext_csd.enhanced_area_en = 1;
>> +
>> + Â Â Â Â Â Â Â Â Â Â Â card->nr_parts += MMC_NUM_GP_PARTITION;
>> + Â Â Â Â Â Â Â Â Â Â Â for (part_num = 0, gp_size_mult = 143;
>> + Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â idx < card->nr_parts;
>> + Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â idx++, part_num++, gp_size_mult += 3) {
>> + Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â if (!ext_csd[gp_size_mult] &&
>> + Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â !ext_csd[gp_size_mult + 1] &&
>> + Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â !ext_csd[gp_size_mult + 2])
>> + Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â continue;
>> + Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â part_size = (ext_csd[gp_size_mult + 2] << 16) +
>> + Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â (ext_csd[gp_size_mult + 1] << 8) +
>> + Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â ext_csd[gp_size_mult];
>> + Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â part_size *= (size_t)(hc_erase_grp_sz *
>> + Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â hc_wp_grp_sz);
>> + Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â part_size <<= 19;
>> + Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â mmc_part_add(card, part_size, part_cfg[idx],
>> + Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â "gp%d", idx, part_num, false);
>> + Â Â Â Â Â Â Â Â Â Â Â }
>> + Â Â Â Â Â Â Â }
>
> Same story: get rid of part_num, don't touch card->nr_parts, and get
> rid of part_cfg array access.
>
> Â Â Â Â Â Â Â Â Â Â Â card->ext_csd.enhanced_area_en = 1;
> Â Â Â Â Â Â Â Â Â Â Â for (idx = 0, gp_size_mult = 143;
> Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â idx < MMC_NUM_GP_PARTITION;
> Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â idx++, gp_size_mult += 3) {
> Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â if (!ext_csd[gp_size_mult] &&
> Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â !ext_csd[gp_size_mult + 1] &&
> Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â !ext_csd[gp_size_mult + 2])
> Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â continue;
> Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â part_size = (ext_csd[gp_size_mult + 2] << 16) +
> Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â (ext_csd[gp_size_mult + 1] << 8) +
> Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â ext_csd[gp_size_mult];
> Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â part_size *= (size_t)(hc_erase_grp_sz *
> Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â hc_wp_grp_sz);
> Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â part_size <<= 19;
> Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â mmc_part_add(card, part_size, idx +
> EXT_CSD_PART_CONFIG_ACC_GP0,
> Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â "gp%d", idx, false);
> Â Â Â Â Â Â Â Â Â Â Â }
> Â Â Â Â Â Â Â }
>
>
>> Â /*
>> + * This function fill contents in mmc_part.
>> + */
>> +static inline void mmc_part_add(struct mmc_card *card, unsigned int size,
>> + Â Â Â unsigned int part_cfg, char *name, int idx, int part_num, bool ro)
>> +{
>> + Â Â Â card->part[idx].size = size;
>> + Â Â Â card->part[idx].cookie = part_cfg;
>> + Â Â Â sprintf(card->part[idx].name, name, part_num);
>> + Â Â Â card->part[idx].force_ro = ro;
>> +}
>
> static inline void mmc_part_add(struct mmc_card *card, unsigned int size,
> Â Â Â unsigned int part_cfg, char *name, int idx, bool ro)
> {
> Â Â Â card->part[card->nr_parts].size = size;
> Â Â Â card->part[card->nr_parts].cookie = part_cfg;
> Â Â Â sprintf(card->part[card->nr_parts].name, name, idx);
> Â Â Â card->part[card->nr_parts].force_ro = ro;
> Â Â Â card->nr_parts++;
> }
>
>> Â #define EXT_CSD_PART_CONFIG_ACC_MASK Â (0x7)
>> -#define EXT_CSD_PART_CONFIG_ACC_BOOT0 Â (0x1)
>> -#define EXT_CSD_PART_CONFIG_ACC_BOOT1 Â (0x2)
>>
>
> I'd also keep the MMC_NUM_BOOT_PARTITION and MMC_NUM_GP_PARTITION defs
> at the same location.
Why should this def move to mmc.h ?
this area where there are ext csd fields.
>
> /* The number of MMC physical partitions
> Â * It consist of boot partitions(2), general purpose partitions(4) in MMC v4.4
> Â */
> #define MMC_NUM_BOOT_PARTITION 2
> #define MMC_NUM_GP_PARTITION Â 4
>
> #define EXT_CSD_PART_CONFIG_ACC_BOOT0 Â (0x1)
> #define EXT_CSD_PART_CONFIG_ACC_GP0 Â Â Â (0x4)
>
> A
>
ÿôèº{.nÇ+‰·Ÿ®‰†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dʇڙë,j\a¢f£¢·hšïêÿ‘êçz_è®\x03(階ŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨èÚ&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-09-30 23:27 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-09-30 15:46 [PATCH v4] mmc : general purpose partition support Namjae Jeon
2011-09-30 17:34 ` Andrei E. Warkentin
2011-09-30 23:27 ` NamJae Jeon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®