From: Himanshu Chauhan <hschauhan@nulltrace.org>
To: linux-kernel@vger.kernel.org
Cc: kernelnewbies@kernelnewbies.org,
Himanshu Chauhan <hschauhan@nulltrace.org>
Subject: [PATCH] hwmon class driver registration with a device number
Date: Wed, 5 Oct 2011 22:43:11 +0530 [thread overview]
Message-ID: <1317834791-2803-1-git-send-email-hschauhan@nulltrace.org> (raw)
This patch adds a way to register a hwmon class driver
with a device number rather than the default MK_DEV(0,0).
This would help in creating required "dev" file under
sysfs which in turn can be used in populating /dev tree
during bootup (helpful to driver which want to show up
a char interface along with sysfs).
Signed-off-by: Himanshu Chauhan <hschauhan@nulltrace.org>
---
drivers/hwmon/hwmon.c | 28 ++++++++++++++++++++++------
include/linux/hwmon.h | 1 +
2 files changed, 23 insertions(+), 6 deletions(-)
diff --git a/drivers/hwmon/hwmon.c b/drivers/hwmon/hwmon.c
index a61e781..36961c5 100644
--- a/drivers/hwmon/hwmon.c
+++ b/drivers/hwmon/hwmon.c
@@ -31,15 +31,17 @@ static DEFINE_IDR(hwmon_idr);
static DEFINE_SPINLOCK(idr_lock);
/**
- * hwmon_device_register - register w/ hwmon
- * @dev: the device to register
+ * hwmon_device_register_numbered - register hwmon class dev
+ * with specific device number.
+ * @dev: Device to register.
+ * @dev_id: device number to register.
*
- * hwmon_device_unregister() must be called when the device is no
- * longer needed.
+ * hwmon_device_unregister() must be called when the device
+ * is no longer needed.
*
* Returns the pointer to the new device.
*/
-struct device *hwmon_device_register(struct device *dev)
+struct device* hwmon_device_register_numbered(struct device *dev, dev_t dev_id)
{
struct device *hwdev;
int id, err;
@@ -58,7 +60,7 @@ again:
return ERR_PTR(err);
id = id & MAX_ID_MASK;
- hwdev = device_create(hwmon_class, dev, MKDEV(0, 0), NULL,
+ hwdev = device_create(hwmon_class, dev, dev_id, NULL,
HWMON_ID_FORMAT, id);
if (IS_ERR(hwdev)) {
@@ -71,6 +73,20 @@ again:
}
/**
+ * hwmon_device_register - register w/ hwmon
+ * @dev: the device to register
+ *
+ * hwmon_device_unregister() must be called when the device is no
+ * longer needed.
+ *
+ * Returns the pointer to the new device.
+ */
+struct device *hwmon_device_register(struct device *dev)
+{
+ return hwmon_device_register_numbered(dev, MK_DEV(0,0));
+}
+
+/**
* hwmon_device_unregister - removes the previously registered class device
*
* @dev: the class device to destroy
diff --git a/include/linux/hwmon.h b/include/linux/hwmon.h
index 6b6ee70..d816cbe 100644
--- a/include/linux/hwmon.h
+++ b/include/linux/hwmon.h
@@ -16,6 +16,7 @@
#include <linux/device.h>
+struct device *hwmon_device_register_numbered(struct device *dev, dev_t dev_id);
struct device *hwmon_device_register(struct device *dev);
void hwmon_device_unregister(struct device *dev);
--
1.7.4.1
next reply other threads:[~2011-10-05 17:13 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-05 17:13 Himanshu Chauhan [this message]
2011-10-05 18:30 ` Guenter Roeck
2011-10-06 4:06 ` Himanshu Chauhan
2011-10-06 5:19 ` Guenter Roeck
2011-10-06 7:43 ` [lm-sensors] " Jean Delvare
2011-10-06 15:12 ` Himanshu Chauhan
2011-10-06 15:46 ` Alan Cox
2011-10-06 16:25 ` Himanshu Chauhan
2011-10-06 15:15 ` Guenter Roeck
2011-10-06 16:43 ` Himanshu Chauhan
2011-10-05 19:33 ` Greg KH
2011-10-06 4:10 ` Himanshu Chauhan
2011-10-06 18:25 ` Greg KH
2011-10-06 19:07 ` [lm-sensors] " Guenter Roeck
2011-10-07 6:42 ` Himanshu Chauhan
2011-10-07 6:52 ` Greg KH
2011-10-07 9:56 ` Himanshu Chauhan
2011-10-07 11:11 ` Jonathan Cameron
2011-10-07 15:46 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1317834791-2803-1-git-send-email-hschauhan@nulltrace.org \
--to=hschauhan@nulltrace.org \
--cc=kernelnewbies@kernelnewbies.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome