From: Himanshu Chauhan <hschauhan@nulltrace.org>
To: Guenter Roeck <guenter.roeck@ericsson.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"kernelnewbies@kernelnewbies.org"
<kernelnewbies@kernelnewbies.org>,
lm-sensors@lm-sensors.org
Subject: Re: [PATCH] hwmon class driver registration with a device number
Date: Thu, 6 Oct 2011 09:36:59 +0530 [thread overview]
Message-ID: <20111006040656.GA2125@ubuntu.ubuntu-domain> (raw)
In-Reply-To: <1317839407.3983.46.camel@groeck-laptop>
Hi,
> I can not comment on the merits of your patch. Unless I am missing
> something, which may well be since I only spent a couple of minutes on
> it, other device classes don't seem to provide a similar API, so I don't
> know if or why it would make sense for hwmon. Maybe a driver which wants
> to register a character device interface should do so independently of
> hwmon.
>
The idea here is to sit in the same class directory as of hwmon. Devices
registered with this interface will have "dev" under, for example,
/sys/class/hwmon/hwmon0/dev. To do the same inside the driver will be
a bit more involved than a call.
In my opinion other classes should also have similar interfaces.
> On the technical side, EXPORT_SYMBOL is missing.
>
I will take care of that.
Regards
Himanshu
next prev parent reply other threads:[~2011-10-06 4:07 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-05 17:13 Himanshu Chauhan
2011-10-05 18:30 ` Guenter Roeck
2011-10-06 4:06 ` Himanshu Chauhan [this message]
2011-10-06 5:19 ` Guenter Roeck
2011-10-06 7:43 ` [lm-sensors] " Jean Delvare
2011-10-06 15:12 ` Himanshu Chauhan
2011-10-06 15:46 ` Alan Cox
2011-10-06 16:25 ` Himanshu Chauhan
2011-10-06 15:15 ` Guenter Roeck
2011-10-06 16:43 ` Himanshu Chauhan
2011-10-05 19:33 ` Greg KH
2011-10-06 4:10 ` Himanshu Chauhan
2011-10-06 18:25 ` Greg KH
2011-10-06 19:07 ` [lm-sensors] " Guenter Roeck
2011-10-07 6:42 ` Himanshu Chauhan
2011-10-07 6:52 ` Greg KH
2011-10-07 9:56 ` Himanshu Chauhan
2011-10-07 11:11 ` Jonathan Cameron
2011-10-07 15:46 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111006040656.GA2125@ubuntu.ubuntu-domain \
--to=hschauhan@nulltrace.org \
--cc=guenter.roeck@ericsson.com \
--cc=kernelnewbies@kernelnewbies.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lm-sensors@lm-sensors.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome