From: Tomoya MORINAGA <tomoya-linux@dsn.lapis-semi.com>
To: Jean Delvare <khali@linux-fr.org>,
Ben Dooks <ben-linux@fluff.org>,
Wolfram Sang <w.sang@pengutronix.de>, Qi Wang <qi.wang@intel.com>,
Linus Walleij <linus.walleij@stericsson.com>,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: yong.y.wang@intel.com, joel.clark@intel.com,
kok.howg.ewe@intel.com,
Tomoya MORINAGA <tomoya-linux@dsn.lapis-semi.com>
Subject: [PATCH 2/7 v3] i2c-eg20t: Modify returned value s32 to long
Date: Thu, 6 Oct 2011 15:56:26 +0900 [thread overview]
Message-ID: <1317884192-10694-2-git-send-email-tomoya-linux@dsn.lapis-semi.com> (raw)
In-Reply-To: <1317884192-10694-1-git-send-email-tomoya-linux@dsn.lapis-semi.com>
Type of wait_event_timeout is long not s32.
This patch replaces s32 with long.
Additionally, delete negative processing(ret < 0).
Signed-off-by: Tomoya MORINAGA <tomoya-linux@dsn.lapis-semi.com>
---
drivers/i2c/busses/i2c-eg20t.c | 6 +-----
1 files changed, 1 insertions(+), 5 deletions(-)
diff --git a/drivers/i2c/busses/i2c-eg20t.c b/drivers/i2c/busses/i2c-eg20t.c
index 35d819a..c5b9924 100644
--- a/drivers/i2c/busses/i2c-eg20t.c
+++ b/drivers/i2c/busses/i2c-eg20t.c
@@ -313,13 +313,9 @@ static void pch_i2c_start(struct i2c_algo_pch_data *adap)
*/
static s32 pch_i2c_wait_for_xfer_complete(struct i2c_algo_pch_data *adap)
{
- s32 ret;
+ long ret;
ret = wait_event_timeout(pch_event,
(adap->pch_event_flag != 0), msecs_to_jiffies(50));
- if (ret < 0) {
- pch_err(adap, "timeout: %x\n", adap->pch_event_flag);
- return ret;
- }
if (ret == 0) {
pch_err(adap, "timeout: %x\n", adap->pch_event_flag);
--
1.7.4.4
next prev parent reply other threads:[~2011-10-06 6:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-06 6:56 [PATCH 1/7 v3] i2c-eg20t: Fix bus-idle waiting issue Tomoya MORINAGA
2011-10-06 6:56 ` Tomoya MORINAGA [this message]
2011-10-06 6:56 ` [PATCH 3/7 v1] i2c-eg20t: Fix 10bit access issue Tomoya MORINAGA
2011-10-06 6:56 ` [PATCH 3/7 v3] i2c-eg20t: delete 10bit access processing Tomoya MORINAGA
2011-10-06 7:00 ` Tomoya MORINAGA
2011-10-06 6:56 ` [PATCH 4/7 v3] i2c-eg20t: Separate error processing Tomoya MORINAGA
2011-10-06 6:56 ` [PATCH 5/7 v3] i2c-eg20t: add stop sequence in case wait-event timeout occurs Tomoya MORINAGA
2011-10-06 6:56 ` [PATCH 6/7 v3] i2c-eg20t: Fix flag setting issue Tomoya MORINAGA
2011-10-06 6:56 ` [PATCH 7/7 v3] i2c-eg20t: Add initialize processing in case i2c-error occurs Tomoya MORINAGA
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1317884192-10694-2-git-send-email-tomoya-linux@dsn.lapis-semi.com \
--to=tomoya-linux@dsn.lapis-semi.com \
--cc=ben-linux@fluff.org \
--cc=joel.clark@intel.com \
--cc=khali@linux-fr.org \
--cc=kok.howg.ewe@intel.com \
--cc=linus.walleij@stericsson.com \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=qi.wang@intel.com \
--cc=w.sang@pengutronix.de \
--cc=yong.y.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®