From: Bojan Smojver <bojan@rexursive.com>
To: penberg@cs.helsinki.fi
Cc: rjw@sisk.pl, linux-kernel@vger.kernel.org,
linux-pm@lists.linux-foundation.org
Subject: Re: [PATCH v8]: Improve performance of LZO/plain hibernation
Date: Mon, 10 Oct 2011 09:24:14 +1100 [thread overview]
Message-ID: <1318199054.2004.1.camel@shrek.rexursive.com> (raw)
In-Reply-To: <6127211897.1002662375@rexursive.com>
On Sun, 2011-10-09 at 21:19 +1100, Bojan Smojver wrote:
> May be related, when I simulate image loading failure by returning
> error from load_image(), I get bad page state error, count -1, so
> something is amiss. Probably the readahead buffers or maps.
Yeah, this will probably be an easy fix. I think I've forgotten that
handle->cur is no longer being allocated as a standalone page on image
load (instead, it's a pointer into maps). So, when we fail, handle->cur
is freed twice, because it's not NULL. Will test the fix shortly.
--
Bojan
next prev parent reply other threads:[~2011-10-09 22:24 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-30 0:27 Bojan Smojver
2011-10-04 22:07 ` Rafael J. Wysocki
2011-10-05 1:07 ` Bojan Smojver
2011-10-06 18:37 ` Rafael J. Wysocki
2011-10-06 18:45 ` Rafael J. Wysocki
2011-10-06 22:23 ` Bojan Smojver
2011-10-07 3:20 ` Bojan Smojver
2011-10-07 3:39 ` Bojan Smojver
2011-10-07 23:33 ` Bojan Smojver
2011-10-09 2:57 ` Bojan Smojver
2011-10-09 7:54 ` Bojan Smojver
2011-10-09 9:22 ` Pekka Enberg
2011-10-09 10:19 ` Bojan Smojver
2011-10-09 22:24 ` Bojan Smojver [this message]
2011-10-10 7:12 ` Bojan Smojver
2011-10-13 11:00 ` Bojan Smojver
2011-10-13 21:26 ` Rafael J. Wysocki
2011-10-13 21:44 ` Bojan Smojver
2011-10-13 21:57 ` Rafael J. Wysocki
2011-10-13 21:56 ` Bojan Smojver
2011-10-14 2:01 ` Bojan Smojver
2011-10-14 6:14 ` Pekka Enberg
2011-10-14 6:50 ` Bojan Smojver
2011-10-15 6:28 ` Bojan Smojver
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1318199054.2004.1.camel@shrek.rexursive.com \
--to=bojan@rexursive.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=penberg@cs.helsinki.fi \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome