From: Don Zickus <dzickus@redhat.com>
To: Ingo Molnar <mingo@elte.hu>, Andi Kleen <andi@firstfloor.org>,
<x86@kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Robert Richter <robert.richter@amd.com>,
Andrew Morton <akpm@linux-foundation.org>,
seiji.aguchi@hds.com, vgoyal@redhat.com, mjg@redhat.com,
tony.luck@intel.com, gong.chen@intel.com, satoru.moriya@hds.com,
avi@redhat.com, Don Zickus <dzickus@redhat.com>
Subject: [v2 PATCH 3/3] x86, NMI: knob to disable using NMI IPIs to stop cpus
Date: Thu, 13 Oct 2011 15:14:27 -0400 [thread overview]
Message-ID: <1318533267-18880-4-git-send-email-dzickus@redhat.com> (raw)
In-Reply-To: <1318533267-18880-1-git-send-email-dzickus@redhat.com>
Some machines may exhibit problems using the NMI to stop other cpus.
This knob just allows one to revert back to the original behaviour to help
diagnose the problem.
V2:
make function static
Signed-off-by: Don Zickus <dzickus@redhat.com>
---
Documentation/kernel-parameters.txt | 4 ++++
arch/x86/kernel/smp.c | 13 +++++++++++++
2 files changed, 17 insertions(+), 0 deletions(-)
diff --git a/Documentation/kernel-parameters.txt b/Documentation/kernel-parameters.txt
index 6ca1f5c..dab6439 100644
--- a/Documentation/kernel-parameters.txt
+++ b/Documentation/kernel-parameters.txt
@@ -1761,6 +1761,10 @@ bytes respectively. Such letter suffixes can also be entirely omitted.
nomfgpt [X86-32] Disable Multi-Function General Purpose
Timer usage (for AMD Geode machines).
+ nonmi_ipi [X86] Disable using NMI IPIs during panic/reboot to
+ shutdown the other cpus. Instead use the REBOOT_VECTOR
+ irq.
+
nopat [X86] Disable PAT (page attribute table extension of
pagetables) support.
diff --git a/arch/x86/kernel/smp.c b/arch/x86/kernel/smp.c
index 991d184..f96d32d 100644
--- a/arch/x86/kernel/smp.c
+++ b/arch/x86/kernel/smp.c
@@ -248,6 +248,11 @@ static void native_irq_stop_other_cpus(int wait)
local_irq_restore(flags);
}
+static void native_smp_disable_nmi_ipi(void)
+{
+ smp_ops.stop_other_cpus = native_irq_stop_other_cpus;
+}
+
/*
* Reschedule call back.
*/
@@ -279,6 +284,14 @@ void smp_call_function_single_interrupt(struct pt_regs *regs)
irq_exit();
}
+static int __init nonmi_ipi_setup(char *str)
+{
+ native_smp_disable_nmi_ipi();
+ return 1;
+}
+
+__setup("nonmi_ipi", nonmi_ipi_setup);
+
struct smp_ops smp_ops = {
.smp_prepare_boot_cpu = native_smp_prepare_boot_cpu,
.smp_prepare_cpus = native_smp_prepare_cpus,
--
1.7.6.4
next prev parent reply other threads:[~2011-10-13 19:15 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-13 19:14 [v2 PATCH 0/3] Use NMI " Don Zickus
2011-10-13 19:14 ` [v2 PATCH 1/3] x86, reboot: Use NMI instead of REBOOT_VECTOR " Don Zickus
2011-12-05 13:21 ` [tip:x86/debug] " tip-bot for Don Zickus
2011-12-20 22:38 ` Yinghai Lu
2011-12-21 14:59 ` Don Zickus
2011-12-21 18:24 ` Yinghai Lu
2011-12-22 20:16 ` Don Zickus
2012-01-05 18:17 ` Don Zickus
2012-01-05 21:44 ` Yinghai Lu
2011-10-13 19:14 ` [v2 PATCH 2/3] x86, NMI: Add NMI IPI selftest Don Zickus
2011-12-05 13:22 ` [tip:x86/debug] " tip-bot for Don Zickus
2011-12-06 9:06 ` Ingo Molnar
2011-12-06 18:08 ` Don Zickus
2011-12-06 20:01 ` Ingo Molnar
2011-12-06 20:25 ` [tip:x86/debug] x86, NMI: NMI-selftest should handle the UP case properly tip-bot for Don Zickus
2011-12-07 11:06 ` [patch] x86, NMI: add to_cpumask() to silence compile warning Dan Carpenter
2011-12-07 14:59 ` Don Zickus
2011-12-07 21:12 ` Don Zickus
2011-10-13 19:14 ` Don Zickus [this message]
2011-12-05 13:23 ` [tip:x86/debug] x86, NMI: Add knob to disable using NMI IPIs to stop cpus tip-bot for Don Zickus
2011-11-08 19:25 ` [v2 PATCH 0/3] Use NMI " Don Zickus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1318533267-18880-4-git-send-email-dzickus@redhat.com \
--to=dzickus@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=avi@redhat.com \
--cc=gong.chen@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=mjg@redhat.com \
--cc=peterz@infradead.org \
--cc=robert.richter@amd.com \
--cc=satoru.moriya@hds.com \
--cc=seiji.aguchi@hds.com \
--cc=tony.luck@intel.com \
--cc=vgoyal@redhat.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome