mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: tip-bot for Don Zickus <dzickus@redhat.com>
To: linux-tip-commits@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, hpa@zytor.com, mingo@redhat.com,
	andi@firstfloor.org, torvalds@linux-foundation.org,
	peterz@infradead.org, robert.richter@amd.com, tglx@linutronix.de,
	mingo@elte.hu, dzickus@redhat.com
Subject: [tip:x86/debug] x86, NMI: Add knob to disable using NMI IPIs to stop cpus
Date: Mon, 5 Dec 2011 05:23:13 -0800	[thread overview]
Message-ID: <tip-bda62633983f9db49ce0b1a9235b3709c1cda5f0@git.kernel.org> (raw)
In-Reply-To: <1318533267-18880-4-git-send-email-dzickus@redhat.com>

Commit-ID:  bda62633983f9db49ce0b1a9235b3709c1cda5f0
Gitweb:     http://git.kernel.org/tip/bda62633983f9db49ce0b1a9235b3709c1cda5f0
Author:     Don Zickus <dzickus@redhat.com>
AuthorDate: Thu, 13 Oct 2011 15:14:27 -0400
Committer:  Ingo Molnar <mingo@elte.hu>
CommitDate: Mon, 5 Dec 2011 12:00:23 +0100

x86, NMI: Add knob to disable using NMI IPIs to stop cpus

Some machines may exhibit problems using the NMI to stop other
cpus. This knob just allows one to revert back to the original
behaviour to help diagnose the problem.

V2:
  make function static

Signed-off-by: Don Zickus <dzickus@redhat.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Robert Richter <robert.richter@amd.com>
Cc: seiji.aguchi@hds.com
Cc: vgoyal@redhat.com
Cc: mjg@redhat.com
Cc: tony.luck@intel.com
Cc: gong.chen@intel.com
Cc: satoru.moriya@hds.com
Cc: avi@redhat.com
Cc: Andi Kleen <andi@firstfloor.org>
Link: http://lkml.kernel.org/r/1318533267-18880-4-git-send-email-dzickus@redhat.com
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
 Documentation/kernel-parameters.txt |    4 ++++
 arch/x86/kernel/smp.c               |   13 +++++++++++++
 2 files changed, 17 insertions(+), 0 deletions(-)

diff --git a/Documentation/kernel-parameters.txt b/Documentation/kernel-parameters.txt
index a0c5c5f..b4339e5 100644
--- a/Documentation/kernel-parameters.txt
+++ b/Documentation/kernel-parameters.txt
@@ -1796,6 +1796,10 @@ bytes respectively. Such letter suffixes can also be entirely omitted.
 	nomfgpt		[X86-32] Disable Multi-Function General Purpose
 			Timer usage (for AMD Geode machines).
 
+	nonmi_ipi	[X86] Disable using NMI IPIs during panic/reboot to
+			shutdown the other cpus.  Instead use the REBOOT_VECTOR
+			irq.
+
 	nopat		[X86] Disable PAT (page attribute table extension of
 			pagetables) support.
 
diff --git a/arch/x86/kernel/smp.c b/arch/x86/kernel/smp.c
index e72b175..113acda 100644
--- a/arch/x86/kernel/smp.c
+++ b/arch/x86/kernel/smp.c
@@ -249,6 +249,11 @@ static void native_irq_stop_other_cpus(int wait)
 	local_irq_restore(flags);
 }
 
+static void native_smp_disable_nmi_ipi(void)
+{
+	smp_ops.stop_other_cpus = native_irq_stop_other_cpus;
+}
+
 /*
  * Reschedule call back.
  */
@@ -280,6 +285,14 @@ void smp_call_function_single_interrupt(struct pt_regs *regs)
 	irq_exit();
 }
 
+static int __init nonmi_ipi_setup(char *str)
+{
+        native_smp_disable_nmi_ipi();
+        return 1;
+}
+
+__setup("nonmi_ipi", nonmi_ipi_setup);
+
 struct smp_ops smp_ops = {
 	.smp_prepare_boot_cpu	= native_smp_prepare_boot_cpu,
 	.smp_prepare_cpus	= native_smp_prepare_cpus,

  reply	other threads:[~2011-12-05 13:23 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-13 19:14 [v2 PATCH 0/3] Use NMI " Don Zickus
2011-10-13 19:14 ` [v2 PATCH 1/3] x86, reboot: Use NMI instead of REBOOT_VECTOR " Don Zickus
2011-12-05 13:21   ` [tip:x86/debug] " tip-bot for Don Zickus
2011-12-20 22:38     ` Yinghai Lu
2011-12-21 14:59       ` Don Zickus
2011-12-21 18:24         ` Yinghai Lu
2011-12-22 20:16           ` Don Zickus
2012-01-05 18:17           ` Don Zickus
2012-01-05 21:44             ` Yinghai Lu
2011-10-13 19:14 ` [v2 PATCH 2/3] x86, NMI: Add NMI IPI selftest Don Zickus
2011-12-05 13:22   ` [tip:x86/debug] " tip-bot for Don Zickus
2011-12-06  9:06     ` Ingo Molnar
2011-12-06 18:08       ` Don Zickus
2011-12-06 20:01         ` Ingo Molnar
2011-12-06 20:25         ` [tip:x86/debug] x86, NMI: NMI-selftest should handle the UP case properly tip-bot for Don Zickus
2011-12-07 11:06         ` [patch] x86, NMI: add to_cpumask() to silence compile warning Dan Carpenter
2011-12-07 14:59           ` Don Zickus
2011-12-07 21:12           ` Don Zickus
2011-10-13 19:14 ` [v2 PATCH 3/3] x86, NMI: knob to disable using NMI IPIs to stop cpus Don Zickus
2011-12-05 13:23   ` tip-bot for Don Zickus [this message]
2011-11-08 19:25 ` [v2 PATCH 0/3] Use NMI " Don Zickus

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tip-bda62633983f9db49ce0b1a9235b3709c1cda5f0@git.kernel.org \
    --to=dzickus@redhat.com \
    --cc=andi@firstfloor.org \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=robert.richter@amd.com \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome