mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Paul Bolle <pebolle@tiscali.nl>
To: Greg Ungerer <gerg@snapgear.com>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>,
	linux-m68k@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 12/21 v2] m68k: drop unused Kconfig symbols
Date: Tue, 18 Oct 2011 14:30:43 +0200	[thread overview]
Message-ID: <1318941043.6414.35.camel@x61.thuisdomein> (raw)
In-Reply-To: <4E9D6C05.9040106@snapgear.com>

On Tue, 2011-10-18 at 22:07 +1000, Greg Ungerer wrote:
> > - dropped SOM5282EM too (discovered this while doing this second
> >    version, my scripts aren't smart enough too catch it)
> 
> Hmm. I don't want to lose the SOM5282EM config option. Although it
> isn't used inside the code it does let the configurer know that this
> specific board is supported.

Isn't there another way? You're also adding a configuration option. This
means your configurer has to make a decision whether or not to enable
support for that board while this decision actually has no effect.
Apparently that support comes for free (I'm guessing once M528x support
is enabled, I haven't checked that). Wouldn't a comment do? Or adding a
line to some help text? 

In the mean time I suppose you're willing to fix this part of my patch
yourself (ie, I don't have to redo this again).


Paul Bolle


  reply	other threads:[~2011-10-18 12:30 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-18  8:10 Paul Bolle
2011-10-18 12:07 ` Greg Ungerer
2011-10-18 12:30   ` Paul Bolle [this message]
2011-10-20  5:25     ` Greg Ungerer
2011-10-20  6:54       ` Geert Uytterhoeven
2011-10-20 10:58         ` Paul Bolle
2011-10-20 11:06       ` Paul Bolle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1318941043.6414.35.camel@x61.thuisdomein \
    --to=pebolle@tiscali.nl \
    --cc=geert@linux-m68k.org \
    --cc=gerg@snapgear.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-m68k@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®