From: Paul Bolle <pebolle@tiscali.nl>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Greg Ungerer <gerg@snapgear.com>,
linux-m68k@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 12/21 v2] m68k: drop unused Kconfig symbols
Date: Thu, 20 Oct 2011 12:58:13 +0200 [thread overview]
Message-ID: <1319108293.8405.21.camel@x61.thuisdomein> (raw)
In-Reply-To: <CAMuHMdVpAhJDhTDSwRWb7s4KvMGzh+twL7DhH1Ww=ZNK9aNE2w@mail.gmail.com>
On Thu, 2011-10-20 at 08:54 +0200, Geert Uytterhoeven wrote:
> BTW, a few of the *_SCC symbols became orphaned, too.
Yes, MVME147_SCC, MVME162_SCC and BVME6000_SCC look unused. I missed
those because of these lines:
config SERIAL_CONSOLE
bool "Support for serial port console"
depends on [..] MVME147_SCC || [...] MVME162_SCC || BVME6000_SCC [...]
The scripts I used aren't smart enough to evaluate a second instance of
these symbols. One of the simple heuristics they used was: "mentioned a
second time in any of the Kconfig files means it is used".
I haven't yet discovered a smarter way to do this. In this case that
might be: if any other usage of the symbol in the Kconfig doesn't
"select" any other symbol it is unused (provided, of course, there's no
instance of CONFIG_$symbol in any non-Kconfig file) . But I don't know
if that will work. Moreover, this requires an actual parser of the
Kconfig syntax. I've chosen to keep things as dumb as possible, and use
as little understanding of the Kconfig syntax as possible. I still found
quite a number of unused symbols with an acceptable signal to noise
ratio. False-negatives like these are the downside.
Paul Bolle
next prev parent reply other threads:[~2011-10-20 10:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-18 8:10 Paul Bolle
2011-10-18 12:07 ` Greg Ungerer
2011-10-18 12:30 ` Paul Bolle
2011-10-20 5:25 ` Greg Ungerer
2011-10-20 6:54 ` Geert Uytterhoeven
2011-10-20 10:58 ` Paul Bolle [this message]
2011-10-20 11:06 ` Paul Bolle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1319108293.8405.21.camel@x61.thuisdomein \
--to=pebolle@tiscali.nl \
--cc=geert@linux-m68k.org \
--cc=gerg@snapgear.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®