* [PATCH 1/2] gpio-pch: Use NUMA_NO_NODE not GFP_KERNEL
@ 2011-10-19 1:37 Tomoya MORINAGA
2011-10-19 1:37 ` [PATCH 2/2] gpio-ml-ioh: " Tomoya MORINAGA
2011-10-19 1:59 ` [PATCH 1/2] gpio-pch: " David Rientjes
0 siblings, 2 replies; 5+ messages in thread
From: Tomoya MORINAGA @ 2011-10-19 1:37 UTC (permalink / raw)
To: Grant Likely, linux-kernel
Cc: qi.wang, yong.y.wang, joel.clark, kok.howg.ewe, Dan Carpenter,
David Rientjes, Tomoya MORINAGA
Currently, GFP_KERNEL is used as parameter of irq_alloc_descs like below.
irq_base = irq_alloc_descs(-1, IOH_IRQ_BASE, num_ports[j],
GFP_KERNEL);
This is not true.
So, this patch uses NUMA_NO_NODE not GFP_KERNEL.
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Reported-by: David Rientjes <rientjes@google.com>
Signed-off-by: Tomoya MORINAGA <tomoya-linux@dsn.lapis-semi.com>
---
drivers/gpio/gpio-pch.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/gpio/gpio-pch.c b/drivers/gpio/gpio-pch.c
index 596e454..64b0e39 100644
--- a/drivers/gpio/gpio-pch.c
+++ b/drivers/gpio/gpio-pch.c
@@ -399,7 +399,7 @@ static int __devinit pch_gpio_probe(struct pci_dev *pdev,
goto err_gpiochip_add;
}
- irq_base = irq_alloc_descs(-1, 0, gpio_pins[chip->ioh], GFP_KERNEL);
+ irq_base = irq_alloc_descs(-1, 0, gpio_pins[chip->ioh], NUMA_NO_NODE);
if (irq_base < 0) {
dev_warn(&pdev->dev, "PCH gpio: Failed to get IRQ base num\n");
chip->irq_base = -1;
--
1.7.4.4
^ permalink raw reply [flat|nested] 5+ messages in thread* [PATCH 2/2] gpio-ml-ioh: Use NUMA_NO_NODE not GFP_KERNEL
2011-10-19 1:37 [PATCH 1/2] gpio-pch: Use NUMA_NO_NODE not GFP_KERNEL Tomoya MORINAGA
@ 2011-10-19 1:37 ` Tomoya MORINAGA
2011-10-19 2:00 ` David Rientjes
2011-10-20 1:01 ` Grant Likely
2011-10-19 1:59 ` [PATCH 1/2] gpio-pch: " David Rientjes
1 sibling, 2 replies; 5+ messages in thread
From: Tomoya MORINAGA @ 2011-10-19 1:37 UTC (permalink / raw)
To: Grant Likely, linux-kernel
Cc: qi.wang, yong.y.wang, joel.clark, kok.howg.ewe, Dan Carpenter,
David Rientjes, Tomoya MORINAGA
Currently, GFP_KERNEL is used as parameter of irq_alloc_descs like below.
irq_base = irq_alloc_descs(-1, IOH_IRQ_BASE, num_ports[j],
GFP_KERNEL);
This is not true.
So, this patch uses NUMA_NO_NODE not GFP_KERNEL.
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Reported-by: David Rientjes <rientjes@google.com>
Signed-off-by: Tomoya MORINAGA <tomoya-linux@dsn.lapis-semi.com>
---
drivers/gpio/gpio-ml-ioh.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/gpio/gpio-ml-ioh.c b/drivers/gpio/gpio-ml-ioh.c
index 88d65be..1b59003 100644
--- a/drivers/gpio/gpio-ml-ioh.c
+++ b/drivers/gpio/gpio-ml-ioh.c
@@ -429,7 +429,7 @@ static int __devinit ioh_gpio_probe(struct pci_dev *pdev,
chip = chip_save;
for (j = 0; j < 8; j++, chip++) {
irq_base = irq_alloc_descs(-1, IOH_IRQ_BASE, num_ports[j],
- GFP_KERNEL);
+ NUMA_NO_NODE);
if (irq_base < 0) {
dev_warn(&pdev->dev,
"ml_ioh_gpio: Failed to get IRQ base num\n");
--
1.7.4.4
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH 2/2] gpio-ml-ioh: Use NUMA_NO_NODE not GFP_KERNEL
2011-10-19 1:37 ` [PATCH 2/2] gpio-ml-ioh: " Tomoya MORINAGA
@ 2011-10-19 2:00 ` David Rientjes
2011-10-20 1:01 ` Grant Likely
1 sibling, 0 replies; 5+ messages in thread
From: David Rientjes @ 2011-10-19 2:00 UTC (permalink / raw)
To: Tomoya MORINAGA
Cc: Grant Likely, linux-kernel, qi.wang, yong.y.wang, joel.clark,
kok.howg.ewe, Dan Carpenter
On Wed, 19 Oct 2011, Tomoya MORINAGA wrote:
> Currently, GFP_KERNEL is used as parameter of irq_alloc_descs like below.
>
> irq_base = irq_alloc_descs(-1, IOH_IRQ_BASE, num_ports[j],
> GFP_KERNEL);
>
> This is not true.
> So, this patch uses NUMA_NO_NODE not GFP_KERNEL.
>
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> Reported-by: David Rientjes <rientjes@google.com>
> Signed-off-by: Tomoya MORINAGA <tomoya-linux@dsn.lapis-semi.com>
Acked-by: David Rientjes <rientjes@google.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 2/2] gpio-ml-ioh: Use NUMA_NO_NODE not GFP_KERNEL
2011-10-19 1:37 ` [PATCH 2/2] gpio-ml-ioh: " Tomoya MORINAGA
2011-10-19 2:00 ` David Rientjes
@ 2011-10-20 1:01 ` Grant Likely
1 sibling, 0 replies; 5+ messages in thread
From: Grant Likely @ 2011-10-20 1:01 UTC (permalink / raw)
To: Tomoya MORINAGA
Cc: linux-kernel, qi.wang, yong.y.wang, joel.clark, kok.howg.ewe,
Dan Carpenter, David Rientjes
On Wed, Oct 19, 2011 at 10:37:40AM +0900, Tomoya MORINAGA wrote:
> Currently, GFP_KERNEL is used as parameter of irq_alloc_descs like below.
>
> irq_base = irq_alloc_descs(-1, IOH_IRQ_BASE, num_ports[j],
> GFP_KERNEL);
>
> This is not true.
> So, this patch uses NUMA_NO_NODE not GFP_KERNEL.
Applied both, thanks.
g.
>
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> Reported-by: David Rientjes <rientjes@google.com>
> Signed-off-by: Tomoya MORINAGA <tomoya-linux@dsn.lapis-semi.com>
> ---
> drivers/gpio/gpio-ml-ioh.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/gpio/gpio-ml-ioh.c b/drivers/gpio/gpio-ml-ioh.c
> index 88d65be..1b59003 100644
> --- a/drivers/gpio/gpio-ml-ioh.c
> +++ b/drivers/gpio/gpio-ml-ioh.c
> @@ -429,7 +429,7 @@ static int __devinit ioh_gpio_probe(struct pci_dev *pdev,
> chip = chip_save;
> for (j = 0; j < 8; j++, chip++) {
> irq_base = irq_alloc_descs(-1, IOH_IRQ_BASE, num_ports[j],
> - GFP_KERNEL);
> + NUMA_NO_NODE);
> if (irq_base < 0) {
> dev_warn(&pdev->dev,
> "ml_ioh_gpio: Failed to get IRQ base num\n");
> --
> 1.7.4.4
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] gpio-pch: Use NUMA_NO_NODE not GFP_KERNEL
2011-10-19 1:37 [PATCH 1/2] gpio-pch: Use NUMA_NO_NODE not GFP_KERNEL Tomoya MORINAGA
2011-10-19 1:37 ` [PATCH 2/2] gpio-ml-ioh: " Tomoya MORINAGA
@ 2011-10-19 1:59 ` David Rientjes
1 sibling, 0 replies; 5+ messages in thread
From: David Rientjes @ 2011-10-19 1:59 UTC (permalink / raw)
To: Tomoya MORINAGA
Cc: Grant Likely, linux-kernel, qi.wang, yong.y.wang, joel.clark,
kok.howg.ewe, Dan Carpenter
On Wed, 19 Oct 2011, Tomoya MORINAGA wrote:
> Currently, GFP_KERNEL is used as parameter of irq_alloc_descs like below.
>
> irq_base = irq_alloc_descs(-1, IOH_IRQ_BASE, num_ports[j],
> GFP_KERNEL);
>
> This is not true.
> So, this patch uses NUMA_NO_NODE not GFP_KERNEL.
>
Passing NUMA_NO_NODE means the allocation will be preferred on a node that
is local to the executing processor.
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> Reported-by: David Rientjes <rientjes@google.com>
> Signed-off-by: Tomoya MORINAGA <tomoya-linux@dsn.lapis-semi.com>
Acked-by: David Rientjes <rientjes@google.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2011-10-20 1:47 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-10-19 1:37 [PATCH 1/2] gpio-pch: Use NUMA_NO_NODE not GFP_KERNEL Tomoya MORINAGA
2011-10-19 1:37 ` [PATCH 2/2] gpio-ml-ioh: " Tomoya MORINAGA
2011-10-19 2:00 ` David Rientjes
2011-10-20 1:01 ` Grant Likely
2011-10-19 1:59 ` [PATCH 1/2] gpio-pch: " David Rientjes
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®