From: Stephen Warren <swarren@nvidia.com>
To: Linus Walleij <linus.walleij@stericsson.com>,
Linus Walleij <linus.walleij@linaro.org>
Cc: linux-kernel@vger.kernel.org, Barry Song <21cnbao@gmail.com>,
Shawn Guo <shawn.guo@freescale.com>,
Sascha Hauer <s.hauer@pengutronix.de>,
David Brown <davidb@codeaurora.org>,
Grant Likely <grant.likely@secretlab.ca>,
Rongjun Ying <Rongjun.Ying@csr.com>,
Linaro Dev <linaro-dev@lists.linaro.org>,
Stephen Warren <swarren@nvidia.com>
Subject: [PATCH 2/4] pinctrl: Remove unsafe __refdata
Date: Wed, 19 Oct 2011 16:19:26 -0600 [thread overview]
Message-ID: <1319062768-26391-2-git-send-email-swarren@nvidia.com> (raw)
In-Reply-To: <1319062768-26391-1-git-send-email-swarren@nvidia.com>
A pin controller's pin definitions are used both during pinctrl_register()
and pinctrl_unregister(). The latter happens outside of __init/__devinit
time, and hence it is unsafe to mark the pin array as __refdata.
Signed-off-by: Stephen Warren <swarren@nvidia.com>
---
drivers/pinctrl/pinmux-sirf.c | 2 +-
drivers/pinctrl/pinmux-u300.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/pinctrl/pinmux-sirf.c b/drivers/pinctrl/pinmux-sirf.c
index cad4f5d..3bc083c 100644
--- a/drivers/pinctrl/pinmux-sirf.c
+++ b/drivers/pinctrl/pinmux-sirf.c
@@ -30,7 +30,7 @@
* pad list for the pinmux subsystem
* refer to CS-131858-DC-6A.xls
*/
-static const struct pinctrl_pin_desc __refdata sirfsoc_pads[] = {
+static const struct pinctrl_pin_desc sirfsoc_pads[] = {
PINCTRL_PIN(4, "pwm0"),
PINCTRL_PIN(5, "pwm1"),
PINCTRL_PIN(6, "pwm2"),
diff --git a/drivers/pinctrl/pinmux-u300.c b/drivers/pinctrl/pinmux-u300.c
index be6e04d..ed8bcd8 100644
--- a/drivers/pinctrl/pinmux-u300.c
+++ b/drivers/pinctrl/pinmux-u300.c
@@ -179,7 +179,7 @@
#define U300_NUM_PADS 467
/* Pad names for the pinmux subsystem */
-static const struct pinctrl_pin_desc __refdata u300_pads[] = {
+static const struct pinctrl_pin_desc u300_pads[] = {
/* Pads along the top edge of the chip */
PINCTRL_PIN(0, "P PAD VDD 28"),
PINCTRL_PIN(1, "P PAD GND 28"),
--
1.7.0.4
next prev parent reply other threads:[~2011-10-19 22:19 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-19 22:19 [PATCH 1/4] pinctrl: get_group_pins() const fixes Stephen Warren
2011-10-19 22:19 ` Stephen Warren [this message]
2011-10-20 9:44 ` [PATCH 2/4] pinctrl: Remove unsafe __refdata Linus Walleij
2011-10-20 9:46 ` Barry Song
2011-10-20 9:54 ` Linus Walleij
2011-10-19 22:19 ` [PATCH 3/4] pinctrl: Don't copy pin names when registering them Stephen Warren
2011-10-20 9:45 ` Linus Walleij
2011-10-19 22:19 ` [PATCH 4/4] pinctrl: Don't copy function name when requesting a pin Stephen Warren
2011-10-20 9:48 ` Linus Walleij
2011-10-20 9:42 ` [PATCH 1/4] pinctrl: get_group_pins() const fixes Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1319062768-26391-2-git-send-email-swarren@nvidia.com \
--to=swarren@nvidia.com \
--cc=21cnbao@gmail.com \
--cc=Rongjun.Ying@csr.com \
--cc=davidb@codeaurora.org \
--cc=grant.likely@secretlab.ca \
--cc=linaro-dev@lists.linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linus.walleij@stericsson.com \
--cc=linux-kernel@vger.kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawn.guo@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®