mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Stephen Warren <swarren@nvidia.com>
To: Linus Walleij <linus.walleij@stericsson.com>,
	Linus Walleij <linus.walleij@linaro.org>
Cc: linux-kernel@vger.kernel.org, Barry Song <21cnbao@gmail.com>,
	Shawn Guo <shawn.guo@freescale.com>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	David Brown <davidb@codeaurora.org>,
	Grant Likely <grant.likely@secretlab.ca>,
	Rongjun Ying <Rongjun.Ying@csr.com>,
	Linaro Dev <linaro-dev@lists.linaro.org>,
	Stephen Warren <swarren@nvidia.com>
Subject: [PATCH 3/4] pinctrl: Don't copy pin names when registering them
Date: Wed, 19 Oct 2011 16:19:27 -0600	[thread overview]
Message-ID: <1319062768-26391-3-git-send-email-swarren@nvidia.com> (raw)
In-Reply-To: <1319062768-26391-1-git-send-email-swarren@nvidia.com>

A pin controller's names array is no longer marked __refdata. Hence, we
can avoid copying a pin's name into the descriptor when registering it.
Instead, just point at the string supplied in the pin array.

This both simplifies and speeds up pin controller initialization, but
also removes the hard-coded maximum pin name length.

Signed-off-by: Stephen Warren <swarren@nvidia.com>
---
 drivers/pinctrl/core.c |    5 ++---
 drivers/pinctrl/core.h |    2 +-
 2 files changed, 3 insertions(+), 4 deletions(-)

diff --git a/drivers/pinctrl/core.c b/drivers/pinctrl/core.c
index 97a4eeb..15d7e5a 100644
--- a/drivers/pinctrl/core.c
+++ b/drivers/pinctrl/core.c
@@ -168,9 +168,8 @@ static int pinctrl_register_one_pin(struct pinctrl_dev *pctldev,
 	/* Set owner */
 	pindesc->pctldev = pctldev;
 
-	/* Copy optional basic pin info */
-	if (name)
-		strlcpy(pindesc->name, name, sizeof(pindesc->name));
+	/* Copy basic pin info */
+	pindesc->name = name;
 
 	spin_lock(&pctldev->pin_desc_tree_lock);
 	radix_tree_insert(&pctldev->pin_desc_tree, number, pindesc);
diff --git a/drivers/pinctrl/core.h b/drivers/pinctrl/core.h
index 698221e..a493ba6 100644
--- a/drivers/pinctrl/core.h
+++ b/drivers/pinctrl/core.h
@@ -55,7 +55,7 @@ struct pinctrl_dev {
  */
 struct pin_desc {
 	struct pinctrl_dev *pctldev;
-	char	name[16];
+	const char *name;
 	spinlock_t lock;
 	/* These fields only added when supporting pinmux drivers */
 #ifdef CONFIG_PINMUX
-- 
1.7.0.4


  parent reply	other threads:[~2011-10-19 22:19 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-19 22:19 [PATCH 1/4] pinctrl: get_group_pins() const fixes Stephen Warren
2011-10-19 22:19 ` [PATCH 2/4] pinctrl: Remove unsafe __refdata Stephen Warren
2011-10-20  9:44   ` Linus Walleij
2011-10-20  9:46   ` Barry Song
2011-10-20  9:54     ` Linus Walleij
2011-10-19 22:19 ` Stephen Warren [this message]
2011-10-20  9:45   ` [PATCH 3/4] pinctrl: Don't copy pin names when registering them Linus Walleij
2011-10-19 22:19 ` [PATCH 4/4] pinctrl: Don't copy function name when requesting a pin Stephen Warren
2011-10-20  9:48   ` Linus Walleij
2011-10-20  9:42 ` [PATCH 1/4] pinctrl: get_group_pins() const fixes Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1319062768-26391-3-git-send-email-swarren@nvidia.com \
    --to=swarren@nvidia.com \
    --cc=21cnbao@gmail.com \
    --cc=Rongjun.Ying@csr.com \
    --cc=davidb@codeaurora.org \
    --cc=grant.likely@secretlab.ca \
    --cc=linaro-dev@lists.linaro.org \
    --cc=linus.walleij@linaro.org \
    --cc=linus.walleij@stericsson.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=shawn.guo@freescale.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®