mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Yong Zhang <yong.zhang0@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: tglx@linutronix.de, Greg Kroah-Hartman <gregkh@suse.de>,
	linux-usb@vger.kernel.org
Subject: [PATCH 01/49] usb/hcd: Remove tricky code dealing with IRQF_DISABLED && IRQF_SHARED
Date: Sat, 22 Oct 2011 17:56:13 +0800	[thread overview]
Message-ID: <1319277421-9203-2-git-send-email-yong.zhang0@gmail.com> (raw)
In-Reply-To: <1319277421-9203-1-git-send-email-yong.zhang0@gmail.com>

Now, genirq keep irqs disabled when calling the action handler,
we don't need to disable irq by ourselves anymore.

Signed-off-by: Yong Zhang <yong.zhang0@gmail.com>
---
 drivers/usb/core/hcd.c |   15 ---------------
 1 files changed, 0 insertions(+), 15 deletions(-)

diff --git a/drivers/usb/core/hcd.c b/drivers/usb/core/hcd.c
index c9eb4e5..e98f605 100644
--- a/drivers/usb/core/hcd.c
+++ b/drivers/usb/core/hcd.c
@@ -2125,15 +2125,8 @@ EXPORT_SYMBOL_GPL(usb_bus_start_enum);
 irqreturn_t usb_hcd_irq (int irq, void *__hcd)
 {
 	struct usb_hcd		*hcd = __hcd;
-	unsigned long		flags;
 	irqreturn_t		rc;
 
-	/* IRQF_DISABLED doesn't work correctly with shared IRQs
-	 * when the first handler doesn't use it.  So let's just
-	 * assume it's never used.
-	 */
-	local_irq_save(flags);
-
 	if (unlikely(HCD_DEAD(hcd) || !HCD_HW_ACCESSIBLE(hcd))) {
 		rc = IRQ_NONE;
 	} else if (hcd->driver->irq(hcd) == IRQ_NONE) {
@@ -2145,7 +2138,6 @@ irqreturn_t usb_hcd_irq (int irq, void *__hcd)
 		rc = IRQ_HANDLED;
 	}
 
-	local_irq_restore(flags);
 	return rc;
 }
 EXPORT_SYMBOL_GPL(usb_hcd_irq);
@@ -2334,13 +2326,6 @@ static int usb_hcd_request_irqs(struct usb_hcd *hcd,
 
 	if (hcd->driver->irq) {
 
-		/* IRQF_DISABLED doesn't work as advertised when used together
-		 * with IRQF_SHARED. As usb_hcd_irq() will always disable
-		 * interrupts we can remove it here.
-		 */
-		if (irqflags & IRQF_SHARED)
-			irqflags &= ~IRQF_DISABLED;
-
 		snprintf(hcd->irq_descr, sizeof(hcd->irq_descr), "%s:usb%d",
 				hcd->driver->description, hcd->self.busnum);
 		retval = request_irq(irqnum, &usb_hcd_irq, irqflags,
-- 
1.7.1


  reply	other threads:[~2011-10-22  9:57 UTC|newest]

Thread overview: 60+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-22  9:56 [PATCH V3 00/49] Tree wide: cleanup IRQF_DISABLED Yong Zhang
2011-10-22  9:56 ` Yong Zhang [this message]
2011-10-22  9:56 ` [PATCH 02/49] alpha: irq: Remove IRQF_DISABLED Yong Zhang
2011-10-22  9:56 ` [PATCH 04/49] avr32: " Yong Zhang
2011-10-22  9:56 ` [PATCH 05/49] cris: " Yong Zhang
2011-10-22  9:56 ` [PATCH 06/49] frv: " Yong Zhang
2011-10-22  9:56 ` [PATCH 07/49] h8300: " Yong Zhang
2011-10-22  9:56 ` [PATCH 08/49] ia64: " Yong Zhang
2011-10-22  9:56 ` [PATCH 09/49] m32r: " Yong Zhang
2011-10-22  9:56 ` [PATCH 10/49] m68k: " Yong Zhang
2011-10-22  9:56 ` [PATCH 11/49] microblaze: " Yong Zhang
2011-10-22  9:56 ` [PATCH 12/49] MIPS: " Yong Zhang
2011-11-04 12:21   ` Ralf Baechle
2011-11-07  2:10     ` Yong Zhang
2011-11-07  2:49       ` Stephen Rothwell
2011-11-07  3:06         ` Yong Zhang
2011-10-22  9:56 ` [PATCH 13/49] mn10300: " Yong Zhang
2011-10-22  9:56 ` [PATCH 14/49] parisc: irq: remove IRQF_DISABLED Yong Zhang
2011-10-22  9:56 ` [PATCH 15/49] powerpc: irq: Remove IRQF_DISABLED Yong Zhang
2011-10-23  1:57   ` Geoff Levand
2011-10-22  9:56 ` [PATCH 16/49] SH: " Yong Zhang
2011-10-28  6:17   ` Paul Mundt
2011-10-22  9:56 ` [PATCH 17/49] sparc: " Yong Zhang
2011-10-22  9:56 ` [PATCH 18/49] um: " Yong Zhang
2011-10-28 10:54   ` Richard Weinberger
2011-10-28 11:51     ` Yong Zhang
2011-10-22  9:56 ` [PATCH 19/49] unicore32: " Yong Zhang
2011-10-22  9:56 ` [PATCH 20/49] x86: irq: " Yong Zhang
2011-10-22  9:56 ` [PATCH 21/49] xtensa: " Yong Zhang
2011-10-22  9:56 ` [PATCH 22/49] score: " Yong Zhang
2011-10-22  9:56 ` [PATCH 23/49] clocksource: " Yong Zhang
2011-10-22  9:56 ` [PATCH 24/49] SCSI: " Yong Zhang
2011-10-22  9:56 ` [PATCH 25/49] block: " Yong Zhang
2011-10-22  9:56 ` [PATCH 26/49] cdrom: " Yong Zhang
2011-10-22  9:56 ` [PATCH 27/49] driver/char: " Yong Zhang
2011-10-22  9:56 ` [PATCH 28/49] crypto: " Yong Zhang
2011-10-22  9:56 ` [PATCH 29/49] dmaengine: " Yong Zhang
2011-10-22  9:56 ` [PATCH 30/49] EDAC: " Yong Zhang
2011-10-22  9:56 ` [PATCH 31/49] ISDN: " Yong Zhang
2011-10-22  9:56 ` [PATCH 32/49] media: " Yong Zhang
2011-10-22  9:56 ` [PATCH 33/49] drivers:misc:irq: " Yong Zhang
2011-10-22  9:56 ` [PATCH 34/49] mtd: irq: " Yong Zhang
2011-10-22  9:56 ` [PATCH 35/49] net: " Yong Zhang
2011-10-22  9:56 ` [PATCH 36/49] dirvers/parisc: " Yong Zhang
2011-10-22  9:56 ` [PATCH 37/49] pcmcia: " Yong Zhang
2012-02-05 21:11   ` Dominik Brodowski
2011-10-22  9:56 ` [PATCH 38/49] sony-laptop:irq: " Yong Zhang
2011-10-22  9:56 ` [PATCH 39/49] PNP: irq: " Yong Zhang
2011-10-22  9:56 ` [PATCH 40/49] power_supply:irq: " Yong Zhang
2011-10-22  9:56 ` [PATCH 41/49] powerpc/ps3: irq: " Yong Zhang
2011-10-22  9:56 ` [PATCH 42/49] rtc: " Yong Zhang
2011-10-22  9:56 ` [PATCH 43/49] spi: " Yong Zhang
2011-10-24 12:14   ` Grant Likely
2011-10-22  9:56 ` [PATCH 44/49] w1: " Yong Zhang
2011-10-22  9:56 ` [PATCH 45/49] watchdog: " Yong Zhang
2011-10-22  9:56 ` [PATCH 46/49] xen: " Yong Zhang
2011-10-22  9:56 ` [PATCH 47/49] Documentation: irq: Change documents related to IRQF_DISABLED Yong Zhang
2011-10-22  9:57 ` [PATCH 48/49] USB: pxa168: xls: irq: Remove IRQF_DISABLED Yong Zhang
2011-10-22 13:16   ` Tanmay Upadhyay
2011-10-22  9:57 ` [PATCH 49/49] genirq: " Yong Zhang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1319277421-9203-2-git-send-email-yong.zhang0@gmail.com \
    --to=yong.zhang0@gmail.com \
    --cc=gregkh@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®