mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Yong Zhang <yong.zhang0@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: tglx@linutronix.de, Grant Likely <grant.likely@secretlab.ca>,
	spi-devel-general@lists.sourceforge.net
Subject: [PATCH 43/49] spi: irq: Remove IRQF_DISABLED
Date: Sat, 22 Oct 2011 17:56:55 +0800	[thread overview]
Message-ID: <1319277421-9203-44-git-send-email-yong.zhang0@gmail.com> (raw)
In-Reply-To: <1319277421-9203-1-git-send-email-yong.zhang0@gmail.com>

Since commit [e58aa3d2: genirq: Run irq handlers with interrupts disabled],
We run all interrupt handlers with interrupts disabled
and we even check and yell when an interrupt handler
returns with interrupts enabled (see commit [b738a50a:
genirq: Warn when handler enables interrupts]).

So now this flag is a NOOP and can be removed.

Signed-off-by: Yong Zhang <yong.zhang0@gmail.com>
Acked-by: Grant Likely <grant.likely@secretlab.ca>
---
 drivers/spi/spi-bfin5xx.c       |    2 +-
 drivers/spi/spi-coldfire-qspi.c |    2 +-
 drivers/spi/spi-ppc4xx.c        |    2 +-
 drivers/spi/spi-sh-msiof.c      |    2 +-
 drivers/spi/spi-sh.c            |    2 +-
 5 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/spi/spi-bfin5xx.c b/drivers/spi/spi-bfin5xx.c
index b8d25f2..3b83ff8 100644
--- a/drivers/spi/spi-bfin5xx.c
+++ b/drivers/spi/spi-bfin5xx.c
@@ -1098,7 +1098,7 @@ static int bfin_spi_setup(struct spi_device *spi)
 
 	if (chip->pio_interrupt && !drv_data->irq_requested) {
 		ret = request_irq(drv_data->spi_irq, bfin_spi_pio_irq_handler,
-			IRQF_DISABLED, "BFIN_SPI", drv_data);
+			0, "BFIN_SPI", drv_data);
 		if (ret) {
 			dev_err(&spi->dev, "Unable to register spi IRQ\n");
 			goto error;
diff --git a/drivers/spi/spi-coldfire-qspi.c b/drivers/spi/spi-coldfire-qspi.c
index ae2cd1c..7397c4d 100644
--- a/drivers/spi/spi-coldfire-qspi.c
+++ b/drivers/spi/spi-coldfire-qspi.c
@@ -487,7 +487,7 @@ static int __devinit mcfqspi_probe(struct platform_device *pdev)
 		goto fail2;
 	}
 
-	status = request_irq(mcfqspi->irq, mcfqspi_irq_handler, IRQF_DISABLED,
+	status = request_irq(mcfqspi->irq, mcfqspi_irq_handler, 0,
 			     pdev->name, mcfqspi);
 	if (status) {
 		dev_dbg(&pdev->dev, "request_irq failed\n");
diff --git a/drivers/spi/spi-ppc4xx.c b/drivers/spi/spi-ppc4xx.c
index b267fd9..8ec43e0 100644
--- a/drivers/spi/spi-ppc4xx.c
+++ b/drivers/spi/spi-ppc4xx.c
@@ -514,7 +514,7 @@ static int __init spi_ppc4xx_of_probe(struct platform_device *op)
 	/* Request IRQ */
 	hw->irqnum = irq_of_parse_and_map(np, 0);
 	ret = request_irq(hw->irqnum, spi_ppc4xx_int,
-			  IRQF_DISABLED, "spi_ppc4xx_of", (void *)hw);
+			  0, "spi_ppc4xx_of", (void *)hw);
 	if (ret) {
 		dev_err(dev, "unable to allocate interrupt\n");
 		goto free_gpios;
diff --git a/drivers/spi/spi-sh-msiof.c b/drivers/spi/spi-sh-msiof.c
index 2f61a84..51b14c9 100644
--- a/drivers/spi/spi-sh-msiof.c
+++ b/drivers/spi/spi-sh-msiof.c
@@ -636,7 +636,7 @@ static int sh_msiof_spi_probe(struct platform_device *pdev)
 		goto err2;
 	}
 
-	ret = request_irq(i, sh_msiof_spi_irq, IRQF_DISABLED,
+	ret = request_irq(i, sh_msiof_spi_irq, 0,
 			  dev_name(&pdev->dev), p);
 	if (ret) {
 		dev_err(&pdev->dev, "unable to request irq\n");
diff --git a/drivers/spi/spi-sh.c b/drivers/spi/spi-sh.c
index 9eedd71..e0343d4 100644
--- a/drivers/spi/spi-sh.c
+++ b/drivers/spi/spi-sh.c
@@ -484,7 +484,7 @@ static int __devinit spi_sh_probe(struct platform_device *pdev)
 		goto error2;
 	}
 
-	ret = request_irq(irq, spi_sh_irq, IRQF_DISABLED, "spi_sh", ss);
+	ret = request_irq(irq, spi_sh_irq, 0, "spi_sh", ss);
 	if (ret < 0) {
 		dev_err(&pdev->dev, "request_irq error\n");
 		goto error3;
-- 
1.7.1


  parent reply	other threads:[~2011-10-22 10:17 UTC|newest]

Thread overview: 60+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-22  9:56 [PATCH V3 00/49] Tree wide: cleanup IRQF_DISABLED Yong Zhang
2011-10-22  9:56 ` [PATCH 01/49] usb/hcd: Remove tricky code dealing with IRQF_DISABLED && IRQF_SHARED Yong Zhang
2011-10-22  9:56 ` [PATCH 02/49] alpha: irq: Remove IRQF_DISABLED Yong Zhang
2011-10-22  9:56 ` [PATCH 04/49] avr32: " Yong Zhang
2011-10-22  9:56 ` [PATCH 05/49] cris: " Yong Zhang
2011-10-22  9:56 ` [PATCH 06/49] frv: " Yong Zhang
2011-10-22  9:56 ` [PATCH 07/49] h8300: " Yong Zhang
2011-10-22  9:56 ` [PATCH 08/49] ia64: " Yong Zhang
2011-10-22  9:56 ` [PATCH 09/49] m32r: " Yong Zhang
2011-10-22  9:56 ` [PATCH 10/49] m68k: " Yong Zhang
2011-10-22  9:56 ` [PATCH 11/49] microblaze: " Yong Zhang
2011-10-22  9:56 ` [PATCH 12/49] MIPS: " Yong Zhang
2011-11-04 12:21   ` Ralf Baechle
2011-11-07  2:10     ` Yong Zhang
2011-11-07  2:49       ` Stephen Rothwell
2011-11-07  3:06         ` Yong Zhang
2011-10-22  9:56 ` [PATCH 13/49] mn10300: " Yong Zhang
2011-10-22  9:56 ` [PATCH 14/49] parisc: irq: remove IRQF_DISABLED Yong Zhang
2011-10-22  9:56 ` [PATCH 15/49] powerpc: irq: Remove IRQF_DISABLED Yong Zhang
2011-10-23  1:57   ` Geoff Levand
2011-10-22  9:56 ` [PATCH 16/49] SH: " Yong Zhang
2011-10-28  6:17   ` Paul Mundt
2011-10-22  9:56 ` [PATCH 17/49] sparc: " Yong Zhang
2011-10-22  9:56 ` [PATCH 18/49] um: " Yong Zhang
2011-10-28 10:54   ` Richard Weinberger
2011-10-28 11:51     ` Yong Zhang
2011-10-22  9:56 ` [PATCH 19/49] unicore32: " Yong Zhang
2011-10-22  9:56 ` [PATCH 20/49] x86: irq: " Yong Zhang
2011-10-22  9:56 ` [PATCH 21/49] xtensa: " Yong Zhang
2011-10-22  9:56 ` [PATCH 22/49] score: " Yong Zhang
2011-10-22  9:56 ` [PATCH 23/49] clocksource: " Yong Zhang
2011-10-22  9:56 ` [PATCH 24/49] SCSI: " Yong Zhang
2011-10-22  9:56 ` [PATCH 25/49] block: " Yong Zhang
2011-10-22  9:56 ` [PATCH 26/49] cdrom: " Yong Zhang
2011-10-22  9:56 ` [PATCH 27/49] driver/char: " Yong Zhang
2011-10-22  9:56 ` [PATCH 28/49] crypto: " Yong Zhang
2011-10-22  9:56 ` [PATCH 29/49] dmaengine: " Yong Zhang
2011-10-22  9:56 ` [PATCH 30/49] EDAC: " Yong Zhang
2011-10-22  9:56 ` [PATCH 31/49] ISDN: " Yong Zhang
2011-10-22  9:56 ` [PATCH 32/49] media: " Yong Zhang
2011-10-22  9:56 ` [PATCH 33/49] drivers:misc:irq: " Yong Zhang
2011-10-22  9:56 ` [PATCH 34/49] mtd: irq: " Yong Zhang
2011-10-22  9:56 ` [PATCH 35/49] net: " Yong Zhang
2011-10-22  9:56 ` [PATCH 36/49] dirvers/parisc: " Yong Zhang
2011-10-22  9:56 ` [PATCH 37/49] pcmcia: " Yong Zhang
2012-02-05 21:11   ` Dominik Brodowski
2011-10-22  9:56 ` [PATCH 38/49] sony-laptop:irq: " Yong Zhang
2011-10-22  9:56 ` [PATCH 39/49] PNP: irq: " Yong Zhang
2011-10-22  9:56 ` [PATCH 40/49] power_supply:irq: " Yong Zhang
2011-10-22  9:56 ` [PATCH 41/49] powerpc/ps3: irq: " Yong Zhang
2011-10-22  9:56 ` [PATCH 42/49] rtc: " Yong Zhang
2011-10-22  9:56 ` Yong Zhang [this message]
2011-10-24 12:14   ` [PATCH 43/49] spi: " Grant Likely
2011-10-22  9:56 ` [PATCH 44/49] w1: " Yong Zhang
2011-10-22  9:56 ` [PATCH 45/49] watchdog: " Yong Zhang
2011-10-22  9:56 ` [PATCH 46/49] xen: " Yong Zhang
2011-10-22  9:56 ` [PATCH 47/49] Documentation: irq: Change documents related to IRQF_DISABLED Yong Zhang
2011-10-22  9:57 ` [PATCH 48/49] USB: pxa168: xls: irq: Remove IRQF_DISABLED Yong Zhang
2011-10-22 13:16   ` Tanmay Upadhyay
2011-10-22  9:57 ` [PATCH 49/49] genirq: " Yong Zhang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1319277421-9203-44-git-send-email-yong.zhang0@gmail.com \
    --to=yong.zhang0@gmail.com \
    --cc=grant.likely@secretlab.ca \
    --cc=linux-kernel@vger.kernel.org \
    --cc=spi-devel-general@lists.sourceforge.net \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®