* [PATCH] vfs - fix automount should ignore LOOKUP_FOLLOW
@ 2011-10-22 8:01 Ian Kent
2011-10-23 4:41 ` Miklos Szeredi
0 siblings, 1 reply; 3+ messages in thread
From: Ian Kent @ 2011-10-22 8:01 UTC (permalink / raw)
To: Linus Torvalds
Cc: Kernel Mailing List, Al Viro, David Howells, Miklos Szeredi
The recent patch by Miklos Szeredi that was meant to restore the original
behavior of not triggering automounts on stat(2) and other symlink following
syscalls also eliminated the unconditional triggering of automounts for
intermediate path components by eliminating the LOOKUP_CONTUNUE flag from
the check in fs/namei.c:follow_automount().
This introduces a regression itself because it alters the original behaviour
which was to unconditionally automount on intermediate path components.
Signed-off-by: Ian Kent <raven@themaw.net>
---
fs/namei.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/fs/namei.c b/fs/namei.c
index 0b3138d..e4eee7c 100644
--- a/fs/namei.c
+++ b/fs/namei.c
@@ -732,7 +732,7 @@ static int follow_automount(struct path *path, unsigned flags,
* as being automount points. These will need the attentions
* of the daemon to instantiate them before they can be used.
*/
- if (!(flags & (LOOKUP_PARENT | LOOKUP_DIRECTORY |
+ if (!(flags & (LOOKUP_PARENT | LOOKUP_CONTINUE | LOOKUP_DIRECTORY |
LOOKUP_OPEN | LOOKUP_CREATE | LOOKUP_AUTOMOUNT)) &&
path->dentry->d_inode)
return -EISDIR;
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] vfs - fix automount should ignore LOOKUP_FOLLOW
2011-10-22 8:01 [PATCH] vfs - fix automount should ignore LOOKUP_FOLLOW Ian Kent
@ 2011-10-23 4:41 ` Miklos Szeredi
2011-10-23 11:33 ` Ian Kent
0 siblings, 1 reply; 3+ messages in thread
From: Miklos Szeredi @ 2011-10-23 4:41 UTC (permalink / raw)
To: Ian Kent; +Cc: Linus Torvalds, Kernel Mailing List, Al Viro, David Howells
On Sat, Oct 22, 2011 at 10:01 AM, Ian Kent <raven@themaw.net> wrote:
> The recent patch by Miklos Szeredi that was meant to restore the original
> behavior of not triggering automounts on stat(2) and other symlink following
> syscalls also eliminated the unconditional triggering of automounts for
> intermediate path components by eliminating the LOOKUP_CONTUNUE flag from
> the check in fs/namei.c:follow_automount().
>
> This introduces a regression itself because it alters the original behaviour
> which was to unconditionally automount on intermediate path components.
LOOKUP_CONTINUE flag no longer exists (commit 49084c3 "kill LOOKUP_CONTINUE")
So this patch makes no sense for HEAD, it may make sense for backports.
Miklos
>
> Signed-off-by: Ian Kent <raven@themaw.net>
> ---
>
> fs/namei.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/fs/namei.c b/fs/namei.c
> index 0b3138d..e4eee7c 100644
> --- a/fs/namei.c
> +++ b/fs/namei.c
> @@ -732,7 +732,7 @@ static int follow_automount(struct path *path, unsigned flags,
> * as being automount points. These will need the attentions
> * of the daemon to instantiate them before they can be used.
> */
> - if (!(flags & (LOOKUP_PARENT | LOOKUP_DIRECTORY |
> + if (!(flags & (LOOKUP_PARENT | LOOKUP_CONTINUE | LOOKUP_DIRECTORY |
> LOOKUP_OPEN | LOOKUP_CREATE | LOOKUP_AUTOMOUNT)) &&
> path->dentry->d_inode)
> return -EISDIR;
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] vfs - fix automount should ignore LOOKUP_FOLLOW
2011-10-23 4:41 ` Miklos Szeredi
@ 2011-10-23 11:33 ` Ian Kent
0 siblings, 0 replies; 3+ messages in thread
From: Ian Kent @ 2011-10-23 11:33 UTC (permalink / raw)
To: Miklos Szeredi
Cc: Linus Torvalds, Kernel Mailing List, Al Viro, David Howells
On Sun, 2011-10-23 at 06:41 +0200, Miklos Szeredi wrote:
> On Sat, Oct 22, 2011 at 10:01 AM, Ian Kent <raven@themaw.net> wrote:
> > The recent patch by Miklos Szeredi that was meant to restore the original
> > behavior of not triggering automounts on stat(2) and other symlink following
> > syscalls also eliminated the unconditional triggering of automounts for
> > intermediate path components by eliminating the LOOKUP_CONTUNUE flag from
> > the check in fs/namei.c:follow_automount().
> >
> > This introduces a regression itself because it alters the original behaviour
> > which was to unconditionally automount on intermediate path components.
>
> LOOKUP_CONTINUE flag no longer exists (commit 49084c3 "kill LOOKUP_CONTINUE")
Oh .. right, now I think about it I did see that commit, opps!
>
> So this patch makes no sense for HEAD, it may make sense for backports.
Yeah, I was a bit to hasty trying to solve my own backport mistake.
>
> Miklos
>
> >
> > Signed-off-by: Ian Kent <raven@themaw.net>
> > ---
> >
> > fs/namei.c | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/fs/namei.c b/fs/namei.c
> > index 0b3138d..e4eee7c 100644
> > --- a/fs/namei.c
> > +++ b/fs/namei.c
> > @@ -732,7 +732,7 @@ static int follow_automount(struct path *path, unsigned flags,
> > * as being automount points. These will need the attentions
> > * of the daemon to instantiate them before they can be used.
> > */
> > - if (!(flags & (LOOKUP_PARENT | LOOKUP_DIRECTORY |
> > + if (!(flags & (LOOKUP_PARENT | LOOKUP_CONTINUE | LOOKUP_DIRECTORY |
> > LOOKUP_OPEN | LOOKUP_CREATE | LOOKUP_AUTOMOUNT)) &&
> > path->dentry->d_inode)
> > return -EISDIR;
> >
> >
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-10-23 11:33 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-10-22 8:01 [PATCH] vfs - fix automount should ignore LOOKUP_FOLLOW Ian Kent
2011-10-23 4:41 ` Miklos Szeredi
2011-10-23 11:33 ` Ian Kent
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®