mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] arm/tegra: remove unused defines
@ 2011-11-02 15:25 Peter De Schrijver
  2011-11-02 16:34 ` Stephen Warren
  0 siblings, 1 reply; 2+ messages in thread
From: Peter De Schrijver @ 2011-11-02 15:25 UTC (permalink / raw)
  To: Peter De Schrijver
  Cc: Colin Cross, Olof Johansson, Stephen Warren, Russell King,
	linux-tegra, linux-arm-kernel, linux-kernel

PPI_NR is never used in arch/arm/mach-tegra/irq.c. Remove it.

Signed-off-by: Peter De Schrijver <pdeschrijver@nvidia.com>
---
 arch/arm/mach-tegra/irq.c |    4 ----
 1 files changed, 0 insertions(+), 4 deletions(-)

diff --git a/arch/arm/mach-tegra/irq.c b/arch/arm/mach-tegra/irq.c
index 4956c3c..8ad82af 100644
--- a/arch/arm/mach-tegra/irq.c
+++ b/arch/arm/mach-tegra/irq.c
@@ -28,10 +28,6 @@
 
 #include "board.h"
 
-#define INT_SYS_NR	(INT_GPIO_BASE - INT_PRI_BASE)
-#define INT_SYS_SZ	(INT_SEC_BASE - INT_PRI_BASE)
-#define PPI_NR		((INT_SYS_NR+INT_SYS_SZ-1)/INT_SYS_SZ)
-
 #define ICTLR_CPU_IEP_VFIQ	0x08
 #define ICTLR_CPU_IEP_FIR	0x14
 #define ICTLR_CPU_IEP_FIR_SET	0x18
-- 
1.7.7.rc0.72.g4b5ea.dirty


^ permalink raw reply	[flat|nested] 2+ messages in thread

* RE: [PATCH] arm/tegra: remove unused defines
  2011-11-02 15:25 [PATCH] arm/tegra: remove unused defines Peter De Schrijver
@ 2011-11-02 16:34 ` Stephen Warren
  0 siblings, 0 replies; 2+ messages in thread
From: Stephen Warren @ 2011-11-02 16:34 UTC (permalink / raw)
  To: Peter De Schrijver, Peter De Schrijver
  Cc: Colin Cross, Olof Johansson, Russell King, linux-tegra,
	linux-arm-kernel, linux-kernel

Peter De Schrijver wrote at Wednesday, November 02, 2011 9:25 AM:
> PPI_NR is never used in arch/arm/mach-tegra/irq.c. Remove it.
> 
> Signed-off-by: Peter De Schrijver <pdeschrijver@nvidia.com>

Acked-by: Stephen Warren <swarren@nvidia.com>

For reference, I investigated why the defines aren't used, and found:

Those defines were introduced by:

commit 460907bc26f5565aced3cf35a10e3579c671ef50
[ARM] tegra: add suspend and mirror irqs to legacy controller

3524b70ef3336a4f1351a489e83894b88106ab7c moved those defines
into legacy_irq.c (and appears to have added define NUM_ICTLRS to replace
them) and d1d8c666683cdbef18329ff8f3743ddaca8842ee moved them back.

> -#define INT_SYS_NR	(INT_GPIO_BASE - INT_PRI_BASE)
> -#define INT_SYS_SZ	(INT_SEC_BASE - INT_PRI_BASE)
> -#define PPI_NR		((INT_SYS_NR+INT_SYS_SZ-1)/INT_SYS_SZ)

-- 
nvpublic


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2011-11-02 16:34 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-11-02 15:25 [PATCH] arm/tegra: remove unused defines Peter De Schrijver
2011-11-02 16:34 ` Stephen Warren

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®