Re: [Xen-devel] RE: [PATCH 3/3] code clean up

[Ian Campbell <Ian.Campbell@citrix.com>]

On Wed, 2011-11-09 at 11:15 +0000, Paul Durrant wrote:
> Annie,
> 
>   Why was this split out as a separate patch? Can it not be folded into patch 2 since the line it re-formats was introduced there?

It is not generally necessary to split string constants in order to meet
the 80 column (soft) limit in Linux code. Some people frown on it
because it breaks grep'ability.

Ian.

> 
>   Paul
> 
> > -----Original Message-----
> > From: annie.li@oracle.com [mailto:annie.li@oracle.com]
> > Sent: 09 November 2011 08:16
> > To: xen-devel@lists.xensource.com; linux-kernel@vger.kernel.org;
> > konrad.wilk@oracle.com; jeremy@goop.org
> > Cc: kurt.hackel@oracle.com; Paul Durrant; annie.li@oracle.com
> > Subject: [PATCH 3/3] code clean up
> > 
> > From: Annie Li <annie.li@oracle.com>
> > 
> > Signed-off-by: Annie Li <annie.li@oracle.com>
> > ---
> >  drivers/xen/grant-table.c |    3 ++-
> >  1 files changed, 2 insertions(+), 1 deletions(-)
> > 
> > diff --git a/drivers/xen/grant-table.c b/drivers/xen/grant-table.c
> > index a3294a26..458c00d 100644
> > --- a/drivers/xen/grant-table.c
> > +++ b/drivers/xen/grant-table.c
> > @@ -708,7 +708,8 @@ static void gnttab_request_version(void)  {
> >  	int rc;
> >  	struct gnttab_set_version gsv;
> > -	const char *str = "we need grant tables version 2, but only
> > version 1 is available\n";
> > +	const char *str = "we need grant tables version 2, "
> > +					"but only version 1 is
> > available\n";
> > 
> >  	gsv.version = 2;
> >  	rc = HYPERVISOR_grant_table_op(GNTTABOP_set_version, &gsv,
> > 1);
> > --
> > 1.7.6
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel