From: Ian Campbell <Ian.Campbell@citrix.com>
To: annie li <annie.li@oracle.com>
Cc: Paul Durrant <Paul.Durrant@citrix.com>,
"kurt.hackel@oracle.com" <kurt.hackel@oracle.com>,
"jeremy@goop.org" <jeremy@goop.org>,
"xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Konrad Rzeszutek Wilk" <konrad.wilk@oracle.com>
Subject: Re: [Xen-devel] RE: [PATCH 1/3] Introducing grant table V2 stucture
Date: Wed, 9 Nov 2011 16:22:04 +0000 [thread overview]
Message-ID: <1320855724.955.183.camel@zakaz.uk.xensource.com> (raw)
In-Reply-To: <4EBAA3B1.8010401@oracle.com>
On Wed, 2011-11-09 at 16:00 +0000, annie li wrote:
> Maybe addr or gnttab_addr?
IMHO the gnttab_ bit belongs in either (or both) the struct name or the
variable names referencing the struct, rather than the fields
themselves. It should be obvious from the context that this member is
something to do with gnttab. e.g. I think gnttab_shared->addr would be
fine, as would shared->addr in the context of gnttab.c etc.
Ian.
next prev parent reply other threads:[~2011-11-09 16:22 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-09 8:12 patches of upstreaming grant table version 2 ANNIE LI
2011-11-09 8:14 ` [PATCH 1/3] Introducing grant table V2 stucture annie.li
2011-11-09 11:11 ` Paul Durrant
2011-11-09 14:49 ` Konrad Rzeszutek Wilk
2011-11-09 14:56 ` Paul Durrant
[not found] ` <4EBAA3B1.8010401@oracle.com>
2011-11-09 16:22 ` Ian Campbell [this message]
2011-11-10 1:56 ` [Xen-devel] " ANNIE LI
[not found] ` <4EBAA566.80909@oracle.com>
2011-11-09 16:14 ` Paul Durrant
2011-11-10 1:50 ` [Xen-devel] " ANNIE LI
2011-11-09 13:28 ` [Xen-devel] " Ian Campbell
2011-11-09 8:15 ` [PATCH 2/3] Grant tables v2 implementation annie.li
2011-11-09 13:32 ` [Xen-devel] " Ian Campbell
2011-11-09 8:16 ` [PATCH 3/3] code clean up annie.li
2011-11-09 11:15 ` Paul Durrant
2011-11-09 12:18 ` [Xen-devel] " Ian Campbell
2011-11-09 9:05 ` [Xen-devel] patches of upstreaming grant table version 2 ANNIE LI
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1320855724.955.183.camel@zakaz.uk.xensource.com \
--to=ian.campbell@citrix.com \
--cc=Paul.Durrant@citrix.com \
--cc=annie.li@oracle.com \
--cc=jeremy@goop.org \
--cc=konrad.wilk@oracle.com \
--cc=kurt.hackel@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®