[PATCH] usb: OHCI/EHCI-XLS: Use resource_size v2

[PATCH] usb: OHCI/EHCI-XLS: Use resource_size v2

[Thomas Meyer]

Use resource_size function on resource object
instead of explicit computation.

The semantic patch that makes this change is available
in scripts/coccinelle/api/resource_size.cocci.

Signed-off-by: Thomas Meyer <thomas@m3y3r.de>
---

diff -u -p a/drivers/usb/host/ohci-xls.c b/drivers/usb/host/ohci-xls.c
--- a/drivers/usb/host/ohci-xls.c 2011-11-07 19:38:15.467036480 +0100
+++ b/drivers/usb/host/ohci-xls.c 2011-11-08 12:13:16.922398086 +0100
@@ -40,7 +40,7 @@ static int ohci_xls_probe_internal(const
 		goto err1;
 	}
 	hcd->rsrc_start = res->start;
-	hcd->rsrc_len = res->end - res->start + 1;
+	hcd->rsrc_len = resource_size(res);
 
 	if (!request_mem_region(hcd->rsrc_start, hcd->rsrc_len,
 			driver->description)) {
diff -u -p a/drivers/usb/host/ehci-xls.c b/drivers/usb/host/ehci-xls.c
--- a/drivers/usb/host/ehci-xls.c 2011-11-07 19:38:15.387035265 +0100
+++ b/drivers/usb/host/ehci-xls.c 2011-11-08 12:13:30.675915786 +0100
@@ -69,7 +69,7 @@ int ehci_xls_probe_internal(const struct
 	}
 
 	hcd->rsrc_start = res->start;
-	hcd->rsrc_len = res->end - res->start + 1;
+	hcd->rsrc_len = resource_size(res);
 
 	if (!request_mem_region(hcd->rsrc_start, hcd->rsrc_len,
 				driver->description)) {
diff -u -p a/drivers/usb/host/ehci-xls.c b/drivers/usb/host/ehci-xls.c
--- a/drivers/usb/host/ehci-xls.c 2011-11-07 19:38:15.387035265 +0100
+++ b/drivers/usb/host/ehci-xls.c 2011-11-08 12:13:40.392712706 +0100
@@ -69,7 +69,7 @@ int ehci_xls_probe_internal(const struct
 	}
 
 	hcd->rsrc_start = res->start;
-	hcd->rsrc_len = res->end - res->start + 1;
+	hcd->rsrc_len = resource_size(res);
 
 	if (!request_mem_region(hcd->rsrc_start, hcd->rsrc_len,
 				driver->description)) {
diff -u -p a/drivers/usb/host/ohci-xls.c b/drivers/usb/host/ohci-xls.c
--- a/drivers/usb/host/ohci-xls.c 2011-11-07 19:38:15.467036480 +0100
+++ b/drivers/usb/host/ohci-xls.c 2011-11-08 12:13:45.479447560 +0100
@@ -40,7 +40,7 @@ static int ohci_xls_probe_internal(const
 		goto err1;
 	}
 	hcd->rsrc_start = res->start;
-	hcd->rsrc_len = res->end - res->start + 1;
+	hcd->rsrc_len = resource_size(res);
 
 	if (!request_mem_region(hcd->rsrc_start, hcd->rsrc_len,
 			driver->description)) {
diff -u -p a/arch/hexagon/kernel/time.c b/arch/hexagon/kernel/time.c
--- a/arch/hexagon/kernel/time.c 2011-11-07 19:37:21.719553477 +0100
+++ b/arch/hexagon/kernel/time.c 2011-11-08 12:21:17.722176538 +0100
@@ -200,12 +200,10 @@ void __init time_init_deferred(void)
 		resource = rtos_timer_device.resource;
 
 	/*  ioremap here means this has to run later, after paging init  */
-	rtos_timer = ioremap(resource->start, resource->end
-		- resource->start + 1);
+	rtos_timer = ioremap(resource->start, resource_size(resource));
 
 	if (!rtos_timer) {
-		release_mem_region(resource->start, resource->end
-			- resource->start + 1);
+		release_mem_region(resource->start, resource_size(resource));
 	}
 	clocksource_register_khz(&hexagon_clocksource, pcycle_freq_mhz * 1000);
 

Re: [PATCH] usb: OHCI/EHCI-XLS: Use resource_size v2

[Alan Stern]

On Thu, 10 Nov 2011, Thomas Meyer wrote:

> Use resource_size function on resource object
> instead of explicit computation.
> 
> The semantic patch that makes this change is available
> in scripts/coccinelle/api/resource_size.cocci.

Are you having some trouble getting your scripts to email these patches 
correctly?  You have sent them out four or five times now, and they 
have been messed up each time.

Alan Stern

Re: [PATCH] usb: OHCI/EHCI-XLS: Use resource_size v2

[Sergei Shtylyov]

Hello.

On 10.11.2011 20:09, Thomas Meyer wrote:

> Use resource_size function on resource object
> instead of explicit computation.
>
> The semantic patch that makes this change is available
> in scripts/coccinelle/api/resource_size.cocci.
>
> Signed-off-by: Thomas Meyer<thomas@m3y3r.de>
> ---
[...]
> diff -u -p a/arch/hexagon/kernel/time.c b/arch/hexagon/kernel/time.c
> --- a/arch/hexagon/kernel/time.c 2011-11-07 19:37:21.719553477 +0100
> +++ b/arch/hexagon/kernel/time.c 2011-11-08 12:21:17.722176538 +0100
> @@ -200,12 +200,10 @@ void __init time_init_deferred(void)
>   		resource = rtos_timer_device.resource;
>
>   	/*  ioremap here means this has to run later, after paging init  */
> -	rtos_timer = ioremap(resource->start, resource->end
> -		- resource->start + 1);
> +	rtos_timer = ioremap(resource->start, resource_size(resource));
>
>   	if (!rtos_timer) {
> -		release_mem_region(resource->start, resource->end
> -			- resource->start + 1);
> +		release_mem_region(resource->start, resource_size(resource));
>   	}
>   	clocksource_register_khz(&hexagon_clocksource, pcycle_freq_mhz * 1000);


    I don't think this file belongs to the USB specific patch.

WBR, Sergei