[PATCH] Add dm9000 network support for OK6410 board.

[PATCH] Add dm9000 network support for OK6410 board.

[peiyong feng]

Signed-off-by: peiyong feng <peiyong.feng.kernel@gmail.com>
---
 arch/arm/mach-s3c64xx/mach-smdk6410.c |    1 +
 arch/arm/plat-samsung/devs.c          |   40 +++++++++++++++++++++++++++++++++
 2 files changed, 41 insertions(+), 0 deletions(-)

diff --git a/arch/arm/mach-s3c64xx/mach-smdk6410.c b/arch/arm/mach-s3c64xx/mach-smdk6410.c
index 8bc8edd..71e817a 100644
--- a/arch/arm/mach-s3c64xx/mach-smdk6410.c
+++ b/arch/arm/mach-s3c64xx/mach-smdk6410.c
@@ -276,6 +276,7 @@ static struct platform_device *smdk6410_devices[] __initdata = {
 	&s3c_device_fb,
 	&s3c_device_ohci,
 	&s3c_device_usb_hsotg,
+	&s3c_device_dm9000,
 	&samsung_asoc_dma,
 	&s3c64xx_device_iisv4,
 	&samsung_device_keypad,
diff --git a/arch/arm/plat-samsung/devs.c b/arch/arm/plat-samsung/devs.c
index 4ca8b57..38edc1a 100644
--- a/arch/arm/plat-samsung/devs.c
+++ b/arch/arm/plat-samsung/devs.c
@@ -29,6 +29,7 @@
 #include <linux/mtd/partitions.h>
 #include <linux/mmc/host.h>
 #include <linux/ioport.h>
+#include <linux/dm9000.h>
 
 #include <asm/irq.h>
 #include <asm/pmu.h>
@@ -1401,6 +1402,45 @@ void __init s5p_ehci_set_platdata(struct s5p_ehci_platdata *pd)
 }
 #endif /* CONFIG_S5P_DEV_USB_EHCI */
 
+/* Ethernet */
+#ifdef CONFIG_DM9000
+#define S3C64XX_PA_DM9000	(0x18000000)
+#define S3C64XX_SZ_DM9000	SZ_1M
+#define S3C64XX_VA_DM9000	S3C_ADDR(0x03b00300)
+
+static struct resource dm9000_resources[] = {
+	[0] = {
+		.start		= S3C64XX_PA_DM9000,
+		.end		= S3C64XX_PA_DM9000 + 3,
+		.flags		= IORESOURCE_MEM,
+	},
+	[1] = {
+		.start		= S3C64XX_PA_DM9000 + 4,
+		.end		= S3C64XX_PA_DM9000 + S3C64XX_SZ_DM9000 - 1,
+		.flags		= IORESOURCE_MEM,
+	},
+	[2] = {
+		.start		= IRQ_EINT(7),
+		.end		= IRQ_EINT(7),
+		.flags		= IORESOURCE_IRQ | IRQF_TRIGGER_HIGH,
+	},
+};
+
+static struct dm9000_plat_data dm9000_setup = {
+	.flags			= DM9000_PLATF_16BITONLY,
+	.dev_addr		= { 0x08, 0x90, 0x00, 0xa0, 0x90, 0x90 },
+};
+
+static struct platform_device s3c_device_dm9000 = {
+	.name			= "dm9000",
+	.id				= 0,
+	.num_resources	= ARRAY_SIZE(dm9000_resources),
+	.resource		= dm9000_resources,
+	.dev			= {
+		.platform_data = &dm9000_setup,
+	}
+};
+#endif /*#ifdef CONFIG_DM9000*/
 /* USB HSOTG */
 
 #ifdef CONFIG_S3C_DEV_USB_HSOTG
-- 
1.7.7.rc0.235.g8d714

Re: [PATCH] Add dm9000 network support for OK6410 board.

[Thomas Abraham]

On 11 November 2011 15:44, peiyong feng <peiyong.feng.kernel@gmail.com> wrote:
> Signed-off-by: peiyong feng <peiyong.feng.kernel@gmail.com>
> ---
>  arch/arm/mach-s3c64xx/mach-smdk6410.c |    1 +
>  arch/arm/plat-samsung/devs.c          |   40 +++++++++++++++++++++++++++++++++
>  2 files changed, 41 insertions(+), 0 deletions(-)

If the change is intended for OK6410 board, any reason for modifying
mach-smdk6410.c board file?

>
> diff --git a/arch/arm/mach-s3c64xx/mach-smdk6410.c b/arch/arm/mach-s3c64xx/mach-smdk6410.c
> index 8bc8edd..71e817a 100644
> --- a/arch/arm/mach-s3c64xx/mach-smdk6410.c
> +++ b/arch/arm/mach-s3c64xx/mach-smdk6410.c
> @@ -276,6 +276,7 @@ static struct platform_device *smdk6410_devices[] __initdata = {
>        &s3c_device_fb,
>        &s3c_device_ohci,
>        &s3c_device_usb_hsotg,
> +       &s3c_device_dm9000,
>        &samsung_asoc_dma,
>        &s3c64xx_device_iisv4,
>        &samsung_device_keypad,
> diff --git a/arch/arm/plat-samsung/devs.c b/arch/arm/plat-samsung/devs.c
> index 4ca8b57..38edc1a 100644
> --- a/arch/arm/plat-samsung/devs.c
> +++ b/arch/arm/plat-samsung/devs.c
> @@ -29,6 +29,7 @@
>  #include <linux/mtd/partitions.h>
>  #include <linux/mmc/host.h>
>  #include <linux/ioport.h>
> +#include <linux/dm9000.h>
>
>  #include <asm/irq.h>
>  #include <asm/pmu.h>
> @@ -1401,6 +1402,45 @@ void __init s5p_ehci_set_platdata(struct s5p_ehci_platdata *pd)
>  }
>  #endif /* CONFIG_S5P_DEV_USB_EHCI */
>
> +/* Ethernet */
> +#ifdef CONFIG_DM9000
> +#define S3C64XX_PA_DM9000      (0x18000000)
> +#define S3C64XX_SZ_DM9000      SZ_1M
> +#define S3C64XX_VA_DM9000      S3C_ADDR(0x03b00300)

There could be other boards based on other samsung soc's which would
be using dm9000. So arch/arm/plat-samsung/devs.c might not be correct
place for these additions. And, there is S3C64XX_PA_XM0CSN0 in
mach-s3c64xx/include/mach/map.h which should be reused instead of
these new macros.

Please refer to other board files in arch/arm/mach-s3c64xx for
reference on adding dm9000 support for OK6410 board.

Regards,
Thomas.

> +
> +static struct resource dm9000_resources[] = {
> +       [0] = {
> +               .start          = S3C64XX_PA_DM9000,
> +               .end            = S3C64XX_PA_DM9000 + 3,
> +               .flags          = IORESOURCE_MEM,
> +       },
> +       [1] = {
> +               .start          = S3C64XX_PA_DM9000 + 4,
> +               .end            = S3C64XX_PA_DM9000 + S3C64XX_SZ_DM9000 - 1,
> +               .flags          = IORESOURCE_MEM,
> +       },
> +       [2] = {
> +               .start          = IRQ_EINT(7),
> +               .end            = IRQ_EINT(7),
> +               .flags          = IORESOURCE_IRQ | IRQF_TRIGGER_HIGH,
> +       },
> +};
> +
> +static struct dm9000_plat_data dm9000_setup = {
> +       .flags                  = DM9000_PLATF_16BITONLY,
> +       .dev_addr               = { 0x08, 0x90, 0x00, 0xa0, 0x90, 0x90 },
> +};
> +
> +static struct platform_device s3c_device_dm9000 = {
> +       .name                   = "dm9000",
> +       .id                             = 0,
> +       .num_resources  = ARRAY_SIZE(dm9000_resources),
> +       .resource               = dm9000_resources,
> +       .dev                    = {
> +               .platform_data = &dm9000_setup,
> +       }
> +};
> +#endif /*#ifdef CONFIG_DM9000*/
>  /* USB HSOTG */
>
>  #ifdef CONFIG_S3C_DEV_USB_HSOTG
> --
> 1.7.7.rc0.235.g8d714
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
>

RE: [PATCH] Add dm9000 network support for OK6410 board.

[Kukjin Kim]

Peiyong Feng wrote:
> 
Hi Peiyong,

Thanks for your submitting and replying.
But you need to make sure your e-mail uses text-typed instead of html before
replying.

And there are comments below.

> Well, The OK6410 board is based on smdk6410 board.
> And there many other boards that also are based on smdk6410 like mini6410
board.
>
> The reasons why I modified smdk6410 board file are as follows: 
> A. Almost all the devices on OK6410 is supported in smdk6410, and the
device drivers of smdk6410 can work well in OK6410.
>
Okay, you mean, just your OK6410 can work with smdk6410.

> B. If we just make other board file like mini6410 which is also based on
smdk6410, there maybe too many files that are as the same of smdk6410.
>
Okay, you mean, we don't need duplicated codes.

Right, but how do you think that if the dm9000 or something cannot be used
on smdk6410?
Nevertheless, we _really_ need to add it for other board not smdk6410?

Actually, there are codes for SMSC Lan9115 at mach-smdk6410.c......

If you want to use mach-smdk6410.c on your ok6410, well, let us think the
way.

> 2011/11/11 Thomas Abraham <thomas.abraham@linaro.org>
> On 11 November 2011 15:44, peiyong feng <peiyong.feng.kernel@gmail.com>
wrote:
> > Signed-off-by: peiyong feng <peiyong.feng.kernel@gmail.com>
> > ---
> >  arch/arm/mach-s3c64xx/mach-smdk6410.c |    1 +
> >  arch/arm/plat-samsung/devs.c          |   40
+++++++++++++++++++++++++++++++++
> >  2 files changed, 41 insertions(+), 0 deletions(-)
> If the change is intended for OK6410 board, any reason for modifying
> mach-smdk6410.c board file?
>
> >
> > diff --git a/arch/arm/mach-s3c64xx/mach-smdk6410.c
b/arch/arm/mach-s3c64xx/mach-smdk6410.c
> > index 8bc8edd..71e817a 100644
> > --- a/arch/arm/mach-s3c64xx/mach-smdk6410.c
> > +++ b/arch/arm/mach-s3c64xx/mach-smdk6410.c
> > @@ -276,6 +276,7 @@ static struct platform_device *smdk6410_devices[]
__initdata = {
> >        &s3c_device_fb,
> >        &s3c_device_ohci,
> >        &s3c_device_usb_hsotg,
> > +       &s3c_device_dm9000,
> >        &samsung_asoc_dma,
> >        &s3c64xx_device_iisv4,
> >        &samsung_device_keypad,
> > diff --git a/arch/arm/plat-samsung/devs.c b/arch/arm/plat-samsung/devs.c
> > index 4ca8b57..38edc1a 100644
> > --- a/arch/arm/plat-samsung/devs.c
> > +++ b/arch/arm/plat-samsung/devs.c
> > @@ -29,6 +29,7 @@
> >  #include <linux/mtd/partitions.h>
> >  #include <linux/mmc/host.h>
> > #include <linux/ioport.h>
> > +#include <linux/dm9000.h>
> >
> >  #include <asm/irq.h>
> >  #include <asm/pmu.h>
> > @@ -1401,6 +1402,45 @@ void __init s5p_ehci_set_platdata(struct
s5p_ehci_platdata *pd)
> >  }
> >  #endif /* CONFIG_S5P_DEV_USB_EHCI */
> >
> > +/* Ethernet */
> > +#ifdef CONFIG_DM9000
> > +#define S3C64XX_PA_DM9000      (0x18000000)
> > +#define S3C64XX_SZ_DM9000      SZ_1M
> > +#define S3C64XX_VA_DM9000      S3C_ADDR(0x03b00300)
> There could be other boards based on other samsung soc's which would
> be using dm9000. So arch/arm/plat-samsung/devs.c might not be correct
> place for these additions. And, there is S3C64XX_PA_XM0CSN0 in
> mach-s3c64xx/include/mach/map.h which should be reused instead of
> these new macros.
>
Yes right.

Peiyong, you need to think that your codes affect others or not before
submitting.

> Please refer to other board files in arch/arm/mach-s3c64xx for
> reference on adding dm9000 support for OK6410 board.
>
> Regards,
> Thomas.
>
> > +
> > +static struct resource dm9000_resources[] = {
> > +       [0] = {
> > +               .start          = S3C64XX_PA_DM9000,
> > +               .end            = S3C64XX_PA_DM9000 + 3,

What is '3'?

> > +               .flags          = IORESOURCE_MEM,

And you can use DEFINE_RES_MEM macro here.

(snip)

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.

Re: [PATCH] Add dm9000 network support for OK6410 board.

[Peiyong Feng]

HI Kukjin,

Thanks a lot for your comments and reply.


2011/11/15 Kukjin Kim <kgene.kim@samsung.com>:
> Peiyong Feng wrote:
>>
> Hi Peiyong,
>
> Thanks for your submitting and replying.
> But you need to make sure your e-mail uses text-typed instead of html before
> replying.
>
> And there are comments below.
>
>> Well, The OK6410 board is based on smdk6410 board.
>> And there many other boards that also are based on smdk6410 like mini6410
> board.
>>
>> The reasons why I modified smdk6410 board file are as follows:
>> A. Almost all the devices on OK6410 is supported in smdk6410, and the
> device drivers of smdk6410 can work well in OK6410.
>>
> Okay, you mean, just your OK6410 can work with smdk6410.
>
As far as I know, there are some boards based on smdk6410 with the
suffix 6410 like OK6410, mini6410, tiny6410, etc.
The  difference between them is very small.

I give two examples:
1. The DM9000 network card`s irq  on OK6410  is IRQ_EINT(7)
    while the SMSC911x network card`s irq on smdk6410 is
   IRQ_EINT(10), and their CS is the same 0x18000000.

2. Another example is the LCD. As we all know, the kernel has
implemented a very good framework for framebuffer devices.
different LCD device can work with just the right arguments like
left_margin, right_margin, hsync_len, vsync_len, xres, yres, etc.
And their LCD controller is the same.
>> B. If we just make other board file like mini6410 which is also based on
> smdk6410, there maybe too many files that are as the same of smdk6410.
>>
> Okay, you mean, we don't need duplicated codes.
>
> Right, but how do you think that if the dm9000 or something cannot be used
> on smdk6410?
> Nevertheless, we _really_ need to add it for other board not smdk6410?
>
> Actually, there are codes for SMSC Lan9115 at mach-smdk6410.c......
>
> If you want to use mach-smdk6410.c on your ok6410, well, let us think the
> way.

Well, this is the point. How can we deal with the various boards with
the little difference and make them work with the kernel.

>
>> 2011/11/11 Thomas Abraham <thomas.abraham@linaro.org>
>> On 11 November 2011 15:44, peiyong feng <peiyong.feng.kernel@gmail.com>
> wrote:
>> > Signed-off-by: peiyong feng <peiyong.feng.kernel@gmail.com>
>> > ---
>> >  arch/arm/mach-s3c64xx/mach-smdk6410.c |    1 +
>> >  arch/arm/plat-samsung/devs.c          |   40
> +++++++++++++++++++++++++++++++++
>> >  2 files changed, 41 insertions(+), 0 deletions(-)
>> If the change is intended for OK6410 board, any reason for modifying
>> mach-smdk6410.c board file?
>>
>> >
>> > diff --git a/arch/arm/mach-s3c64xx/mach-smdk6410.c
> b/arch/arm/mach-s3c64xx/mach-smdk6410.c
>> > index 8bc8edd..71e817a 100644
>> > --- a/arch/arm/mach-s3c64xx/mach-smdk6410.c
>> > +++ b/arch/arm/mach-s3c64xx/mach-smdk6410.c
>> > @@ -276,6 +276,7 @@ static struct platform_device *smdk6410_devices[]
> __initdata = {
>> >        &s3c_device_fb,
>> >        &s3c_device_ohci,
>> >        &s3c_device_usb_hsotg,
>> > +       &s3c_device_dm9000,
>> >        &samsung_asoc_dma,
>> >        &s3c64xx_device_iisv4,
>> >        &samsung_device_keypad,
>> > diff --git a/arch/arm/plat-samsung/devs.c b/arch/arm/plat-samsung/devs.c
>> > index 4ca8b57..38edc1a 100644
>> > --- a/arch/arm/plat-samsung/devs.c
>> > +++ b/arch/arm/plat-samsung/devs.c
>> > @@ -29,6 +29,7 @@
>> >  #include <linux/mtd/partitions.h>
>> >  #include <linux/mmc/host.h>
>> > #include <linux/ioport.h>
>> > +#include <linux/dm9000.h>
>> >
>> >  #include <asm/irq.h>
>> >  #include <asm/pmu.h>
>> > @@ -1401,6 +1402,45 @@ void __init s5p_ehci_set_platdata(struct
> s5p_ehci_platdata *pd)
>> >  }
>> >  #endif /* CONFIG_S5P_DEV_USB_EHCI */
>> >
>> > +/* Ethernet */
>> > +#ifdef CONFIG_DM9000
>> > +#define S3C64XX_PA_DM9000      (0x18000000)
>> > +#define S3C64XX_SZ_DM9000      SZ_1M
>> > +#define S3C64XX_VA_DM9000      S3C_ADDR(0x03b00300)
>> There could be other boards based on other samsung soc's which would
>> be using dm9000. So arch/arm/plat-samsung/devs.c might not be correct
>> place for these additions. And, there is S3C64XX_PA_XM0CSN0 in
>> mach-s3c64xx/include/mach/map.h which should be reused instead of
>> these new macros.
>>
> Yes right.
>
> Peiyong, you need to think that your codes affect others or not before
> submitting.
>
>> Please refer to other board files in arch/arm/mach-s3c64xx for
>> reference on adding dm9000 support for OK6410 board.
>>
>> Regards,
>> Thomas.
>>
>> > +
>> > +static struct resource dm9000_resources[] = {
>> > +       [0] = {
>> > +               .start          = S3C64XX_PA_DM9000,
>> > +               .end            = S3C64XX_PA_DM9000 + 3,
>
> What is '3'?
>
>> > +               .flags          = IORESOURCE_MEM,
>
> And you can use DEFINE_RES_MEM macro here.
>
> (snip)
>
> Thanks.
>
> Best regards,
> Kgene.
> --
> Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
> SW Solution Development Team, Samsung Electronics Co., Ltd.
>
>

Re: [PATCH] Add dm9000 network support for OK6410 board.

[Thomas Abraham]

On 16 November 2011 07:40, Peiyong Feng <peiyong.feng.kernel@gmail.com> wrote:
> HI Kukjin,
>
> Thanks a lot for your comments and reply.
>
>
> 2011/11/15 Kukjin Kim <kgene.kim@samsung.com>:
>> Peiyong Feng wrote:
>>>
>> Hi Peiyong,
>>
>> Thanks for your submitting and replying.
>> But you need to make sure your e-mail uses text-typed instead of html before
>> replying.
>>
>> And there are comments below.
>>
>>> Well, The OK6410 board is based on smdk6410 board.
>>> And there many other boards that also are based on smdk6410 like mini6410
>> board.
>>>
>>> The reasons why I modified smdk6410 board file are as follows:
>>> A. Almost all the devices on OK6410 is supported in smdk6410, and the
>> device drivers of smdk6410 can work well in OK6410.
>>>
>> Okay, you mean, just your OK6410 can work with smdk6410.
>>
> As far as I know, there are some boards based on smdk6410 with the
> suffix 6410 like OK6410, mini6410, tiny6410, etc.
> The  difference between them is very small.

smdk6410 and ok6410 boards use (based on) Samsung's s3c6410 processor.
Boards based on s3c6410 processor should reuse existing upstream
support available for s3c6410. But, the boards themselves are
different. Both smdk6410 and ok6410 have a common s3c6410, but the
peripherals on the board are all different. So, the statement "there
are some boards based on smdk6410" is not right. The correct one would
be "there are some boards based on s3c6410".

>
> I give two examples:
> 1. The DM9000 network card`s irq  on OK6410  is IRQ_EINT(7)
>    while the SMSC911x network card`s irq on smdk6410 is
>   IRQ_EINT(10), and their CS is the same 0x18000000.

True, but smdk6410 does not have a DM9000 and adding DM9000 device
information in smdk6410 board file is not the right thing.

>
> 2. Another example is the LCD. As we all know, the kernel has
> implemented a very good framework for framebuffer devices.
> different LCD device can work with just the right arguments like
> left_margin, right_margin, hsync_len, vsync_len, xres, yres, etc.
> And their LCD controller is the same.
>>> B. If we just make other board file like mini6410 which is also based on
>> smdk6410, there maybe too many files that are as the same of smdk6410.
>>>
>> Okay, you mean, we don't need duplicated codes.
>>
>> Right, but how do you think that if the dm9000 or something cannot be used
>> on smdk6410?
>> Nevertheless, we _really_ need to add it for other board not smdk6410?
>>
>> Actually, there are codes for SMSC Lan9115 at mach-smdk6410.c......
>>
>> If you want to use mach-smdk6410.c on your ok6410, well, let us think the
>> way.
>
> Well, this is the point. How can we deal with the various boards with
> the little difference and make them work with the kernel.

What is needed is a separate board file ok6410 board. All the s3c6410
related drivers and machine code would be reused, but board specific
data would be contained in the ok6410 board file. You could have a
look at all the arch/arm/mach-s3c64xx/mach-xxx.c files to know how
different boards reuse existing s3c6410 mainline support.

Thanks,
Thomas.

[...]