mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Paul Bolle <pebolle@tiscali.nl>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: linux-m68k@vger.kernel.org, Greg Kroah-Hartman <gregkh@suse.de>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] m68k: Remove references to obsolete CONFIG_SERIAL167
Date: Sun, 13 Nov 2011 12:02:56 +0100	[thread overview]
Message-ID: <1321182176.20271.43.camel@x61.thuisdomein> (raw)
In-Reply-To: <1321180296-22543-1-git-send-email-geert@linux-m68k.org>

On Sun, 2011-11-13 at 11:31 +0100, Geert Uytterhoeven wrote:
> commit 51c9d654c2def97827395a7fbfd0c6f865c26544 ("Staging: delete tty
> drivers") removed the MVME167 serial driver, but forgot to remove these
> references.
> 
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
> ---
>  arch/m68k/Kconfig.devices           |    2 +-
>  arch/m68k/configs/multi_defconfig   |    1 -
>  arch/m68k/configs/mvme16x_defconfig |    1 -
>  3 files changed, 1 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/m68k/Kconfig.devices b/arch/m68k/Kconfig.devices
> index 6033f5d..e01eeb2 100644
> --- a/arch/m68k/Kconfig.devices
> +++ b/arch/m68k/Kconfig.devices
> @@ -128,7 +128,7 @@ config DN_SERIAL
>  
>  config SERIAL_CONSOLE
>  	bool "Support for serial port console"
> -	depends on (AMIGA || ATARI || SUN3 || SUN3X || VME || APOLLO) && (ATARI_MFPSER=y || ATARI_MIDI=y || AMIGA_BUILTIN_SERIAL=y || MULTIFACE_III_TTY=y || SERIAL=y || SERIAL167 || DN_SERIAL)
> +	depends on (AMIGA || ATARI || SUN3 || SUN3X || VME || APOLLO) && (ATARI_MFPSER=y || ATARI_MIDI=y || AMIGA_BUILTIN_SERIAL=y || MULTIFACE_III_TTY=y || SERIAL=y || DN_SERIAL)

0) The SERIAL=y part can also be dropped. There's no Kconfig symbol
SERIAL.

1) I've been looking at this impressive dependency list a few days back.
My impression was that it can be reduced to only AMIGA_BUILTIN_SERIAL=y.
(After that this Kconfig symbol might better be renamed to
AMIGA_BUILTIN_SERIAL_CONSOLE.)

I might have a draft patch to drop the dependencies somewhere. I need to
have another look at that (draft) patch before I can submit it.

>  	---help---
>  	  If you say Y here, it will be possible to use a serial port as the
>  	  system console (the system console is the device which receives all


Paul Bolle


  reply	other threads:[~2011-11-13 11:03 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-13 10:31 Geert Uytterhoeven
2011-11-13 11:02 ` Paul Bolle [this message]
2011-11-17 19:33   ` Geert Uytterhoeven
2011-11-17 19:53     ` Paul Bolle
2011-11-17 21:05       ` Geert Uytterhoeven
2011-11-17 21:34         ` Paul Bolle
2011-11-17 21:40           ` Paul Bolle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1321182176.20271.43.camel@x61.thuisdomein \
    --to=pebolle@tiscali.nl \
    --cc=geert@linux-m68k.org \
    --cc=gregkh@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-m68k@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®