mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Paul Bolle <pebolle@tiscali.nl>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: linux-m68k@vger.kernel.org, Greg Kroah-Hartman <gregkh@suse.de>,
	linux-kernel@vger.kernel.org, Jiri Kosina <trivial@kernel.org>
Subject: Re: [PATCH] m68k: Remove references to obsolete CONFIG_SERIAL167
Date: Thu, 17 Nov 2011 22:34:47 +0100	[thread overview]
Message-ID: <1321565687.20271.309.camel@x61.thuisdomein> (raw)
In-Reply-To: <CAMuHMdW73Nf+bP2u6NRZFMW5c0-PnqYCDtEbZ+weGLs_mzZ1_g@mail.gmail.com>

On Thu, 2011-11-17 at 22:05 +0100, Geert Uytterhoeven wrote:
> > Why do you care about SERIAL_CONSOLE? If it's only really used by
> > AMIGA_BUILTIN_SERIAL why shouldn't we rename it to
> > AMIGA_BUILTIN_SERIAL_CONSOLE?
> 
> Because SERIAL_CONSOLE is a universal platform-independent symbol.
> Other arches have it as well (but less than in the past).
> 
> As soon as m68k gets a new serial driver, it will be used by 2 drivers again.

If one does
    $ git grep -n  "\<\(CONFIG_\)\?SERIAL_CONSOLE\>" | grep -v defconfig

one gets a few hits (summarized):
- arch/m68k/Kconfig.devices: discussed here;
- arch/sparc/Kconfig: apparently unused, and can be dropped;
- arch/xtensa/Kconfig and arch/xtensa/platforms/iss/console.c: the only
  other current usage (note that the "S6105" platform, mentioned in the
  Kconfig file, seems not to use it);
- drivers/staging/serial/68360serial.c: uses CONFIG_SERIAL_CONSOLE, but
  I don't see how it can actually be set for that driver;
- drivers/tty/amiserial.c: discussed here.

I see nothing universal about it: two independent usages, one in
*/iss/console.c and one in */amiserial.c. So I'd say these can be
renamed to (say) ISS_SERIAL_CONSOLE and AMIGA_BUILTIN_SERIAL_CONSOLE.


Paul Bolle


  reply	other threads:[~2011-11-17 21:34 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-13 10:31 Geert Uytterhoeven
2011-11-13 11:02 ` Paul Bolle
2011-11-17 19:33   ` Geert Uytterhoeven
2011-11-17 19:53     ` Paul Bolle
2011-11-17 21:05       ` Geert Uytterhoeven
2011-11-17 21:34         ` Paul Bolle [this message]
2011-11-17 21:40           ` Paul Bolle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1321565687.20271.309.camel@x61.thuisdomein \
    --to=pebolle@tiscali.nl \
    --cc=geert@linux-m68k.org \
    --cc=gregkh@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-m68k@vger.kernel.org \
    --cc=trivial@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®