* [trivial PATCH] omap24xxcam-dma: Fix logical test
@ 2011-11-27 19:42 Joe Perches
2011-11-28 16:04 ` Sakari Ailus
0 siblings, 1 reply; 2+ messages in thread
From: Joe Perches @ 2011-11-27 19:42 UTC (permalink / raw)
To: Mauro Carvalho Chehab; +Cc: linux-media, linux-kernel, Sakari Ailus
Likely misuse of & vs &&.
Signed-off-by: Joe Perches <joe@perches.com>
---
drivers/media/video/omap24xxcam-dma.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/media/video/omap24xxcam-dma.c b/drivers/media/video/omap24xxcam-dma.c
index 1d54b86..3ea38a8 100644
--- a/drivers/media/video/omap24xxcam-dma.c
+++ b/drivers/media/video/omap24xxcam-dma.c
@@ -506,7 +506,7 @@ int omap24xxcam_sgdma_queue(struct omap24xxcam_sgdma *sgdma,
unsigned long flags;
struct sgdma_state *sg_state;
- if ((sglen < 0) || ((sglen > 0) & !sglist))
+ if ((sglen < 0) || ((sglen > 0) && !sglist))
return -EINVAL;
spin_lock_irqsave(&sgdma->lock, flags);
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [trivial PATCH] omap24xxcam-dma: Fix logical test
2011-11-27 19:42 [trivial PATCH] omap24xxcam-dma: Fix logical test Joe Perches
@ 2011-11-28 16:04 ` Sakari Ailus
0 siblings, 0 replies; 2+ messages in thread
From: Sakari Ailus @ 2011-11-28 16:04 UTC (permalink / raw)
To: Joe Perches
Cc: Mauro Carvalho Chehab, linux-media, linux-kernel, Sakari Ailus
On Sun, Nov 27, 2011 at 11:42:15AM -0800, Joe Perches wrote:
> Likely misuse of & vs &&.
>
> Signed-off-by: Joe Perches <joe@perches.com>
Thanks, Joe!
Acked-by: Sakari Ailus <sakari.ailus@iki.fi>
> ---
> drivers/media/video/omap24xxcam-dma.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/media/video/omap24xxcam-dma.c b/drivers/media/video/omap24xxcam-dma.c
> index 1d54b86..3ea38a8 100644
> --- a/drivers/media/video/omap24xxcam-dma.c
> +++ b/drivers/media/video/omap24xxcam-dma.c
> @@ -506,7 +506,7 @@ int omap24xxcam_sgdma_queue(struct omap24xxcam_sgdma *sgdma,
> unsigned long flags;
> struct sgdma_state *sg_state;
>
> - if ((sglen < 0) || ((sglen > 0) & !sglist))
> + if ((sglen < 0) || ((sglen > 0) && !sglist))
> return -EINVAL;
>
> spin_lock_irqsave(&sgdma->lock, flags);
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-media" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Sakari Ailus
e-mail: sakari.ailus@iki.fi jabber/XMPP/Gmail: sailus@retiisi.org.uk
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-11-28 16:04 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-11-27 19:42 [trivial PATCH] omap24xxcam-dma: Fix logical test Joe Perches
2011-11-28 16:04 ` Sakari Ailus
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®