[PATCH] of/irq: of_irq_init: add check for parent equal to child node

[PATCH] of/irq: of_irq_init: add check for parent equal to child node

[Rob Herring]

From: Rob Herring <rob.herring@calxeda.com>

With the revert of "of/irq: of_irq_find_parent: check for parent equal to
child" (dc9372808412edb), we need another way to handle parent node equal
to the child node. This can simply be handled in of_irq_init by checking
for this condition.

Signed-off-by: Rob Herring <rob.herring@calxeda.com>
---
 drivers/of/irq.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/drivers/of/irq.c b/drivers/of/irq.c
index 791270b..19c0115 100644
--- a/drivers/of/irq.c
+++ b/drivers/of/irq.c
@@ -424,6 +424,8 @@ void __init of_irq_init(const struct of_device_id *matches)
 
 		desc->dev = np;
 		desc->interrupt_parent = of_irq_find_parent(np);
+		if (desc->interrupt_parent == np)
+			desc->interrupt_parent = NULL;
 		list_add_tail(&desc->list, &intc_desc_list);
 	}
 
-- 
1.7.5.4

Re: [PATCH] of/irq: of_irq_init: add check for parent equal to child node

[Pawel Moll]

On Sun, 2011-11-27 at 20:49 -0600, Rob Herring wrote:
> From: Rob Herring <rob.herring@calxeda.com>
> 
> With the revert of "of/irq: of_irq_find_parent: check for parent equal to
> child" (dc9372808412edb), we need another way to handle parent node equal
> to the child node. This can simply be handled in of_irq_init by checking
> for this condition.
> 
> Signed-off-by: Rob Herring <rob.herring@calxeda.com>

Works for me, thanks!

Tested-by: Pawel Moll <pawel.moll@arm.com>

Cheers!

Paweł

RE: [PATCH] of/irq: of_irq_init: add check for parent equal to child node

[Stephen Warren]

Rob Herring wrote at Sunday, November 27, 2011 7:49 PM:
> From: Rob Herring <rob.herring@calxeda.com>
> 
> With the revert of "of/irq: of_irq_find_parent: check for parent equal to
> child" (dc9372808412edb), we need another way to handle parent node equal
> to the child node. This can simply be handled in of_irq_init by checking
> for this condition.
> 
> Signed-off-by: Rob Herring <rob.herring@calxeda.com>

Tested-by: Stephen Warren <swarren@nvidia.com>

This fixed the issue I was having testing a Tegra patch that converted
over to the new ARM GIC bindings.

-- 
nvpublic