mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] IB/ehca: Use kcalloc instead of kzalloc to allocate array
@ 2011-11-29 21:08 Thomas Meyer
  0 siblings, 0 replies; only message in thread
From: Thomas Meyer @ 2011-11-29 21:08 UTC (permalink / raw)
  To: linux-rdma, linux-kernel

The advantage of kcalloc is, that will prevent integer overflows which could
result from the multiplication of number of elements and size and it is also
a bit nicer to read.

The semantic patch that makes this change is available
in https://lkml.org/lkml/2011/11/25/107

Signed-off-by: Thomas Meyer <thomas@m3y3r.de>
---

diff -u -p a/drivers/infiniband/hw/ehca/ehca_qp.c b/drivers/infiniband/hw/ehca/ehca_qp.c
--- a/drivers/infiniband/hw/ehca/ehca_qp.c 2011-11-13 11:07:26.513489332 +0100
+++ b/drivers/infiniband/hw/ehca/ehca_qp.c 2011-11-28 19:51:39.771888018 +0100
@@ -853,10 +853,9 @@ static struct ehca_qp *internal_create_q
 			/* alloc array to cache subsequent modify qp parms
 			 * for autodetect mode
 			 */
-			my_qp->mod_qp_parm =
-				kzalloc(EHCA_MOD_QP_PARM_MAX *
-					sizeof(*my_qp->mod_qp_parm),
-					GFP_KERNEL);
+			my_qp->mod_qp_parm = kcalloc(EHCA_MOD_QP_PARM_MAX,
+						     sizeof(*my_qp->mod_qp_parm),
+						     GFP_KERNEL);
 			if (!my_qp->mod_qp_parm) {
 				ehca_err(pd->device,
 					 "Could not alloc mod_qp_parm");

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2011-12-10 12:51 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-11-29 21:08 [PATCH] IB/ehca: Use kcalloc instead of kzalloc to allocate array Thomas Meyer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®