mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH 1/1] Staging: hv: mousevsc: Properly add the hid device
@ 2011-11-30 16:52 K. Y. Srinivasan
  2011-12-01 19:55 ` Jiri Kosina
  0 siblings, 1 reply; 2+ messages in thread
From: K. Y. Srinivasan @ 2011-11-30 16:52 UTC (permalink / raw)
  To: gregkh, linux-kernel, devel, virtualization, ohering, joe,
	dmitry.torokhov, jkosina
  Cc: K. Y. Srinivasan, Haiyang Zhang

We need to properly add the hid device to correctly initialize the
sysfs state. While this patch is against the staging tree; Jiri,
please pick up this patch as you merge the Hyper-V mouse driver.

Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
Reported-by: Fuzhou Chen <fuzhouch@microsoft.com>
---
 drivers/staging/hv/hv_mouse.c |    4 ++++
 1 files changed, 4 insertions(+), 0 deletions(-)

diff --git a/drivers/staging/hv/hv_mouse.c b/drivers/staging/hv/hv_mouse.c
index a28c549..66da8e3 100644
--- a/drivers/staging/hv/hv_mouse.c
+++ b/drivers/staging/hv/hv_mouse.c
@@ -519,6 +519,10 @@ static int mousevsc_probe(struct hv_device *device,
 
 	sprintf(hid_dev->name, "%s", "Microsoft Vmbus HID-compliant Mouse");
 
+	ret = hid_add_device(hid_dev);
+	if (ret)
+		goto probe_err1;
+
 	ret = hid_parse_report(hid_dev, input_dev->report_desc,
 				input_dev->report_desc_size);
 
-- 
1.7.4.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH 1/1] Staging: hv: mousevsc: Properly add the hid device
  2011-11-30 16:52 [PATCH 1/1] Staging: hv: mousevsc: Properly add the hid device K. Y. Srinivasan
@ 2011-12-01 19:55 ` Jiri Kosina
  0 siblings, 0 replies; 2+ messages in thread
From: Jiri Kosina @ 2011-12-01 19:55 UTC (permalink / raw)
  To: K. Y. Srinivasan
  Cc: gregkh, linux-kernel, devel, virtualization, ohering, joe,
	dmitry.torokhov, Haiyang Zhang

On Wed, 30 Nov 2011, K. Y. Srinivasan wrote:

> We need to properly add the hid device to correctly initialize the
> sysfs state. While this patch is against the staging tree; Jiri,
> please pick up this patch as you merge the Hyper-V mouse driver.
> 
> Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
> Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
> Reported-by: Fuzhou Chen <fuzhouch@microsoft.com>
> ---
>  drivers/staging/hv/hv_mouse.c |    4 ++++
>  1 files changed, 4 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/staging/hv/hv_mouse.c b/drivers/staging/hv/hv_mouse.c
> index a28c549..66da8e3 100644
> --- a/drivers/staging/hv/hv_mouse.c
> +++ b/drivers/staging/hv/hv_mouse.c
> @@ -519,6 +519,10 @@ static int mousevsc_probe(struct hv_device *device,
>  
>  	sprintf(hid_dev->name, "%s", "Microsoft Vmbus HID-compliant Mouse");
>  
> +	ret = hid_add_device(hid_dev);
> +	if (ret)
> +		goto probe_err1;
> +
>  	ret = hid_parse_report(hid_dev, input_dev->report_desc,
>  				input_dev->report_desc_size);
>  

I have refreshed the patch to apply to drivers/hid/hid-hyperv.c driver and 
applied. Thanks,

-- 
Jiri Kosina
SUSE Labs

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2011-12-01 19:55 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-11-30 16:52 [PATCH 1/1] Staging: hv: mousevsc: Properly add the hid device K. Y. Srinivasan
2011-12-01 19:55 ` Jiri Kosina

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®