From: Robert Richter <robert.richter@amd.com>
To: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Ingo Molnar <mingo@elte.hu>,
Peter Zijlstra <peterz@infradead.org>,
Stephane Eranian <eranian@google.com>,
Frederic Weisbecker <fweisbec@gmail.com>,
LKML <linux-kernel@vger.kernel.org>,
Robert Richter <robert.richter@amd.com>
Subject: [PATCH v2 1/7] perf tools: Continue processing header on unknown features
Date: Wed, 7 Dec 2011 10:02:51 +0100 [thread overview]
Message-ID: <1323248577-11268-2-git-send-email-robert.richter@amd.com> (raw)
In-Reply-To: <1323248577-11268-1-git-send-email-robert.richter@amd.com>
A feature may be unknown if perf.data is created and parsed on
different perf tool versions. This should not stop the header to be
processed, instead continue processing it.
Signed-off-by: Robert Richter <robert.richter@amd.com>
---
| 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
--git a/tools/perf/util/header.c b/tools/perf/util/header.c
index 9272f3a..47a7826 100644
--- a/tools/perf/util/header.c
+++ b/tools/perf/util/header.c
@@ -1105,7 +1105,7 @@ static int perf_file_section__fprintf_info(struct perf_file_section *section,
}
if (feat < HEADER_TRACE_INFO || feat >= HEADER_LAST_FEATURE) {
pr_warning("unknown feature %d\n", feat);
- return -1;
+ return 0;
}
if (!feat_ops[feat].print)
return 0;
--
1.7.7
next prev parent reply other threads:[~2011-12-07 9:06 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-07 9:02 [PATCH v2 0/7] perf tools: cleanups, fixes, updates Robert Richter
2011-12-07 9:02 ` Robert Richter [this message]
2011-12-29 20:52 ` [tip:perf/core] perf tools: Continue processing header on unknown features tip-bot for Robert Richter
2011-12-07 9:02 ` [PATCH v2 2/7] perf tools: Fix out-of-bound access to struct perf_session Robert Richter
2011-12-29 20:53 ` [tip:perf/core] " tip-bot for Robert Richter
2011-12-07 9:02 ` [PATCH v2 3/7] perf tool: Moving code in some files Robert Richter
2011-12-29 20:53 ` [tip:perf/core] perf tools: " tip-bot for Robert Richter
2011-12-07 9:02 ` [PATCH v2 4/7] perf report: Accept fifos as input file Robert Richter
2011-12-29 20:54 ` [tip:perf/core] " tip-bot for Robert Richter
2011-12-07 9:02 ` [PATCH v2 5/7] perf tool: Unify handling of features when writing feature section Robert Richter
2011-12-29 20:55 ` [tip:perf/core] perf tools: " tip-bot for Robert Richter
2011-12-07 9:02 ` [PATCH v2 6/7] perf tools: Improve macros for struct feature_ops Robert Richter
2011-12-29 20:51 ` [tip:perf/core] " tip-bot for Robert Richter
2011-12-07 9:02 ` [PATCH v2 7/7] perf tools: Use for_each_set_bit() to iterate over feature flags Robert Richter
2011-12-29 20:56 ` [tip:perf/core] " tip-bot for Robert Richter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1323248577-11268-2-git-send-email-robert.richter@amd.com \
--to=robert.richter@amd.com \
--cc=acme@redhat.com \
--cc=eranian@google.com \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome