From: Robert Richter <robert.richter@amd.com>
To: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Ingo Molnar <mingo@elte.hu>,
Peter Zijlstra <peterz@infradead.org>,
Stephane Eranian <eranian@google.com>,
Frederic Weisbecker <fweisbec@gmail.com>,
LKML <linux-kernel@vger.kernel.org>,
Robert Richter <robert.richter@amd.com>
Subject: [PATCH v2 6/7] perf tools: Improve macros for struct feature_ops
Date: Wed, 7 Dec 2011 10:02:56 +0100 [thread overview]
Message-ID: <1323248577-11268-7-git-send-email-robert.richter@amd.com> (raw)
In-Reply-To: <1323248577-11268-1-git-send-email-robert.richter@amd.com>
Reducing duplication and line size by extending function names for
print and write from a single name.
Signed-off-by: Robert Richter <robert.richter@amd.com>
---
| 40 ++++++++++++++++++++++------------------
1 files changed, 22 insertions(+), 18 deletions(-)
--git a/tools/perf/util/header.c b/tools/perf/util/header.c
index 129c92d..f1d0a95 100644
--- a/tools/perf/util/header.c
+++ b/tools/perf/util/header.c
@@ -1311,26 +1311,30 @@ struct feature_ops {
bool full_only;
};
-#define FEAT_OPA(n, w, p) \
- [n] = { .name = #n, .write = w, .print = p }
-#define FEAT_OPF(n, w, p) \
- [n] = { .name = #n, .write = w, .print = p, .full_only = true }
+#define FEAT_OPA(n, func) \
+ [n] = { .name = #n, .write = write_##func, .print = print_##func }
+#define FEAT_OPF(n, func) \
+ [n] = { .name = #n, .write = write_##func, .print = print_##func, .full_only = true }
+
+/* feature_ops not implemented: */
+#define print_trace_info NULL
+#define print_build_id NULL
static const struct feature_ops feat_ops[HEADER_LAST_FEATURE] = {
- FEAT_OPA(HEADER_TRACE_INFO, write_trace_info, NULL),
- FEAT_OPA(HEADER_BUILD_ID, write_build_id, NULL),
- FEAT_OPA(HEADER_HOSTNAME, write_hostname, print_hostname),
- FEAT_OPA(HEADER_OSRELEASE, write_osrelease, print_osrelease),
- FEAT_OPA(HEADER_VERSION, write_version, print_version),
- FEAT_OPA(HEADER_ARCH, write_arch, print_arch),
- FEAT_OPA(HEADER_NRCPUS, write_nrcpus, print_nrcpus),
- FEAT_OPA(HEADER_CPUDESC, write_cpudesc, print_cpudesc),
- FEAT_OPA(HEADER_CPUID, write_cpuid, print_cpuid),
- FEAT_OPA(HEADER_TOTAL_MEM, write_total_mem, print_total_mem),
- FEAT_OPA(HEADER_EVENT_DESC, write_event_desc, print_event_desc),
- FEAT_OPA(HEADER_CMDLINE, write_cmdline, print_cmdline),
- FEAT_OPF(HEADER_CPU_TOPOLOGY, write_cpu_topology, print_cpu_topology),
- FEAT_OPF(HEADER_NUMA_TOPOLOGY, write_numa_topology, print_numa_topology),
+ FEAT_OPA(HEADER_TRACE_INFO, trace_info),
+ FEAT_OPA(HEADER_BUILD_ID, build_id),
+ FEAT_OPA(HEADER_HOSTNAME, hostname),
+ FEAT_OPA(HEADER_OSRELEASE, osrelease),
+ FEAT_OPA(HEADER_VERSION, version),
+ FEAT_OPA(HEADER_ARCH, arch),
+ FEAT_OPA(HEADER_NRCPUS, nrcpus),
+ FEAT_OPA(HEADER_CPUDESC, cpudesc),
+ FEAT_OPA(HEADER_CPUID, cpuid),
+ FEAT_OPA(HEADER_TOTAL_MEM, total_mem),
+ FEAT_OPA(HEADER_EVENT_DESC, event_desc),
+ FEAT_OPA(HEADER_CMDLINE, cmdline),
+ FEAT_OPF(HEADER_CPU_TOPOLOGY, cpu_topology),
+ FEAT_OPF(HEADER_NUMA_TOPOLOGY, numa_topology),
};
struct header_print_data {
--
1.7.7
next prev parent reply other threads:[~2011-12-07 9:03 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-07 9:02 [PATCH v2 0/7] perf tools: cleanups, fixes, updates Robert Richter
2011-12-07 9:02 ` [PATCH v2 1/7] perf tools: Continue processing header on unknown features Robert Richter
2011-12-29 20:52 ` [tip:perf/core] " tip-bot for Robert Richter
2011-12-07 9:02 ` [PATCH v2 2/7] perf tools: Fix out-of-bound access to struct perf_session Robert Richter
2011-12-29 20:53 ` [tip:perf/core] " tip-bot for Robert Richter
2011-12-07 9:02 ` [PATCH v2 3/7] perf tool: Moving code in some files Robert Richter
2011-12-29 20:53 ` [tip:perf/core] perf tools: " tip-bot for Robert Richter
2011-12-07 9:02 ` [PATCH v2 4/7] perf report: Accept fifos as input file Robert Richter
2011-12-29 20:54 ` [tip:perf/core] " tip-bot for Robert Richter
2011-12-07 9:02 ` [PATCH v2 5/7] perf tool: Unify handling of features when writing feature section Robert Richter
2011-12-29 20:55 ` [tip:perf/core] perf tools: " tip-bot for Robert Richter
2011-12-07 9:02 ` Robert Richter [this message]
2011-12-29 20:51 ` [tip:perf/core] perf tools: Improve macros for struct feature_ops tip-bot for Robert Richter
2011-12-07 9:02 ` [PATCH v2 7/7] perf tools: Use for_each_set_bit() to iterate over feature flags Robert Richter
2011-12-29 20:56 ` [tip:perf/core] " tip-bot for Robert Richter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1323248577-11268-7-git-send-email-robert.richter@amd.com \
--to=robert.richter@amd.com \
--cc=acme@redhat.com \
--cc=eranian@google.com \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome