From: Andi Kleen <andi@firstfloor.org>
To: linux-kernel@vger.kernel.org
Cc: Andi Kleen <ak@linux.intel.com>
Subject: [PATCH] panic: Don't print redundant backtraces on oops
Date: Wed, 7 Dec 2011 16:36:43 -0800 [thread overview]
Message-ID: <1323304603-27895-1-git-send-email-andi@firstfloor.org> (raw)
From: Andi Kleen <ak@linux.intel.com>
When an oops causes a panic and panic prints another backtrace it's
pretty common to have the original oops data be scrolled away on a 80x50
screen.
The second backtrace is quite redundant and not needed anyways.
So don't print the panic backtrace when oops_in_progress is true.
Signed-off-by: Andi Kleen <ak@linux.intel.com>
---
kernel/panic.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/kernel/panic.c b/kernel/panic.c
index b2659360..398412b 100644
--- a/kernel/panic.c
+++ b/kernel/panic.c
@@ -78,7 +78,8 @@ NORET_TYPE void panic(const char * fmt, ...)
va_end(args);
printk(KERN_EMERG "Kernel panic - not syncing: %s\n",buf);
#ifdef CONFIG_DEBUG_BUGVERBOSE
- dump_stack();
+ if (!oops_in_progress)
+ dump_stack();
#endif
/*
--
1.7.4.4
next reply other threads:[~2011-12-08 0:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-08 0:36 Andi Kleen [this message]
2011-12-17 0:52 ` Andrew Morton
2011-12-19 14:09 ` Michael Holzheu
2011-12-19 18:34 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1323304603-27895-1-git-send-email-andi@firstfloor.org \
--to=andi@firstfloor.org \
--cc=ak@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®