From: Andi Kleen <ak@linux.intel.com>
To: holzheu@linux.vnet.ibm.com
Cc: Andrew Morton <akpm@linux-foundation.org>,
Andi Kleen <andi@firstfloor.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] panic: Don't print redundant backtraces on oops
Date: Mon, 19 Dec 2011 10:34:21 -0800 [thread overview]
Message-ID: <4EEF83AD.4010800@linux.intel.com> (raw)
In-Reply-To: <1324303755.2726.4.camel@br98xy6r>
it?
> I think the two problems are not related. My problem was that only one
> CPU should execute panic. Andi's problem is that one (or more oops)
> messages are scrolled away by a subsequent panic.
Yes it's just for making panic less chatty.
> But I am not sure if Andi's patch solves all his problems. What e.g.
> about panic_on_oom? Don't we have the same problem here?
Yes, it only solves it for this specific -- but common -- case. Or at
least it was a case
that annoyed me and prompted me to write the patch :)
I had a patch some time ago for a xpanic() where the caller could pass
in additional
flags, including one to disable the backtrace. But that was a much
larger patch,
this was a simpler alternative.
-Andi
prev parent reply other threads:[~2011-12-19 18:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-08 0:36 Andi Kleen
2011-12-17 0:52 ` Andrew Morton
2011-12-19 14:09 ` Michael Holzheu
2011-12-19 18:34 ` Andi Kleen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EEF83AD.4010800@linux.intel.com \
--to=ak@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=holzheu@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome