mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andi Kleen <andi@firstfloor.org>
To: linux-kernel@vger.kernel.org
Cc: kay.sievers@vrfy.org, trenn@suse.de,
	Andi Kleen <ak@linux.intel.com>,
	fenghua.yu@intel.com, khali@linux-fr.org,
	guenter.roeck@ericsson.com
Subject: [PATCH 06/10] HWMON: Convert coretemp to x86 cpuid autoprobing
Date: Wed,  7 Dec 2011 16:41:19 -0800	[thread overview]
Message-ID: <1323304882-27953-7-git-send-email-andi@firstfloor.org> (raw)
In-Reply-To: <1323304882-27953-1-git-send-email-andi@firstfloor.org>

From: Andi Kleen <ak@linux.intel.com>

Use the new x86 cpuid autoprobe interface for the Intel coretemp
driver.

Cc: fenghua.yu@intel.com
Cc: khali@linux-fr.org
Cc: guenter.roeck@ericsson.com
Signed-off-by: Andi Kleen <ak@linux.intel.com>
---
 drivers/hwmon/coretemp.c |   17 ++++++++++++++---
 1 files changed, 14 insertions(+), 3 deletions(-)

diff --git a/drivers/hwmon/coretemp.c b/drivers/hwmon/coretemp.c
index 104b376..5de1579 100644
--- a/drivers/hwmon/coretemp.c
+++ b/drivers/hwmon/coretemp.c
@@ -39,6 +39,7 @@
 #include <linux/moduleparam.h>
 #include <asm/msr.h>
 #include <asm/processor.h>
+#include <asm/cpu_device_id.h>
 
 #define DRVNAME	"coretemp"
 
@@ -756,13 +757,23 @@ static struct notifier_block coretemp_cpu_notifier __refdata = {
 	.notifier_call = coretemp_cpu_callback,
 };
 
+static struct x86_cpu_id coretemp_ids[] = {
+	{ X86_VENDOR_INTEL, X86_FAMILY_ANY, X86_MODEL_ANY, X86_FEATURE_DTS },
+	{}
+};
+MODULE_DEVICE_TABLE(x86cpu, coretemp_ids);
+
 static int __init coretemp_init(void)
 {
 	int i, err = -ENODEV;
 
-	/* quick check if we run Intel */
-	if (cpu_data(0).x86_vendor != X86_VENDOR_INTEL)
-		goto exit;
+	/*
+	 * CPUID.06H.EAX[0] indicates whether the CPU has thermal
+	 * sensors. We check this bit only, all the early CPUs
+	 * without thermal sensors will be filtered out.
+	 */
+	if (!x86_match_cpu(coretemp_ids))
+		return -ENODEV;
 
 	err = platform_driver_register(&coretemp_driver);
 	if (err)
-- 
1.7.4.4


  parent reply	other threads:[~2011-12-08  0:42 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-12-08  0:41 Updated cpu module autoprobing patchkit Andi Kleen
2011-12-08  0:41 ` [PATCH 01/10] Add driver auto probing for x86 features Andi Kleen
2011-12-08  1:57   ` H. Peter Anvin
2011-12-08  9:35   ` Jean Delvare
2011-12-08 14:45     ` Andi Kleen
2011-12-09 20:16       ` Jean Delvare
2011-12-09 20:24         ` Andi Kleen
2011-12-09 20:28           ` Jean Delvare
2011-12-16  1:25         ` H. Peter Anvin
2011-12-08  0:41 ` [PATCH 02/10] crypto: Add support for x86 cpuid auto loading for x86 crypto drivers Andi Kleen
2011-12-08  0:41 ` [PATCH 03/10] intel-idle: convert to x86_cpu_id auto probing Andi Kleen
2011-12-08  0:41 ` [PATCH 04/10] ACPI: Load acpi-cpufreq from processor driver automatically Andi Kleen
2011-12-08  0:41 ` [PATCH 05/10] HWMON: Convert via-cputemp to x86 cpuid autoprobing Andi Kleen
2011-12-08 10:51   ` Jean Delvare
2011-12-08  0:41 ` Andi Kleen [this message]
2011-12-08  2:40   ` [PATCH 06/10] HWMON: Convert coretemp " Guenter Roeck
2011-12-08  7:24     ` Jean Delvare
2011-12-08 16:09       ` Guenter Roeck
2011-12-08 16:13         ` Jean Delvare
2011-12-08 20:58           ` Andi Kleen
2011-12-08 14:35     ` Andi Kleen
2011-12-08  0:41 ` [PATCH 07/10] cpufreq: Add support for x86 cpuinfo auto loading Andi Kleen
2011-12-08  1:07   ` Dave Jones
2011-12-08  1:13     ` Andi Kleen
2011-12-08  1:24       ` Dave Jones
2011-12-08  4:01         ` Andi Kleen
2011-12-08  8:49   ` Borislav Petkov
2011-12-08 14:37     ` Andi Kleen
2011-12-16  1:19       ` H. Peter Anvin
2011-12-16  2:12         ` Andi Kleen
2011-12-08  0:41 ` [PATCH 08/10] x86: autoload microcode driver on Intel and AMD systems Andi Kleen
2011-12-08  0:41 ` [PATCH 09/10] x86: Add a test module for cpu loading Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1323304882-27953-7-git-send-email-andi@firstfloor.org \
    --to=andi@firstfloor.org \
    --cc=ak@linux.intel.com \
    --cc=fenghua.yu@intel.com \
    --cc=guenter.roeck@ericsson.com \
    --cc=kay.sievers@vrfy.org \
    --cc=khali@linux-fr.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=trenn@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®