From: Jean Delvare <khali@linux-fr.org>
To: Andi Kleen <ak@linux.intel.com>
Cc: Andi Kleen <andi@firstfloor.org>,
linux-kernel@vger.kernel.org, kay.sievers@vrfy.org,
trenn@suse.de, davej@redhat.com, axboe@kernel.dk, hpa@zytor.com,
herbert@gondor.hengli.com.au, ying.huang@intel.com,
lenb@kernel.org
Subject: Re: [PATCH 01/10] Add driver auto probing for x86 features
Date: Fri, 9 Dec 2011 21:28:42 +0100 [thread overview]
Message-ID: <20111209212842.0b2ec9c7@endymion.delvare> (raw)
In-Reply-To: <4EE26E8F.9010000@linux.intel.com>
On Fri, 09 Dec 2011 12:24:47 -0800, Andi Kleen wrote:
>
> > Can you guarantee that there is no asymmetric system already working
> > today?
>
> I used to have an asymmetric system myself, but we generally subset the
> CPU feature
> flags to be the same everywhere and I didn't change any per CPU stepping
> checks
> as they were there.
>
> > If you can't, then your approach could cause a regression. This
> > is why I am asking for an API change to let drivers pass a specific CPU
> > to x86_match_cpu(). There are at least two drivers who would take
> > benefit of this. Your patch set is supposed to only add driver
> > auto-loading, and while cleaning up the code in the process is nice, I
> > think you should avoid driver behavior changes, these are out of scope
> > for such a patch set.
>
> I undoed that change to the coretemp driver
Thanks.
> and there's no other AFAIK.
via-cputemp was affected as well.
> Generally most drivers only check the boot cpu.
--
Jean Delvare
next prev parent reply other threads:[~2011-12-09 20:28 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-08 0:41 Updated cpu module autoprobing patchkit Andi Kleen
2011-12-08 0:41 ` [PATCH 01/10] Add driver auto probing for x86 features Andi Kleen
2011-12-08 1:57 ` H. Peter Anvin
2011-12-08 9:35 ` Jean Delvare
2011-12-08 14:45 ` Andi Kleen
2011-12-09 20:16 ` Jean Delvare
2011-12-09 20:24 ` Andi Kleen
2011-12-09 20:28 ` Jean Delvare [this message]
2011-12-16 1:25 ` H. Peter Anvin
2011-12-08 0:41 ` [PATCH 02/10] crypto: Add support for x86 cpuid auto loading for x86 crypto drivers Andi Kleen
2011-12-08 0:41 ` [PATCH 03/10] intel-idle: convert to x86_cpu_id auto probing Andi Kleen
2011-12-08 0:41 ` [PATCH 04/10] ACPI: Load acpi-cpufreq from processor driver automatically Andi Kleen
2011-12-08 0:41 ` [PATCH 05/10] HWMON: Convert via-cputemp to x86 cpuid autoprobing Andi Kleen
2011-12-08 10:51 ` Jean Delvare
2011-12-08 0:41 ` [PATCH 06/10] HWMON: Convert coretemp " Andi Kleen
2011-12-08 2:40 ` Guenter Roeck
2011-12-08 7:24 ` Jean Delvare
2011-12-08 16:09 ` Guenter Roeck
2011-12-08 16:13 ` Jean Delvare
2011-12-08 20:58 ` Andi Kleen
2011-12-08 14:35 ` Andi Kleen
2011-12-08 0:41 ` [PATCH 07/10] cpufreq: Add support for x86 cpuinfo auto loading Andi Kleen
2011-12-08 1:07 ` Dave Jones
2011-12-08 1:13 ` Andi Kleen
2011-12-08 1:24 ` Dave Jones
2011-12-08 4:01 ` Andi Kleen
2011-12-08 8:49 ` Borislav Petkov
2011-12-08 14:37 ` Andi Kleen
2011-12-16 1:19 ` H. Peter Anvin
2011-12-16 2:12 ` Andi Kleen
2011-12-08 0:41 ` [PATCH 08/10] x86: autoload microcode driver on Intel and AMD systems Andi Kleen
2011-12-08 0:41 ` [PATCH 09/10] x86: Add a test module for cpu loading Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111209212842.0b2ec9c7@endymion.delvare \
--to=khali@linux-fr.org \
--cc=ak@linux.intel.com \
--cc=andi@firstfloor.org \
--cc=axboe@kernel.dk \
--cc=davej@redhat.com \
--cc=herbert@gondor.hengli.com.au \
--cc=hpa@zytor.com \
--cc=kay.sievers@vrfy.org \
--cc=lenb@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=trenn@suse.de \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®