From: Philipp Hortmann <philipp.g.hortmann@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: [PATCH 01/11] staging: rtl8192e: Remove entry .get_eeprom_size from struct rtl819x_ops
Date: Sun, 19 Feb 2023 22:15:33 +0100 [thread overview]
Message-ID: <1323e1ae2b4f52dc42b7ce5debca5608c9c5aafd.1676840647.git.philipp.g.hortmann@gmail.com> (raw)
In-Reply-To: <cover.1676840647.git.philipp.g.hortmann@gmail.com>
Remove entry .get_eeprom_size and replace it with function name
rtl92e_get_eeprom_size. This increases readability of the code.
Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
---
drivers/staging/rtl8192e/rtl8192e/rtl_core.c | 3 +--
drivers/staging/rtl8192e/rtl8192e/rtl_core.h | 1 -
2 files changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c b/drivers/staging/rtl8192e/rtl8192e/rtl_core.c
index 104b16cfa979..73f3d0973a5a 100644
--- a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c
+++ b/drivers/staging/rtl8192e/rtl8192e/rtl_core.c
@@ -27,7 +27,6 @@ static char *ifname = "wlan%d";
static const struct rtl819x_ops rtl819xp_ops = {
.nic_type = NIC_8192E,
- .get_eeprom_size = rtl92e_get_eeprom_size,
.init_adapter_variable = rtl92e_init_variables,
.initialize_adapter = rtl92e_start_adapter,
.link_change = rtl92e_link_change,
@@ -974,7 +973,7 @@ static short _rtl92e_init(struct net_device *dev)
_rtl92e_init_priv_variable(dev);
_rtl92e_init_priv_lock(priv);
_rtl92e_init_priv_task(dev);
- priv->ops->get_eeprom_size(dev);
+ rtl92e_get_eeprom_size(dev);
priv->ops->init_adapter_variable(dev);
_rtl92e_get_channel_map(dev);
diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_core.h b/drivers/staging/rtl8192e/rtl8192e/rtl_core.h
index fd96eef90c7f..00e413a644d2 100644
--- a/drivers/staging/rtl8192e/rtl8192e/rtl_core.h
+++ b/drivers/staging/rtl8192e/rtl8192e/rtl_core.h
@@ -205,7 +205,6 @@ struct rtl8192_tx_ring {
struct rtl819x_ops {
enum nic_t nic_type;
- void (*get_eeprom_size)(struct net_device *dev);
void (*init_adapter_variable)(struct net_device *dev);
void (*init_before_adapter_start)(struct net_device *dev);
bool (*initialize_adapter)(struct net_device *dev);
--
2.39.2
next prev parent reply other threads:[~2023-02-19 21:15 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-19 21:15 [PATCH 00/11] staging: rtl8192e: Remove entries from struct rtl819x_ops start with .get_eeprom_size Philipp Hortmann
2023-02-19 21:15 ` Philipp Hortmann [this message]
2023-02-19 21:15 ` [PATCH 02/11] staging: rtl8192e: Remove entry .init_adapter_.. from struct rtl819x_ops Philipp Hortmann
2023-02-19 21:15 ` [PATCH 03/11] staging: rtl8192e: Remove entry .initialize_ad.. " Philipp Hortmann
2023-02-19 21:15 ` [PATCH 04/11] staging: rtl8192e: Remove entry .tx_fill_descr.. " Philipp Hortmann
2023-02-19 21:16 ` [PATCH 05/11] staging: rtl8192e: Remove entry .tx_fill_cmd_d.. " Philipp Hortmann
2023-02-19 21:16 ` [PATCH 06/11] staging: rtl8192e: Remove entry .rx_query_stat.. " Philipp Hortmann
2023-02-19 21:16 ` [PATCH 07/11] staging: rtl8192e: Remove entry .stop_adapter " Philipp Hortmann
2023-02-19 21:16 ` [PATCH 08/11] staging: rtl8192e: Remove entry .update_ratr_t.. " Philipp Hortmann
2023-02-19 21:16 ` [PATCH 09/11] staging: rtl8192e: Remove entry .irq_enable " Philipp Hortmann
2023-02-19 21:16 ` [PATCH 10/11] staging: rtl8192e: Remove entry .irq_disable " Philipp Hortmann
2023-02-19 21:16 ` [PATCH 11/11] staging: rtl8192e: Remove entry .rx_enable " Philipp Hortmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1323e1ae2b4f52dc42b7ce5debca5608c9c5aafd.1676840647.git.philipp.g.hortmann@gmail.com \
--to=philipp.g.hortmann@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®