* [PATCH] gpio: gpio-langwell: fix IRQ wake functionality
@ 2012-01-11 9:08 Mathias Nyman
0 siblings, 0 replies; only message in thread
From: Mathias Nyman @ 2012-01-11 9:08 UTC (permalink / raw)
To: grant.likely; +Cc: linux-kernel, alan, Mathias Nyman, Artem Bityutskiy
Some chips are able to use gpio as a wake up source - e.g., you may want your
gpio button to wake up your device.
Currently 'irq_set_irq_wake()' is broken for gpio-langwell because the driver
does not provide the '->irq_set_wake()' method, which makes 'set_irq_wake_real()'
return -ENXIO, so that the 'IRQD_WAKEUP_STATE' bit is not changed. This also
causes the "Unbalanced IRQ X wake disable" warnings at some point.
This patch fixes the issue with the 'IRQCHIP_SKIP_SET_WAKE' flag. This flag
basically tells the the IRQ core subsystem that we support IRQ wakes but do
not need any driver-specific code.
Signed-off-by: Mathias Nyman <mathias.nyman@linux.intel.com>
Signed-off-by: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>
---
drivers/gpio/gpio-langwell.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/gpio/gpio-langwell.c b/drivers/gpio/gpio-langwell.c
index 00692e8..4bb748e 100644
--- a/drivers/gpio/gpio-langwell.c
+++ b/drivers/gpio/gpio-langwell.c
@@ -227,6 +227,7 @@ static struct irq_chip lnw_irqchip = {
.irq_mask = lnw_irq_mask,
.irq_unmask = lnw_irq_unmask,
.irq_set_type = lnw_irq_type,
+ .flags = IRQCHIP_SKIP_SET_WAKE,
};
static DEFINE_PCI_DEVICE_TABLE(lnw_gpio_ids) = { /* pin number */
--
1.7.4.1
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2012-01-11 9:07 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-01-11 9:08 [PATCH] gpio: gpio-langwell: fix IRQ wake functionality Mathias Nyman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®