* Re: autofs4 hung task [not found] <CAPM=9tzbgk=O6iTAM1Vp3SuZLkt7NnaMx0=+wbpW1x+sXk-3zA@mail.gmail.com> @ 2012-01-13 12:44 ` Ian Kent 2012-01-13 13:02 ` Al Viro 0 siblings, 1 reply; 3+ messages in thread From: Ian Kent @ 2012-01-13 12:44 UTC (permalink / raw) To: Dave Airlie; +Cc: LKML, Al Viro, Linus Torvalds On Fri, 2012-01-13 at 10:26 +0000, Dave Airlie wrote: > Hi guys, > > I booted Linus master kernel this morning (I was being brave and > basing some fixes on it), however it hung on boot and the stuck task > timer went off in autofs4 waiting on a mutex. > > I got a picture with my phone attached. Thanks Dave, an obvious mistake I missed in a recent commit by the look of it. Ian ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: autofs4 hung task 2012-01-13 12:44 ` autofs4 hung task Ian Kent @ 2012-01-13 13:02 ` Al Viro 2012-01-13 14:06 ` Dave Airlie 0 siblings, 1 reply; 3+ messages in thread From: Al Viro @ 2012-01-13 13:02 UTC (permalink / raw) To: Ian Kent; +Cc: Dave Airlie, LKML, Al Viro, Linus Torvalds On Fri, Jan 13, 2012 at 08:44:17PM +0800, Ian Kent wrote: > On Fri, 2012-01-13 at 10:26 +0000, Dave Airlie wrote: > > Hi guys, > > > > I booted Linus master kernel this morning (I was being brave and > > basing some fixes on it), however it hung on boot and the stuck task > > timer went off in autofs4 waiting on a mutex. > > > > I got a picture with my phone attached. > > Thanks Dave, an obvious mistake I missed in a recent commit by the look > of it. > > Ian Grr... Note to self: do git status *and* git stash show -p before git push. Nothing like "WTF? I'd fixed that braino" feeling ;-/ mutex_lock misspelled as mutex_unlock Buggered-in: commit d668dc56631da067540b2494d2a1f29ff7b5f15a Signed-off-by: Al Viro <viro@zeniv.linux.org.uk> --- diff --git a/fs/autofs4/waitq.c b/fs/autofs4/waitq.c index 9ef5b29..da8876d 100644 --- a/fs/autofs4/waitq.c +++ b/fs/autofs4/waitq.c @@ -76,7 +76,7 @@ static int autofs4_write(struct autofs_sb_info *sbi, data += wr; bytes -= wr; } - mutex_lock(&sbi->pipe_mutex); + mutex_unlock(&sbi->pipe_mutex); set_fs(fs); ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: autofs4 hung task 2012-01-13 13:02 ` Al Viro @ 2012-01-13 14:06 ` Dave Airlie 0 siblings, 0 replies; 3+ messages in thread From: Dave Airlie @ 2012-01-13 14:06 UTC (permalink / raw) To: Al Viro; +Cc: Ian Kent, LKML, Al Viro, Linus Torvalds >> Thanks Dave, an obvious mistake I missed in a recent commit by the look >> of it. >> >> Ian > > Grr... Note to self: do git status *and* git stash show -p before git push. > Nothing like "WTF? I'd fixed that braino" feeling ;-/ > > mutex_lock misspelled as mutex_unlock > > Buggered-in: commit d668dc56631da067540b2494d2a1f29ff7b5f15a > Signed-off-by: Al Viro <viro@zeniv.linux.org.uk> Thanks guys, up and running with Linus master with this patch. Tested-by: Dave Airlie <airlied@redhat.com> > --- > diff --git a/fs/autofs4/waitq.c b/fs/autofs4/waitq.c > index 9ef5b29..da8876d 100644 > --- a/fs/autofs4/waitq.c > +++ b/fs/autofs4/waitq.c > @@ -76,7 +76,7 @@ static int autofs4_write(struct autofs_sb_info *sbi, > data += wr; > bytes -= wr; > } > - mutex_lock(&sbi->pipe_mutex); > + mutex_unlock(&sbi->pipe_mutex); > > set_fs(fs); > ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-01-13 14:06 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CAPM=9tzbgk=O6iTAM1Vp3SuZLkt7NnaMx0=+wbpW1x+sXk-3zA@mail.gmail.com>
2012-01-13 12:44 ` autofs4 hung task Ian Kent
2012-01-13 13:02 ` Al Viro
2012-01-13 14:06 ` Dave Airlie
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®