* [PATCH] gpio: Add missing spin_lock_init in gpio-ml-ioh driver
@ 2012-01-17 7:18 Axel Lin
2012-01-17 8:23 ` Tomoya MORINAGA
0 siblings, 1 reply; 3+ messages in thread
From: Axel Lin @ 2012-01-17 7:18 UTC (permalink / raw)
To: linux-kernel; +Cc: Tomoya MORINAGA, Feng Tang, Grant Likely, Linus Walleij
I think this bug was introduced by commit 54be5663
"gpio-ml-ioh: Support interrupt function" which adds a spinlock to struct
ioh_gpio but never init the spinlock.
Signed-off-by: Axel Lin <axel.lin@gmail.com>
---
drivers/gpio/gpio-ml-ioh.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/gpio/gpio-ml-ioh.c b/drivers/gpio/gpio-ml-ioh.c
index 461958f..271fd49 100644
--- a/drivers/gpio/gpio-ml-ioh.c
+++ b/drivers/gpio/gpio-ml-ioh.c
@@ -448,6 +448,7 @@ static int __devinit ioh_gpio_probe(struct pci_dev *pdev,
chip->reg = chip->base;
chip->ch = i;
mutex_init(&chip->lock);
+ spin_lock_init(&chip->spinlock);
ioh_gpio_setup(chip, num_ports[i]);
ret = gpiochip_add(&chip->gpio);
if (ret) {
--
1.7.5.4
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] gpio: Add missing spin_lock_init in gpio-ml-ioh driver
2012-01-17 7:18 [PATCH] gpio: Add missing spin_lock_init in gpio-ml-ioh driver Axel Lin
@ 2012-01-17 8:23 ` Tomoya MORINAGA
2012-01-17 8:29 ` Axel Lin
0 siblings, 1 reply; 3+ messages in thread
From: Tomoya MORINAGA @ 2012-01-17 8:23 UTC (permalink / raw)
To: Axel Lin
Cc: linux-kernel, Tomoya MORINAGA, Feng Tang, Grant Likely, Linus Walleij
Hi Alex
Thank you for your indication.
gpio-pch also looks having the same issue.
Could you post the patch for gpio-pch ?
If you can't, I wil post the patch.
thanks,
tomoya
2012/1/17 Axel Lin <axel.lin@gmail.com>:
> I think this bug was introduced by commit 54be5663
> "gpio-ml-ioh: Support interrupt function" which adds a spinlock to struct
> ioh_gpio but never init the spinlock.
>
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
> ---
> drivers/gpio/gpio-ml-ioh.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/gpio/gpio-ml-ioh.c b/drivers/gpio/gpio-ml-ioh.c
> index 461958f..271fd49 100644
> --- a/drivers/gpio/gpio-ml-ioh.c
> +++ b/drivers/gpio/gpio-ml-ioh.c
> @@ -448,6 +448,7 @@ static int __devinit ioh_gpio_probe(struct pci_dev *pdev,
> chip->reg = chip->base;
> chip->ch = i;
> mutex_init(&chip->lock);
> + spin_lock_init(&chip->spinlock);
> ioh_gpio_setup(chip, num_ports[i]);
> ret = gpiochip_add(&chip->gpio);
> if (ret) {
> --
> 1.7.5.4
>
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] gpio: Add missing spin_lock_init in gpio-ml-ioh driver
2012-01-17 8:23 ` Tomoya MORINAGA
@ 2012-01-17 8:29 ` Axel Lin
0 siblings, 0 replies; 3+ messages in thread
From: Axel Lin @ 2012-01-17 8:29 UTC (permalink / raw)
To: Tomoya MORINAGA
Cc: linux-kernel, Tomoya MORINAGA, Feng Tang, Grant Likely, Linus Walleij
2012/1/17 Tomoya MORINAGA <tomoya.rohm@gmail.com>:
> Hi Alex
It's Axel :-)
>
> Thank you for your indication.
> gpio-pch also looks having the same issue.
> Could you post the patch for gpio-pch ?
Sure. I'll send the patch soon.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-01-17 8:29 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-01-17 7:18 [PATCH] gpio: Add missing spin_lock_init in gpio-ml-ioh driver Axel Lin
2012-01-17 8:23 ` Tomoya MORINAGA
2012-01-17 8:29 ` Axel Lin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome